November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Revert "Revert "core: errors during preview of diskless snap...
by yzaslavs＠redhat.com 14 Nov '12

14 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert "Revert "core: errors during preview of diskless snapshots"" ...................................................................... Revert "Revert "core: errors during preview of diskless snapshots"" This reverts commit a5b2196fdf9299ac774588aaaa68415e51ee509b --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 2 files changed, 16 insertions(+), 12 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c9fd926e61e860f4af9ff460c6657cf81b1fc85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add/Edit Network dialog bugs with message and vm n...
by alkaplan＠redhat.com 14 Nov '12

14 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add/Edit Network dialog bugs with message and vm network ...................................................................... webadmin: Add/Edit Network dialog bugs with message and vm network 1. Edit management network dialog didn't show correct message on top of it. 2. New Network dialog (from Cluster->Logical Network) didn't show correct message on top of it. 3. Vm network was always checked in Edit Network dialog (even if it is not vm network). Change-Id: I29fb26f2c62f501e6c08c706bba1174f91466228 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/NewClusterNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/NewClusterNetworkPopupView.java 8 files changed, 207 insertions(+), 176 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29fb26f2c62f501e6c08c706bba1174f91466228 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "core: errors during preview of diskless snapshots"
by mkublin＠redhat.com 14 Nov '12

14 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: Revert "core: errors during preview of diskless snapshots" ...................................................................... Revert "core: errors during preview of diskless snapshots" This reverts commit 383837efbdee6651e2032c0d6723078c099fb66d. The following commit introduced performance regression which will influence the performance of all system. Regression is: XML RPC call inside transaction Change-Id: I696457016d2b475e42be2c67b55fdf12b12d5193 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 2 files changed, 12 insertions(+), 16 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I696457016d2b475e42be2c67b55fdf12b12d5193 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixed bll tests logging
by yzaslavs＠redhat.com 14 Nov '12

14 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixed bll tests logging ...................................................................... core: Fixed bll tests logging Log4j configuration contains outdated package names from before oVirt was open sourced. This patch fixes those issues, and uses the correct org.ovirt.core package. Change-Id: Ia2370849ca588153f97be5884ee62bde0c63be55 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/resources/log4j.xml 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2370849ca588153f97be5884ee62bde0c63be55 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Introducing saveOrUpdate to AsyncTasks
by yzaslavs＠redhat.com 14 Nov '12

14 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Introducing saveOrUpdate to AsyncTasks ...................................................................... core: Introducing saveOrUpdate to AsyncTasks This performance improvement to the add or update of tasks is introduced - No more querying to check the db if tasks exists and according to it deciding if to save or update, but performing all this logic at DB side. Bug-Url: https://bugzilla.redhat.com/873546 Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd7e Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dbscripts/async_tasks_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java 5 files changed, 84 insertions(+), 7 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd7e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: re-run mechanism improvements
by ofrenkel＠redhat.com 14 Nov '12

14 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: re-run mechanism improvements ...................................................................... engine: re-run mechanism improvements - RunVmCommandBase#rerun method no longer invokes rerunInternal method within a different thread because there is no need for a different thread when it is called from the command itself. the code of rerunInternal method was moved to rerun method without creating a new thread to run it instead. when rerun method is invoked by VdsEventListener, its code should still run in a different thread so it is called from a new thread in VdsEventListener#rerun method. - adjust the rerun mechanism such that the logs & events would reflect the process better: * on re-run, log the results of the previous run before checking whether the maximum rerun attempts were exceeded, so that it would be logged every time. * add a missing log call after exceeding the maximum re-run attempts to log a message that indicates the command failed. * make sure that when a command that is being rerun is failed due to can-do-action check, the failure event will appear only once. Change-Id: I557636a94d74772635102c6a33dc923d91332a3e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 4 files changed, 30 insertions(+), 23 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I557636a94d74772635102c6a33dc923d91332a3e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UpdateVmDisk - clear snapshot_id for shareable disk
by derez＠redhat.com 14 Nov '12

14 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: core: UpdateVmDisk - clear snapshot_id for shareable disk ...................................................................... core: UpdateVmDisk - clear snapshot_id for shareable disk UpdateVmDiskCommand should nullify vm_snapshot_id when the disk is marked as shareable. Change-Id: I259759658c1baea8001fa151a5e861cecd8e794a Bug-Url: https://bugzilla.redhat.com/872945 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 27 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I259759658c1baea8001fa151a5e861cecd8e794a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Execution messages for Gluster Volume Actions (#8561...
by emesika＠redhat.com 14 Nov '12

14 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: engine: Execution messages for Gluster Volume Actions (#856102) ...................................................................... engine: Execution messages for Gluster Volume Actions (#856102) https://bugzilla.redhat.com/856102 Execution messages added for all Gluster Volume related actions. Change-Id: I93bb7b8b1f1ae4987c0887307bd373a28e9ad3d1 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93bb7b8b1f1ae4987c0887307bd373a28e9ad3d1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix imports in MoveImageGroupVDSCommand
by lhornyak＠redhat.com 14 Nov '12

14 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: fix imports in MoveImageGroupVDSCommand ...................................................................... core: fix imports in MoveImageGroupVDSCommand Change-Id: Ia313b6343d1e554476662dfc604d59d672088401 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia313b6343d1e554476662dfc604d59d672088401 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: engine: prevent NPE in clusters tab
by shavivi＠redhat.com 14 Nov '12

14 Nov '12

Shahar Havivi has submitted this change and it was merged. Change subject: engine: prevent NPE in clusters tab ...................................................................... engine: prevent NPE in clusters tab Change-Id: If8f344b9144880b3ecd755030594d28c12912043 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=871293 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterHostView.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8f344b9144880b3ecd755030594d28c12912043 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0