December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Extracts permission check algorithm
by masayag＠redhat.com 13 Dec '12

13 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extracts permission check algorithm ...................................................................... engine: Extracts permission check algorithm The patch extracts the permission check algorithm so it could be override by commands that require a specific behavior. Change-Id: I32e60540308c6bf6495b472608e307dc695edd11 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 37 insertions(+), 27 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32e60540308c6bf6495b472608e307dc695edd11 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Use proper dao api to detect used network
by masayag＠redhat.com 13 Dec '12

13 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use proper dao api to detect used network ...................................................................... engine: Use proper dao api to detect used network The patch simplifies the code of RemoveNetworkCommand by removing redundant code and using a proper method of the NetworkDao in order to detect if a specific network is used by a cluster instead of iterating all the cluster's networks. Change-Id: I95419986b99c23a741d28929532619f4c56da5a4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveNetworkCommand.java 1 file changed, 6 insertions(+), 17 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95419986b99c23a741d28929532619f4c56da5a4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Cleanup network commands
by masayag＠redhat.com 13 Dec '12

13 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Cleanup network commands ...................................................................... engine: Cleanup network commands Avoid static access to DbFacade instance. Change-Id: Idc02f4024b3c33cee5260bb82b03c25236a3830a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateInterfaceCommand.java 4 files changed, 23 insertions(+), 41 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc02f4024b3c33cee5260bb82b03c25236a3830a Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Restrict viewable networks by the User
by mkolesni＠redhat.com 13 Dec '12

13 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Restrict viewable networks by the User ...................................................................... engine: Restrict viewable networks by the User The patch restricts the viewable network by the user for: 1. Networks the user has permissions on 2. Data Center which contains the network and the user has permission on. 3. The Network is attached to the VM's nic or Template's nic. 4. Data-Center or Cluster that contains the VM/Template Change-Id: I542e687da8f51dd83e66d813c769275736abc114 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/network_sp.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 5 files changed, 97 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/9545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I542e687da8f51dd83e66d813c769275736abc114 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Require Permissions on Network
by masayag＠redhat.com 12 Dec '12

12 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Require Permissions on Network ...................................................................... engine: Require Permissions on Network Actions that using Networks will require specific permissions for the subjected network: Network's usage actions require users to have an action group CONFIGURE_VM_NETWORK/CONFIGURE_TEMPLATE_NETWORK for using the network. In order to configure PORT_MIRRORING the user must have PORT_MIRRORING action group on the network. The patch assumes the network name might be empty for creating a vNic which isn't connected to any network (as part of the Network Wiring feature). Change-Id: Ife019f6195b8a8c09e7dba989f37f150700dbaea Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateInterfaceCommand.java 4 files changed, 127 insertions(+), 12 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/9544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife019f6195b8a8c09e7dba989f37f150700dbaea Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: engine: Extend NetworkDao
by masayag＠redhat.com 12 Dec '12

12 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extend NetworkDao ...................................................................... engine: Extend NetworkDao The NetworkDao is extended with two methods for fetching the network entity by the following criteria: 1. By network name and storage pool id. 2. By network name and cluster id. The motivation is easing the process of fetching the network entity when is being queried either in scope of VM (find network which is attached to a VM) or in the scope of data center which previously was executed by getting the entire networks list for a DC/Cluster and filtering out the required network. Change-Id: If559aaf1ce824a0271874cf10cff1e42dd4647ba Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/network_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllNetworksQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAOHibernateImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkDAOTest.java 7 files changed, 237 insertions(+), 24 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/9543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If559aaf1ce824a0271874cf10cff1e42dd4647ba Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add option to mark network as public
by masayag＠redhat.com 12 Dec '12

12 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Add option to mark network as public ...................................................................... webadmin: Add option to mark network as public The patch adds a checkbox for the 'Add Network' dialog to mark the created network as public so it could be used (be attached to VMs) by any user in the system. Change-Id: Ib12cb6fc64a06d0305b59f74332c4e75bc05bfe8 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java 6 files changed, 37 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib12cb6fc64a06d0305b59f74332c4e75bc05bfe8 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add option to create network for public use
by masayag＠redhat.com 12 Dec '12

12 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add option to create network for public use ...................................................................... engine: Add option to create network for public use The patch adds an option on Network creation to define the network for public use. If configured for public use, 'everyone' will get permissions on the network with NetworkUser role. The motivation is to allow easy access and management of network so it could be accessed by the system's users. In addition, since the Networks entities are now managed as part of the MLA, the creator of the network will be granted with NetworkAdmin role for the created network. Change-Id: I14e046c7a98ab6f9de53bec5b8ccc73ac4ba672f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddNetworkCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java 2 files changed, 32 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14e046c7a98ab6f9de53bec5b8ccc73ac4ba672f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Update roles to support Network permissions
by masayag＠redhat.com 12 Dec '12

12 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Update roles to support Network permissions ...................................................................... engine: Update roles to support Network permissions The patch introduces a new role for network users: NetworkUser which provides the user the permissions for attaching a network to its VM. In addition, the upgrade script contains the roles and permissions updates as described on the feature page: 1. Separate CONFIGURE_STORAGE_POOL_NETWORK to three roles: 1.1. CREATE_STORAGE_POOL_NETWORK 1.2. DELETE_STORAGE_POOL_NETWORK 1.3. CONFIGURE_STORAGE_POOL_NETWORK - acts as EDIT action group 2. Associate ASSIGN_CLUSTER_NETWORK action group with SUPER_USER, DATA_CENTER_ADMIN and NETWORK_ADMIN. 3. Update Network Admin role 4. Grant 'NetworkUser' permission to 'everyone' for all of the networks. Change-Id: I5b1d13c7578e6c5fcbf0852cb63b1f6bc51a511d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0040_add_permissions_on_networks.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PredefinedRoles.java 2 files changed, 135 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/9539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b1d13c7578e6c5fcbf0852cb63b1f6bc51a511d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Remove Port Mirroring from User Role list
by masayag＠redhat.com 12 Dec '12

12 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Remove Port Mirroring from User Role list ...................................................................... webadmin: Remove Port Mirroring from User Role list Port mirroring should be defined as an Admin role only. Therefore it is removed from the User roles view. Change-Id: Ic1a38f098181a464d37b8c726c35f3661ea81abd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1a38f098181a464d37b8c726c35f3661ea81abd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0