December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: remove usb check from round trip tests
by mpastern＠redhat.com 27 Dec '12

27 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: remove usb check from round trip tests ...................................................................... restapi: remove usb check from round trip tests Remove the check whether the usb's enabled state remains the same in round trip mapping test of VmMapper and TemplateMapper. This check is incorrect because: 1. in case the received usb setting is enabled but with no valid type, it could be mapped to disabled (if it's a request to add new entity or if the previous usb setting of the entity was disabled) and remains disabled while mapping it back to rest api VM. thus checking that the enabled state of the given usb setting remains the same in the round trip mapping without checking that its type is valid is wrong. 2. the usb mapping was removed from the map methods of VmMapper and TemplateMapper classes, as it's overridden by the caller anyway (because the usb mapping requires information that cannot be access from inside of the map methods). so it makes no sense to check the usb settings it in this test that tests the map methods. Change-Id: Ib7ce32dca6821a8b6eb8d69fe18413c87a6f0b3f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7ce32dca6821a8b6eb8d69fe18413c87a6f0b3f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Filter Non-Operational DCs when adding new domain
by asaf＠redhat.com 27 Dec '12

27 Dec '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Filter Non-Operational DCs when adding new domain ...................................................................... webadmin: Filter Non-Operational DCs when adding new domain Filter Data Centers which their status is Non-Operational In the UI level when adding new storage domains. Change-Id: I8848c8bbd419b93e2e9ae1be5ebfd91baf28ed7e Bug-Url: https://bugzilla.redhat.com/841148 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java 2 files changed, 19 insertions(+), 2 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8848c8bbd419b93e2e9ae1be5ebfd91baf28ed7e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move template network queries to network package
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move template network queries to network package ...................................................................... engine: Move template network queries to network package Moved template network related queries to their correct package. Change-Id: Id90e6c15a748e2cdb108471bac0ba232352b58bd Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/GetTemplateInterfacesByTemplateIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/GetVmTemplatesAndNetworkInterfacesByNetworkIdQuery.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/template/GetTemplateInterfacesByTemplateIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/template/GetVmTemplatesAndNetworkInterfacesByNetworkIdQueryTest.java 4 files changed, 8 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id90e6c15a748e2cdb108471bac0ba232352b58bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move VM network queries to network package
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move VM network queries to network package ...................................................................... engine: Move VM network queries to network package Moved VM network related queries to their correct package. Change-Id: I247559c292173aa160d28fb5999669042158ffc9 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/GetVmInterfacesByVmIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/GetVmsAndNetworkInterfacesByNetworkIdQuery.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/GetVmInterfacesByVmIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/GetVmsAndNetworkInterfacesByNetworkIdQueryTest.java 4 files changed, 8 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I247559c292173aa160d28fb5999669042158ffc9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move host network queries to network package
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move host network queries to network package ...................................................................... engine: Move host network queries to network package Moved host network related queries to their correct package. Change-Id: I902b4336d130000c7df48e6a16e1d13efe03ee92 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllChildVlanInterfacesQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllSiblingVlanInterfacesQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetManagementInterfaceAddressByVmIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsFreeBondsByVdsIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsWithoutNetworkQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVlanParanetQuery.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetManagementInterfaceAddressByVmIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVdsWithoutNetworkQueryTest.java 11 files changed, 22 insertions(+), 11 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I902b4336d130000c7df48e6a16e1d13efe03ee92 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move cluster network queries to network package
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move cluster network queries to network package ...................................................................... engine: Move cluster network queries to network package Moved cluster network related queries to their correct package. Change-Id: I73ffad03df34139a29edb6c9a6cb996005df84a2 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/GetAllNetworksByClusterIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/GetNetworkDisplayByClusterIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/GetVdsGroupsAndNetworksByNetworkIdQuery.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/GetAllNetworksByClusterIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/GetVdsGroupsAndNetworksByNetworkIdQueryTest.java 5 files changed, 10 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73ffad03df34139a29edb6c9a6cb996005df84a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Delete copy&paste javadoc
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Delete copy&paste javadoc ...................................................................... engine: Delete copy&paste javadoc This javadoc is copy pasted so delete it. Change-Id: Id404e4f637c05ac09287974cb6430f682c3fd925 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMNameQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMTemplateNameQueryTest.java 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id404e4f637c05ac09287974cb6430f682c3fd925 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move DC network queries to network package
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move DC network queries to network package ...................................................................... engine: Move DC network queries to network package Moved DC network related queries to their correct package. Change-Id: Ib5b69b115d2eaa8bc5abb78617707b77a6297a43 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetAllNetworksQuery.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5b69b115d2eaa8bc5abb78617707b77a6297a43 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Deleted GetMACAddressQuery
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Deleted GetMACAddressQuery ...................................................................... engine: Deleted GetMACAddressQuery This query does nothing and is not used by clients, so deleting it. Change-Id: I79a300e931739436451b4b77434bcd858e0b4592 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetMACAddressQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 0 insertions(+), 36 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79a300e931739436451b4b77434bcd858e0b4592 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move hot plug command to network.vm package
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move hot plug command to network.vm package ...................................................................... engine: Move hot plug command to network.vm package The ActivateDeactivateVmNicCommand should sit in this package as it handles VM NIC. Change-Id: I1bd93a7062ebd396911d88988ce41473682da475 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bd93a7062ebd396911d88988ce41473682da475 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0