December 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: add NetworkLinking to ChangeVMClusterCommand

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: add NetworkLinking to ChangeVMClusterCommand ...................................................................... core: add NetworkLinking to ChangeVMClusterCommand When changing the VM Cluster- if the new Cluster doesn't support NetworkLinking and the VM has Vnics with 1. No network (null)- it is allowed. CanDoAction will be thrown when the user will try to run the vm. 2. Unlinked Network- canDoAction is thrown. Change-Id: Icc3dd865ccd99f23862db4f4a37aa5e816db3214 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java 1 file changed, 80 insertions(+), 40 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc3dd865ccd99f23862db4f4a37aa5e816db3214 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

12 years

1
0
0 / 0

Change in ovirt-engine[master]: engine: DetachNetworkToVdsGroup for NetworkLinking

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: DetachNetworkToVdsGroup for NetworkLinking ...................................................................... engine: DetachNetworkToVdsGroup for NetworkLinking This patch makes sure NPEs are avoided due to the new option for a VmNetworkInterface to have an empty Network name. Change-Id: I088b759698f1032c1236f93f96afe04fbb63a256 Signed-off-by: Muli Salem <msalem(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkToVdsGroupCommand.java 1 file changed, 16 insertions(+), 16 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I088b759698f1032c1236f93f96afe04fbb63a256 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

12 years

1
0
0 / 0

Change in ovirt-engine[master]: core: add NetworkLinking to UpdateVmTemplateInterfaceCommand

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: add NetworkLinking to UpdateVmTemplateInterfaceCommand ...................................................................... core: add NetworkLinking to UpdateVmTemplateInterfaceCommand - canDoAction- If "UnlinkingSupported" is false for the cluster compatibility version. - block 'null' network. - block unlinking. Change-Id: I8b22b20aeb4860226311c1691c6e684c72a07970 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateInterfaceCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b22b20aeb4860226311c1691c6e684c72a07970 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years

1
0
0 / 0

Change in ovirt-engine[master]: core: HotPlugNicVDSCommand should send "linkActive" to the v...

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: HotPlugNicVDSCommand should send "linkActive" to the vdsm. ...................................................................... core: HotPlugNicVDSCommand should send "linkActive" to the vdsm. - If "linked" property on VmNetworkInterface is true 'linkActive-> true' should be sent to the vdsm Otherwise- 'linkActive-> false' should be sent to the vdsm - If network name is null it should be sent. - CanDo should allow null network. Change-Id: I127fc3202702f8cb1920990eb77d9fbccdb9804b Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java 2 files changed, 18 insertions(+), 9 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I127fc3202702f8cb1920990eb77d9fbccdb9804b Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

12 years

1
0
0 / 0

Change in ovirt-engine[master]: core: add NetworkLinking support to RunVm command.

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: add NetworkLinking support to RunVm command. ...................................................................... core: add NetworkLinking support to RunVm command. - If "linked" property on VmNetworkInterface is true 'linkActive-> true' should be sent to the vdsm Otherwise- 'linkActive-> false' should be sent to the vdsm - If network name is null it should be sent. - Avoid NPE in vdsSelector. Change-Id: Ib9805b18c364685a6533b89cfa31ae0575a00ea5 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 5 files changed, 45 insertions(+), 21 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9805b18c364685a6533b89cfa31ae0575a00ea5 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

12 years

1
0
0 / 0

Change in ovirt-engine[master]: core: 'No Network' on a Vnic should be marked as null and no...

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: 'No Network' on a Vnic should be marked as null and not empty String. ...................................................................... core: 'No Network' on a Vnic should be marked as null and not empty String. If on importVm, the VM has Nics with non valid Network, the Network was deleted by setting it to empty String. Since NetworkLinking feature, the convention is to mark no-network as null and not as empty String. Change-Id: Ia802fc81be7d65d3f4039e757646918aae5dc0a3 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0140_allow_null_network_name_in_vm_interfaces.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java 3 files changed, 8 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia802fc81be7d65d3f4039e757646918aae5dc0a3 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

12 years

1
0
0 / 0

Change in ovirt-engine[master]: core: add NetworkLinking to AddVmInterfaceCommand

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: add NetworkLinking to AddVmInterfaceCommand ...................................................................... core: add NetworkLinking to AddVmInterfaceCommand - canDoAction- If "UnlinkingSupported" is false for the cluster compatibility version. - block 'null' network. - block unlinking. If "UnlinkingSupported" is true - allow 'null' network. Change-Id: I4f804e0d3117eed22814a8397d0fee12dd9e1347 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java 1 file changed, 25 insertions(+), 15 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f804e0d3117eed22814a8397d0fee12dd9e1347 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years

1
0
0 / 0

Change in ovirt-engine[master]: core: create UpdateVmInterfaceVDSCommand

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: create UpdateVmInterfaceVDSCommand ...................................................................... core: create UpdateVmInterfaceVDSCommand The command will be called from UpdateVmInterfaceCommand. It will be used to hot-update a vnic on a running vm. The fields that can be updated are- network linked (link state) Change-Id: Idc54fedde0fdf6ea9694fc19977bf1178e73efdf Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/UpdateVmInterfaceVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 6 files changed, 55 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc54fedde0fdf6ea9694fc19977bf1178e73efdf Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years

1
0
0 / 0

Change in ovirt-engine[master]: core: add NetworkLinking to UpdateVmInterfaceCommand

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: add NetworkLinking to UpdateVmInterfaceCommand ...................................................................... core: add NetworkLinking to UpdateVmInterfaceCommand - messages- add bll errors related to "linking feature" and Update command. - canDoAction- - Allow editing if the VM is Down. If "UnlinkingSupported" is false for the cluster compatibility version. - block 'null' network. - block unlinking. If "UnlinkingSupported" is true - allow 'null' network. Change-Id: I0ea914badc716f2908f45c020b53ced423ed23ec Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java 2 files changed, 180 insertions(+), 43 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ea914badc716f2908f45c020b53ced423ed23ec Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years

1
0
0 / 0

Change in ovirt-engine[master]: core: Add NetworkLinking support to UpdateVmCommand

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add NetworkLinking support to UpdateVmCommand ...................................................................... core: Add NetworkLinking support to UpdateVmCommand - Avoid NPE in case there is a vnic with null network. Change-Id: I48c014629678f634593e81e584fcbbb6083fddc7 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48c014629678f634593e81e584fcbbb6083fddc7 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits December 2012