December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Rename HotPlugUnplgNicVDSParameters
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Rename HotPlugUnplgNicVDSParameters ...................................................................... engine: Rename HotPlugUnplgNicVDSParameters Renamed the parameters to VmNicDeviceVDSParameters so that they can be used in other commands that need the same combination of parameters. Change-Id: Ie9f956a2dc00cfded652682a39521bf901917369 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmNicDeviceVDSParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotUnplugNicVDSCommand.java 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9f956a2dc00cfded652682a39521bf901917369 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding AbstractVmInterfaceCommand
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: adding AbstractVmInterfaceCommand ...................................................................... core: adding AbstractVmInterfaceCommand This command will contain common logic of VmIntrefaceCommands. For now, the logic of internaly calling activateNic (called from AddVmInterfaceCommnad and will be called from UpdateVmInterfaceCommanf in the future) was moved to AbstractVmInterfaceCommand. In the future other common logic can be placed here. Change-Id: I15acf7c715703582e96274f4621239b33d263172 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java 2 files changed, 45 insertions(+), 32 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15acf7c715703582e96274f4621239b33d263172 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : add NetwookLinking support to VmInterfaceManager
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core : add NetwookLinking support to VmInterfaceManager ...................................................................... core : add NetwookLinking support to VmInterfaceManager - Support the case when vm has vnic/s will null network. Change-Id: I16ef011a47efc6265787b845dc7af6fee5044578 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16ef011a47efc6265787b845dc7af6fee5044578 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding VdsmError for failure on VmUpdateDevice on Vnic...
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: adding VdsmError for failure on VmUpdateDevice on Vnic. ...................................................................... core: adding VdsmError for failure on VmUpdateDevice on Vnic. If the vdsm fails to update the Vnic via VmUpdateDevice the error UPDATE_VNIC_FAILED (translated to- Failed to update VM Network Interface.) will be thrown. Change-Id: I8e081a127fb39fa5c188d9f6b17a5fe0ca52c25b Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 5 files changed, 8 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e081a127fb39fa5c188d9f6b17a5fe0ca52c25b Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: allow editing VmInterface while the VM is running.
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: allow editing VmInterface while the VM is running. ...................................................................... core: allow editing VmInterface while the VM is running. NetworkLinking feature allows editig a VM while it is UP. Change-Id: I6870491156f264079c60d63c0d9321e9b4364192 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6870491156f264079c60d63c0d9321e9b4364192 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add NetworkLinking support to ImportVmTemplateComman...
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add NetworkLinking support to ImportVmTemplateCommand. ...................................................................... engine: Add NetworkLinking support to ImportVmTemplateCommand. - Add linking to the command. Change-Id: Ic21df30240b9cf212d359a0dd0e1a8d344c7466e Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic21df30240b9cf212d359a0dd0e1a8d344c7466e Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: copy "linked" property on VmNetworkInterface clone...
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: copy "linked" property on VmNetworkInterface cloner. ...................................................................... webadmin: copy "linked" property on VmNetworkInterface cloner. "linked" boolean is a new property added to VmNetworkInterface. It should also be copied by the cloner. Change-Id: Ic00991d1919234716f6f984ba3f27af41d620786 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic00991d1919234716f6f984ba3f27af41d620786 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add NetworkLinking support to OvfTemplate.
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add NetworkLinking support to OvfTemplate. ...................................................................... core: Add NetworkLinking support to OvfTemplate. - Support null networkName of a vnic. - New "Linked" property on a vnic- * Should be written to the ovf. * Should be read from the ovf if exists (backward compatibility). Change-Id: Ia11fe29f87836e43bd4de240da9160857b144605 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java 2 files changed, 15 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia11fe29f87836e43bd4de240da9160857b144605 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add NetworkLinking support to OvfVm.
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add NetworkLinking support to OvfVm. ...................................................................... core: Add NetworkLinking support to OvfVm. - Support null networkName of a vnic. - New "Linked" property on a vnic- * Should be written to the ovf. * Should be read from the ovf if exists (backward compatibility). Change-Id: If739dd0a2140fd714867c79389fe6efe133529ed Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfVmWriterTest.java 4 files changed, 46 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If739dd0a2140fd714867c79389fe6efe133529ed Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding "linked" property to VmNetworkInterface
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: adding "linked" property to VmNetworkInterface ...................................................................... core: adding "linked" property to VmNetworkInterface adding linked property to- - VmNetworkInterface class - vm_interface table - vm_interface_view Change-Id: I9c8d965b66201506d7e4b82d5b53012fd0bf7d61 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/network_sp.sql A backend/manager/dbscripts/upgrade/03_02_0130_add_linked_to_vm_interface.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 7 files changed, 40 insertions(+), 10 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c8d965b66201506d7e4b82d5b53012fd0bf7d61 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0