Change in ovirt-engine[master]: webadmin: VmDesktopNewPopupWidget cleanup
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: VmDesktopNewPopupWidget cleanup
......................................................................
webadmin: VmDesktopNewPopupWidget cleanup
- Rename the parameter for 'edit' method from object to unitVmModel
- Remove unused parameter for 'initTabAvailavility' method
Change-Id: Ib2ad2bb717edf6c25de43223febbfb8f351d9a85
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDesktopNewPopupWidget.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2ad2bb717edf6c25de43223febbfb8f351d9a85
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
12 years
Change in ovirt-engine[master]: webadmin: disabled style for 'specific host' label
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: disabled style for 'specific host' label
......................................................................
webadmin: disabled style for 'specific host' label
Add style for disabled label in AbstractVmPopupWidget, which is used for
the 'specific host' label (that appears in 'Host' tab of VM dialogs)
when the option to select a specific host to run on can't be changed.
Change-Id: Iae20a3dfed507d987504f110d20a6e4f03159e25
Bug-Url: https://bugzilla.redhat.com/867308
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDesktopNewPopupWidget.java
3 files changed, 12 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10295
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae20a3dfed507d987504f110d20a6e4f03159e25
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
12 years
Change in ovirt-engine[master]: webadmin: move logic from popup widget to its model
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: move logic from popup widget to its model
......................................................................
webadmin: move logic from popup widget to its model
This patch improves the previous patch for fixing bug #867308,
as the logic that determines whether a widget should be changable or
not is moved to the model, where it is more appropriate to be.
Change-Id: I05f5d1476cfeb711cff50f3143a0f0ad5cbc0803
Bug-Url: https://bugzilla.redhat.com/867308
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDesktopNewPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
2 files changed, 234 insertions(+), 222 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10294
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05f5d1476cfeb711cff50f3143a0f0ad5cbc0803
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
12 years
Change in ovirt-engine[master]: webadmin: allow changing name of VM attached to pool
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: allow changing name of VM attached to pool
......................................................................
webadmin: allow changing name of VM attached to pool
This is a quick solution for a requirement to be able to manage the
names of VMs which are attached to pools.
We let the user open edit dialog for VM which is attached to pool, and
in this dialog the only attribute the user can change is the VM's
name (all other widgets are disabled).
Change-Id: I139ca66f945657b4d2323d6669e595c77a8fad09
Bug-Url: https://bugzilla.redhat.com/867308
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDesktopNewPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
5 files changed, 105 insertions(+), 7 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10293
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I139ca66f945657b4d2323d6669e595c77a8fad09
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
12 years
Change in ovirt-engine[master]: core: Add attributes for CPU Thread Handling (1/4)
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Add attributes for CPU Thread Handling (1/4)
......................................................................
core: Add attributes for CPU Thread Handling (1/4)
This patch series adds support for CPU Thread Handling in which host
CPU threads can be considered as cores on a per-cluster basis for the
purpose of VM startup/shutdown/migration.
Further detail can be found in the wiki:
http://www.ovirt.org/Features/cpu_thread_handling
Patch 1: add database columns holding metadata needed to track host
data and cpu thread settings:
vds_dynamic.cpu_threads - boolean, CPU threads on host
vds_groups.count_threads_as_cores - boolean, whether cluster option to
count threads as cores is enabled by user
Also add code in engine-core to support these new objects, including
dao, business entities, object serialization (test), and VdsBroker.
Change-Id: I8fed81d00ec9086573877145dff0e6821a1c34f9
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
A backend/manager/dbscripts/upgrade/03_02_0100_add_cpu_thread_columns.sql
M backend/manager/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql
M backend/manager/dbscripts/vds_groups_sp.sql
M backend/manager/dbscripts/vds_sp.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
15 files changed, 94 insertions(+), 17 deletions(-)
Approvals:
Greg Padgett: Verified
Doron Fediuck: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10166
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fed81d00ec9086573877145dff0e6821a1c34f9
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
12 years
Change in ovirt-engine[master]: core: VdsSelector changes for CPU Thread Handling (2/4)
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: VdsSelector changes for CPU Thread Handling (2/4)
......................................................................
core: VdsSelector changes for CPU Thread Handling (2/4)
This patch series adds support for CPU Thread Handling in which host
CPU threads can be considered as cores on a per-cluster basis for the
purpose of VM startup/shutdown/migration.
Patch 2: update host selection algorithm to take advantage of cpu
threads.
VdsSelector now uses an "effective" core count. This is a direct
plug-in replacement for using the physical CPU count, and is only in
effect when the host CPU has SMT enabled, and the cluster is set to
count CPU threads as cores.
Change-Id: I7171f066d646378664e5832ba00fa9f436509b97
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EvenlyDistributeComparer.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCpuVdsLoadBalancingAlgorithm.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCountVdsLoadBalancingAlgorithm.java
5 files changed, 28 insertions(+), 11 deletions(-)
Approvals:
Greg Padgett: Verified
Doron Fediuck: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10168
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7171f066d646378664e5832ba00fa9f436509b97
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
12 years
Change in ovirt-engine[master]: webadmin: Changes for CPU Thread Handling (3/4)
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: webadmin: Changes for CPU Thread Handling (3/4)
......................................................................
webadmin: Changes for CPU Thread Handling (3/4)
This patch series adds support for CPU Thread Handling in which host
CPU threads can be considered as cores on a per-cluster basis for the
purpose of VM startup/shutdown/migration.
Patch 3: UI changes:
Hosts > General tab - add CPU Sockets, CPU Threads per Core, and change
CPU core display to CPU Cores per Socket
Clusters > Add/Edit dialog - new setting in Optimization tab (renamed
from "Memory Optimization", hidden if CV < 3.2
Cluster > Configure Local Storage dialog - same as above
Change-Id: Iefa963606074133b3dfcfc1b54fd623519e4ec9e
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java
15 files changed, 545 insertions(+), 225 deletions(-)
Approvals:
Greg Padgett: Verified
Doron Fediuck: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefa963606074133b3dfcfc1b54fd623519e4ec9e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
12 years
Change in samples-uiplugins[master]: Initial commit of Foreman UI plugin
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: Initial commit of Foreman UI plugin
......................................................................
Initial commit of Foreman UI plugin
Change-Id: I8b94af6cbaa7687661762f60c5bda03b73b7a2dc
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
A foreman-plugin/README
A foreman-plugin/foreman-files/start.html
A foreman-plugin/foreman.json
3 files changed, 155 insertions(+), 0 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b94af6cbaa7687661762f60c5bda03b73b7a2dc
Gerrit-PatchSet: 1
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years
Change in ovirt-engine[master]: webadmin: Adding CurrentUser a getFullUserName helper functi...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Adding CurrentUser a getFullUserName helper function
......................................................................
webadmin: Adding CurrentUser a getFullUserName helper function
Change-Id: Id3fac84e9c8142b683885b67b06b1d81b6418739
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/CurrentUser.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginEventHandler.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java
3 files changed, 32 insertions(+), 18 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3fac84e9c8142b683885b67b06b1d81b6418739
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years
Change in ovirt-engine[master]: core: clean javadoc in VmHandler
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: clean javadoc in VmHandler
......................................................................
core: clean javadoc in VmHandler
Remove unused parameters in javadoc and rename ones incorrectly named
in VMHandler class
Change-Id: I321fa2a4e1dc10c0ef95e05bfadbe19242ec77e2
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
1 file changed, 6 insertions(+), 9 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10283
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I321fa2a4e1dc10c0ef95e05bfadbe19242ec77e2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
12 years