Change in ovirt-engine[master]: core: moving AuditLog message length check to DB
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: moving AuditLog message length check to DB
......................................................................
core: moving AuditLog message length check to DB
The check in the setMessage breaks API tests since the created mock has
no access to configuration.
Since this check is relevant only for External Events, it was moved to
the stored procedure.
Change-Id: Ib2805ee22301d75a7d6a2c852a3acfe3fc0f5f59
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/dbscripts/audit_log_sp.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java
2 files changed, 9 insertions(+), 10 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10522
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2805ee22301d75a7d6a2c852a3acfe3fc0f5f59
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years
Change in ovirt-engine[master]: core: Adding error log for Mac address pool init error
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Adding error log for Mac address pool init error
......................................................................
core: Adding error log for Mac address pool init error
This patch adds an error log in case of initialization error
of Mac addresses pool manager
Bug-Url: https://bugzilla.redhat.com/890214
Change-Id: I9d1fbd4dcf4d543706cdd33ccc49505281541f73
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10518
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d1fbd4dcf4d543706cdd33ccc49505281541f73
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years
Change in ovirt-engine[master]: core: Adding LIO iSCSI target as ...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Adding LIO iSCSI target as ...
......................................................................
core: Adding LIO iSCSI target as ...
Adding LIO iSCSI target as storage fails because of LUN ID size being too large for DB scheme
Current Lun Id size was 50 characters which does not support
LIO iSCSI targets.
Extending LunId in luns and lun_storage_server_connection_map tables to
255
Change-Id: I6bdbd6ee67639e25253bb0c678f3d6374880cb1b
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
Bug-Url:https://bugzilla.redhat.com/879272
---
A backend/manager/dbscripts/upgrade/03_02_0230_extend_lun_size.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUN_storage_server_connection_map.java
3 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6bdbd6ee67639e25253bb0c678f3d6374880cb1b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years
Change in ovirt-host-deploy[master]: common: add vim modeline
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: common: add vim modeline
......................................................................
common: add vim modeline
Change-Id: I0c2a5a8ad0394aa0ef14b2abb2c0992a2db78f6f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/ovirt_host_deploy/__init__.py
M src/ovirt_host_deploy/config.py.in
M src/ovirt_host_deploy/constants.py
M src/plugins/ovirt-host-deploy/core/__init__.py
M src/plugins/ovirt-host-deploy/core/misc.py
M src/plugins/ovirt-host-deploy/core/offlinepackager.py
M src/plugins/ovirt-host-deploy/gluster/__init__.py
M src/plugins/ovirt-host-deploy/gluster/packages.py
M src/plugins/ovirt-host-deploy/node/__init__.py
M src/plugins/ovirt-host-deploy/node/detect.py
M src/plugins/ovirt-host-deploy/node/persist.py
M src/plugins/ovirt-host-deploy/node/vdsm_reg.py
M src/plugins/ovirt-host-deploy/tune/__init__.py
M src/plugins/ovirt-host-deploy/tune/iosched.py
M src/plugins/ovirt-host-deploy/tune/tuned.py
M src/plugins/ovirt-host-deploy/vdsm/__init__.py
M src/plugins/ovirt-host-deploy/vdsm/bridge.py
M src/plugins/ovirt-host-deploy/vdsm/config.py
M src/plugins/ovirt-host-deploy/vdsm/hardware.py
M src/plugins/ovirt-host-deploy/vdsm/packages.py
M src/plugins/ovirt-host-deploy/vdsm/pki.py
M src/plugins/ovirt-host-deploy/vdsm/software.py
M src/plugins/ovirt-host-deploy/vdsm/vdsmid.py
M src/plugins/ovirt-host-deploy/vdsmhooks/__init__.py
M src/plugins/ovirt-host-deploy/vdsmhooks/hooks.py
25 files changed, 75 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10519
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c2a5a8ad0394aa0ef14b2abb2c0992a2db78f6f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
12 years
Change in otopi[master]: codegen: generate java with tab indent
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: codegen: generate java with tab indent
......................................................................
codegen: generate java with tab indent
Change-Id: Ib5a7f0a00cf255e1c66ef5cc7c865617aedde85b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/codegen/__main__.py
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5a7f0a00cf255e1c66ef5cc7c865617aedde85b
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
12 years
Change in otopi[master]: common: make java be tar indent
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: common: make java be tar indent
......................................................................
common: make java be tar indent
Change-Id: I443f649c2d81fad740228233fd9f263f79c8ea1d
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/java/Event.java
M src/java/MachineDialogParser.java
M src/java/MachineDialogParserTest.java
M src/java/SoftError.java
4 files changed, 1,018 insertions(+), 1,018 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I443f649c2d81fad740228233fd9f263f79c8ea1d
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
12 years
Change in otopi[master]: common: add vim modeline
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: common: add vim modeline
......................................................................
common: add vim modeline
Change-Id: Ie012a90c7887a3fc0a320b19e2dface01c939fef
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/__init__.py
M src/otopi/__main__.py
M src/otopi/base.py
M src/otopi/codegen/__init__.py
M src/otopi/codegen/__main__.py
M src/otopi/command.py
M src/otopi/common.py
M src/otopi/config.py.in.in
M src/otopi/constants.py
M src/otopi/context.py
M src/otopi/dialog.py
M src/otopi/filetransaction.py
M src/otopi/main.py
M src/otopi/packager.py
M src/otopi/plugin.py
M src/otopi/services.py
M src/otopi/transaction.py
M src/otopi/util.py
M src/plugins/otopi/core/__init__.py
M src/plugins/otopi/core/config.py
M src/plugins/otopi/core/log.py
M src/plugins/otopi/core/misc.py
M src/plugins/otopi/core/transaction.py
M src/plugins/otopi/dialog/__init__.py
M src/plugins/otopi/dialog/cli.py
M src/plugins/otopi/dialog/constants.py
M src/plugins/otopi/dialog/human.py
M src/plugins/otopi/dialog/machine.py
M src/plugins/otopi/dialog/misc.py
M src/plugins/otopi/network/__init__.py
M src/plugins/otopi/network/hostname.py
M src/plugins/otopi/network/iptables.py
M src/plugins/otopi/network/ssh.py
M src/plugins/otopi/packagers/__init__.py
M src/plugins/otopi/packagers/miniyum.py
M src/plugins/otopi/packagers/miniyumlocal.py
M src/plugins/otopi/packagers/yumpackager.py
M src/plugins/otopi/services/__init__.py
M src/plugins/otopi/services/openrc.py
M src/plugins/otopi/services/rhel.py
M src/plugins/otopi/services/systemd.py
M src/plugins/otopi/system/__init__.py
M src/plugins/otopi/system/clock.py
M src/plugins/otopi/system/command.py
M src/plugins/otopi/system/info.py
M src/plugins/otopi/system/reboot.py
46 files changed, 138 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie012a90c7887a3fc0a320b19e2dface01c939fef
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
12 years
Change in ovirt-engine[master]: engine: Replace static referral to DbFacade
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Replace static referral to DbFacade
......................................................................
engine: Replace static referral to DbFacade
A static call to DbFacade from within command classes is replaced
by either a call to the direct Dao or by a call to getDbFacade().
As a result some code formatting was executed.
Change-Id: I01ad22a4e2450fee1e2b1cf26aff5af8d62c35ff
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/GetNetworkDisplayByClusterIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/CommitNetworkChangesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllSiblingVlanInterfacesQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVlanParentQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/RemoveVmTemplateInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java
13 files changed, 46 insertions(+), 73 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10510
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01ad22a4e2450fee1e2b1cf26aff5af8d62c35ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years
Change in otopi[master]: core: fix plugin function names
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: fix plugin function names
......................................................................
core: fix plugin function names
Change-Id: Id22bda5e422d83ace7b3df1f91790fa045fa029b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/otopi/core/config.py
M src/plugins/otopi/core/misc.py
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id22bda5e422d83ace7b3df1f91790fa045fa029b
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
12 years
Change in ovirt-engine[master]: core: Delete OnPropertyChanged from entities
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Delete OnPropertyChanged from entities
......................................................................
core: Delete OnPropertyChanged from entities
This method was used in the C# code, it's unused and unhelpful, so
deleting it from the entities & params where there's still trace of it.
Change-Id: Icca53f05ddc99d8603641f36cf14246c71040dce
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Bookmark.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUserBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber.java
6 files changed, 0 insertions(+), 55 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10460
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icca53f05ddc99d8603641f36cf14246c71040dce
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years