Change in ovirt-engine[master]: engine: Delete getChangeablePropertiesList()
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Delete getChangeablePropertiesList()
......................................................................
engine: Delete getChangeablePropertiesList()
Since Change-Id: I3734abc8a99ebcfdd8e8c8ea8c6b3a674a139f10 there is no
one calling this method anymore so deleting it and all related
implementations.
Change-Id: I6057dfb759de9eabfdef433c2e0adbd1d6a1d7f5
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Bookmark.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdcQueryable.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LdapGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LdapUser.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Network.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNetworkInterface.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/permissions.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonIVdcQueryableMixIn.java
27 files changed, 1 insertion(+), 257 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10459
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6057dfb759de9eabfdef433c2e0adbd1d6a1d7f5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: engine: Remove duplicate semicolons
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Remove duplicate semicolons
......................................................................
engine: Remove duplicate semicolons
In several cases double semicolons were typed while
a single ';' is enough.
Change-Id: Ia94b2e1cbcea3445a3a11ab711d99a9e28da86a1
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddImageFromScratchParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java
M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/QueryHelperTest.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/LinkBuilder.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCdRomResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/SubnetMaskValidation.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java
12 files changed, 13 insertions(+), 13 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia94b2e1cbcea3445a3a11ab711d99a9e28da86a1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: engine: Improve network queries by reducing joins
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Improve network queries by reducing joins
......................................................................
engine: Improve network queries by reducing joins
By extending the vm_interface_view with additional two
columns (entity_type and vds_group_id) we reduce the need
for a join with vms/vm_static tables in procedures that need
to identify vm or template interfacess.
Modifying the queries revealed inaccurate tests related to
vm network interfaces, in which same network interface
entity was abused to represent both VM nic and Template nic.
Change-Id: I7e869dc9e583f1257652eb04d62bb10ae414eb48
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
M backend/manager/dbscripts/network_sp.sql
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
6 files changed, 65 insertions(+), 26 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e869dc9e583f1257652eb04d62bb10ae414eb48
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: tools: allow not to use hardcoded realm information
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: allow not to use hardcoded realm information
......................................................................
tools: allow not to use hardcoded realm information
The following patch introduces a new configuration (boolean value) to
engine-manage-domains.conf of named "useDnsLookup" - if set to true,
realm information will not be set to krb5.conf - instead, the values of
dns_lookup_kdc and dns_lookup_realm will be set to true.
Change-Id: Icaadd9eb23016b4866e5cfa99f919378f19fdf0b
Bug-Url: https://bugzilla.redhat.com/868852
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsConfiguration.java
M backend/manager/modules/utils/src/main/resources/engine-manage-domains.conf
M backend/manager/modules/utils/src/main/resources/krb5.conf.template
5 files changed, 27 insertions(+), 6 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10494
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaadd9eb23016b4866e5cfa99f919378f19fdf0b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: Fixing DAO tests
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing DAO tests
......................................................................
core: Fixing DAO tests
Change-Id: I8ad13904702f95b6a5c76c20ea2a8ad40a00598e
signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ad13904702f95b6a5c76c20ea2a8ad40a00598e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: Fix typo in Storage Domain deactivate command
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix typo in Storage Domain deactivate command
......................................................................
core: Fix typo in Storage Domain deactivate command
Change-Id: I64fd1e51187620d4848a7544b6234ebd5146067c
Bug-Url: https://bugzilla.redhat.com/885632
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64fd1e51187620d4848a7544b6234ebd5146067c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: fix FenceVdsBaseCommandTest test
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: fix FenceVdsBaseCommandTest test
......................................................................
core: fix FenceVdsBaseCommandTest test
Moving variable initialization from the class initialization context to
the place it really used.
Change-Id: Ibdd3efe9aa82d13aa0e0f360c50f1f6ae2c91060
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10496
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdd3efe9aa82d13aa0e0f360c50f1f6ae2c91060
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: rename method in LiveSnapshotTaskHandler
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: rename method in LiveSnapshotTaskHandler
......................................................................
core: rename method in LiveSnapshotTaskHandler
rename private method due to mispelling in LiveSnaphotTaskHandler
Change-Id: Ie0d50d501e0a8bcd94089523c722bc896a2fd28d
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10343
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0d50d501e0a8bcd94089523c722bc896a2fd28d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core, ui: VM, Template name - support Unicode characters
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core,ui: VM,Template name - support Unicode characters
......................................................................
core,ui: VM,Template name - support Unicode characters
Adjusted VM/Template name validations to accept Unicode characters.
* VmStatic/VmTemplate/AddVmTemplateParameters:
use ValidI18NName annotation for name field.
* ValidationUtils/I18NNameValidation: add '.' as valid character
(to preserve current name validation which support '.').
* UnitVmModel: use I18NNameValidation for name validation.
Change-Id: I4105c327bdfce9587ae8ab2dcfc8180cf90cb4af
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/I18NRegexpTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/I18NNameValidation.java
7 files changed, 16 insertions(+), 35 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4105c327bdfce9587ae8ab2dcfc8180cf90cb4af
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: enabling Unicode support in OVF
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: enabling Unicode support in OVF
......................................................................
core: enabling Unicode support in OVF
InputStreamReader should be initialized with Encoding.UTF8
as charsetName for supporting Unicode characters.
Change-Id: I19319769c9382b6c7df5de5c5f35c30f6a3052e3
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlDocument.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19319769c9382b6c7df5de5c5f35c30f6a3052e3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 3 months