December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Fix DB build issues
by yzaslavs＠redhat.com 12 Dec '12

12 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Fix DB build issues ...................................................................... engine: Fix DB build issues The patch modifies the db function update script to use it by its proper signature. In addition the fixture.xml should contain the libvir_version once this new column was introduced. Change-Id: I4f7e26c93eac852c0b71b66c1f24b580ddf48892 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/config_devel.sql M backend/manager/modules/dal/src/test/resources/fixtures.xml 2 files changed, 11 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f7e26c93eac852c0b71b66c1f24b580ddf48892 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend, webadmin: Display libvirt version on host general ta...
by achub＠redhat.com 12 Dec '12

12 Dec '12

Alexey Chub has submitted this change and it was merged. Change subject: backend,webadmin: Display libvirt version on host general tab (#672148) ...................................................................... backend,webadmin: Display libvirt version on host general tab (#672148) Added DB column to store libversion. Change-Id: Ie16dd9dca081d5fecf361f75eceae7c9925a9a83 Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M backend/manager/dbscripts/create_dwh_views.sql M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1550_add_libvirt_version_col.sql M backend/manager/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java 15 files changed, 77 insertions(+), 11 deletions(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie16dd9dca081d5fecf361f75eceae7c9925a9a83 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: generate new JSESSIONID when Authorization header s...
by mpastern＠redhat.com 12 Dec '12

12 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: generate new JSESSIONID when Authorization header specified ...................................................................... restapi: generate new JSESSIONID when Authorization header specified Change-Id: Id586d3cb143e15a95720b2aeb8a9e4ae62f2b72c Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/security/auth/ChallengerTest.java 2 files changed, 16 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id586d3cb143e15a95720b2aeb8a9e4ae62f2b72c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add Windows 8/2012 to VM OS list
by ofrenkel＠redhat.com 12 Dec '12

12 Dec '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Add Windows 8/2012 to VM OS list ...................................................................... core: Add Windows 8/2012 to VM OS list Change-Id: I21be8a69feddc89adcc671e307a96e4dd7897993 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- A backend/manager/conf/sysprep/sysprep.2k12x64 A backend/manager/conf/sysprep/sysprep.w8 A backend/manager/conf/sysprep/sysprep.w8x64 M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmOsType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/OsType.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M packaging/fedora/setup/engine-setup.py 14 files changed, 362 insertions(+), 14 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21be8a69feddc89adcc671e307a96e4dd7897993 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix appearance of a "Test" button on host dialog (...
by achub＠redhat.com 12 Dec '12

12 Dec '12

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: Fix appearance of a "Test" button on host dialog (#877814) ...................................................................... webadmin: Fix appearance of a "Test" button on host dialog (#877814) Change-Id: Ia6b8e6cc2d568bcdf47b4756403c9883674be79e Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6b8e6cc2d568bcdf47b4756403c9883674be79e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: fix tab traversal in vm dialogs
by tjelinek＠redhat.com 12 Dec '12

12 Dec '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: fix tab traversal in vm dialogs ...................................................................... userportal,webadmin: fix tab traversal in vm dialogs Set the tab traversal index of the newly "delete protection" checkbox such that the tab traversal order in vm dialogs will be correct. Change-Id: I1c8cb54342b594df3b916c0f497df224f3b20003 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c8cb54342b594df3b916c0f497df224f3b20003 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove unmanaged devices on down VM event
by rgolan＠redhat.com 12 Dec '12

12 Dec '12

Roy Golan has submitted this change and it was merged. Change subject: core: remove unmanaged devices on down VM event ...................................................................... core: remove unmanaged devices on down VM event unmanaged devices where being removed only by direct stop/shutdown commands. This patch will move this treatment to be fired by the eventListener onProcressStopVm so even when a guest VM is shuting down by its OS function, without th engine, unmanaged devices will be removed Change-Id: I6593b9cb36fecc87f9b9af574d61300d55d6ad62 Bug-Url: https://bugzilla.redhat.com/846696 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java 3 files changed, 54 insertions(+), 47 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6593b9cb36fecc87f9b9af574d61300d55d6ad62 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: common: config: remove unused config entries
by emesika＠redhat.com 12 Dec '12

12 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: common: config: remove unused config entries ...................................................................... common: config: remove unused config entries - AsyncPollingCyclesBeforeCallbackCleanup - AsyncPollingCyclesBeforeRefreshSuspend - AutoPostbackDelay - AutoRemoteInterface - CertificatePassword - DebugSearchLogging - DefaultDataBaseName - ENMailEnableSsl - ENMailHost - ENMailPassword - ENMailPort - ENMailUser - ExportVmDefaultPath - ImageCheckFailureMessageTimout - IncludeDesktop - MaxCorrelationIdLength - MaxResultsPageSize - MaxVmDiskSize - MigrationMinPort - MigrationPortRange - MinVmDiskSize - OvfDirectoryPath - PSAsyncActionTimeOutInMinutes - PowerClientAutoMigrateCheckOnRDP - PowerClientUserPortalVdcManagedSpiceState - RemoteBackend - RemoteInterface - RemoteUri - RemoteUserBackend - SQLI18NPrefix - SearchesRefreshRateInSeconds - SlowStorageResponseMessageTimout - UseVdsBrokerInProc - VdsFenceOptions Change-Id: I84433d5005b9285198fbbcd7f1b932cdf87bc356 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties M packaging/fedora/setup/engine-config-install.properties M packaging/fedora/setup/engine-setup.py 6 files changed, 7 insertions(+), 127 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84433d5005b9285198fbbcd7f1b932cdf87bc356 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: common: config: add used parameters missing from ConfigValue...
by emesika＠redhat.com 12 Dec '12

12 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: common: config: add used parameters missing from ConfigValues ...................................................................... common: config: add used parameters missing from ConfigValues - ENGINEEARLib - MinimalETLVersion Change-Id: If629baa70adeb5481197e048266aed039769fb6c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If629baa70adeb5481197e048266aed039769fb6c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: common: config: remove parameters not in ConfigValues
by emesika＠redhat.com 12 Dec '12

12 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: common: config: remove parameters not in ConfigValues ...................................................................... common: config: remove parameters not in ConfigValues - CAEngineKey - SQLServerI18NPrefix - ScriptsPath - CbcCheckOnVdsChange Change-Id: I8eb02234cf27aa4f560c9a3719fa534223efc4fe Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/fedora/setup/engine-setup.py 2 files changed, 4 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8eb02234cf27aa4f560c9a3719fa534223efc4fe Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0