Change in ovirt-engine[master]: common: config: move development values to config_devel.sql
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: common: config: move development values to config_devel.sql
......................................................................
common: config: move development values to config_devel.sql
There is no room for development values within the defaults of the
product.
Development values must exists within the database because some of the
database creation scripts assumes defaults within database, so even if
these were defaults, they are candidate from removal from database.
- CABaseDirectory
- CertAlias
- CertificateFileName
- ENGINEEARLib
- SysPrep*
- keystorePass
- keystoreUrl
Change-Id: Iefa56503618488510d9751ebe0e313ad15069db3
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/dbscripts/config_devel.sql
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/fedora/setup/engine-setup.py
3 files changed, 27 insertions(+), 22 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9777
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefa56503618488510d9751ebe0e313ad15069db3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: common: config: remove deprecated entries
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: common: config: remove deprecated entries
......................................................................
common: config: remove deprecated entries
- SelectCommandTimeout
- LogXmlRpcData
- BootstrapInstallerFileName
- CBCCertificateScriptName
- CBCCloseCertificateScriptName
- VirtualMachineDomainName
- AutoMode
- DefaultWorkgroup
- CertificateFingerPrint
- LicenseCertificateFingerPrint
- VdcBootStrapUrl
- AutoSuspendTimeInMinutes
- RDPLoginWithFQN
- PowerClientGUI
- PowerClientAllowUsingAsIRS
- RenewGuestIpOnVdsSubnetChangeOnParseError
- RenewGuestIpOnVdsSubnetChange
- ENMailDomain
- ENMailIsBodyHtml
- ENMailUseDefaultCredentials
- RedirectServletReportsPageError
- SQLServerPagingSyntax
- SQLServerPagingType
- SQLServerSearchTemplate
- LogDBCommands
- PublicURLPort
- SQLServerLikeSyntax
- CustomPublicConfig_AppsWebSite
- BootstrapNodeIDCommand
Change-Id: I7e618c78acbee8f77cf310cfdb35e485568ed766
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/dbscripts/config_devel.sql
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M packaging/fedora/setup/engine-config-install.properties
5 files changed, 34 insertions(+), 173 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9776
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e618c78acbee8f77cf310cfdb35e485568ed766
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: restapi: fix unit tests that use java assertions
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: fix unit tests that use java assertions
......................................................................
restapi: fix unit tests that use java assertions
Replaced java assertions with junit assertions
Change-Id: Iffe7d5a845e886d2961c28f1eed5c32bb924e067
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/utils/test/UsbResourceUtilsTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/utils/UsbMapperUtilsTest.java
2 files changed, 20 insertions(+), 13 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9767
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffe7d5a845e886d2961c28f1eed5c32bb924e067
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: engine: Removing UpdateSpmHostNameVDSCommand class
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Removing UpdateSpmHostNameVDSCommand class
......................................................................
engine: Removing UpdateSpmHostNameVDSCommand class
The following command contains a potential bug and also the functionality of update
host_name is removed, so need for special command
Change-Id: I3485ff235be53e4365c8732f88c0c053f4718fb6
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpdateSpmHostNameVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UpdateSpmHostNameVDSCommand.java
5 files changed, 4 insertions(+), 83 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9572
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3485ff235be53e4365c8732f88c0c053f4718fb6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 1 month
Change in ovirt-host-deploy[master]: packaging: add rhel specific packaging behaviour
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: add rhel specific packaging behaviour
......................................................................
packaging: add rhel specific packaging behaviour
Change-Id: I8e550409611fac2e2f16645fdc2370db011dd49b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-host-deploy.spec.in
1 file changed, 22 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9984
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e550409611fac2e2f16645fdc2370db011dd49b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
12 years, 1 month
Change in otopi[master]: packaging: update spec revision
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: update spec revision
......................................................................
packaging: update spec revision
Change-Id: I0ae951691360547e3f63f61d1b7834d885363ddc
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9983
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ae951691360547e3f63f61d1b7834d885363ddc
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
12 years, 1 month
Change in otopi[master]: packaging: add rhel specific packaging behaviour
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: add rhel specific packaging behaviour
......................................................................
packaging: add rhel specific packaging behaviour
Change-Id: I31c7311094f8d1cfdee5c80e468d9cda512b5990
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M otopi.spec.in
1 file changed, 22 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9982
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31c7311094f8d1cfdee5c80e468d9cda512b5990
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: webadmin: JP date format uses mins instead of month
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: JP date format uses mins instead of month
......................................................................
webadmin: JP date format uses mins instead of month
mm is minutes
MM is month
Change-Id: I943796801aff1bf636d21084fed0c07c0e2f2670
Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=870352
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/FullDateTimeRenderer.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I943796801aff1bf636d21084fed0c07c0e2f2670
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: webadmin: no localization for command buttons strings
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: no localization for command buttons strings
......................................................................
webadmin: no localization for command buttons strings
As a result of Idd623481d0eb77bfbaa1e8b3eec8b445020711c8
Command buttons' text strings must reside in the model,
i.e. localization through the view is being ignored.
Fixed AbstractUiCommandButton by updating button's
text and title (tool-tip) according the the model
only as a last resort (i.e. when no localization is available).
(modified GuidePopupView to maintain the behavior
of the original bug fix: https://bugzilla.redhat.com/850439)
Change-Id: I186b5f3a812d34a30209998933c0617e9e182be7
Bug-Url: https://bugzilla.redhat.com/876955
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.java
2 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9638
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I186b5f3a812d34a30209998933c0617e9e182be7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: tools: engine-manage-domains -addPermissions doesn't work on...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: engine-manage-domains -addPermissions doesn't work on F18
......................................................................
tools: engine-manage-domains -addPermissions doesn't work on F18
The -addpermissions doesn't work on fedora 18. the user's
entry isn't updated in the permissions table.
Change-Id: Iced942629e5e898f385f3413059e494e08bad4d9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=885766
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsDAOImpl.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9857
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iced942629e5e898f385f3413059e494e08bad4d9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 1 month
