Change in ovirt-engine[master]: webadmin: fix focus traversal in make template
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: fix focus traversal in make template
......................................................................
webadmin: fix focus traversal in make template
Fixed the focus traversal in the make template popup dialog:
- the focus is switched between the focusable components in the standard
order (top to down, left to right)
- the focus traversal also include the "ok" and "cancel" buttons
This mechanism can be extended in the future to fix the focus traversal
in other dialogs. it is especially easy to extend it to other similar
popup dialogs (that subclass AbstractModelBoundPopupWidget) - all
we need is that its widget will override "setTabIndexes" method and
define a custom focus order to its components.
Change-Id: I82233e8d136154e942d1ffce8e6f831ddfbfb3fb
Bug-Url: https://bugzilla.redhat.com/873133
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundWidgetPopupView.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/FocusableComponentsContainer.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractModelBoundPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java
8 files changed, 84 insertions(+), 5 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82233e8d136154e942d1ffce8e6f831ddfbfb3fb
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 4 months
Change in ovirt-host-deploy[master]: tests: update default test server address
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: tests: update default test server address
......................................................................
tests: update default test server address
Change-Id: I6f845bce43a73641fb5fffc3f65798859af3782f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M tests/test-bundle.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9653
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f845bce43a73641fb5fffc3f65798859af3782f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 4 months
Change in ovirt-host-deploy[master]: packaging: remove redundant gettext-devel
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: remove redundant gettext-devel
......................................................................
packaging: remove redundant gettext-devel
Change-Id: Ie08f906ba1e000158c1617ea9af220e26ca247ef
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-host-deploy.spec.in
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9650
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie08f906ba1e000158c1617ea9af220e26ca247ef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 4 months
Change in otopi[master]: packaging: remove redundant gettext-devel
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: remove redundant gettext-devel
......................................................................
packaging: remove redundant gettext-devel
Change-Id: I42f2d444a218a18e9c5ef7f6c5cacf514a69ca6f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M otopi.spec.in
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9649
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42f2d444a218a18e9c5ef7f6c5cacf514a69ca6f
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: restapi: Extend block domain - override_luns
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: restapi: Extend block domain - override_luns
......................................................................
restapi: Extend block domain - override_luns
Added 'override_luns' flag to update storage domain api:
* An optional flag when extending a block storage domain
i.e. force flag for extending a domain
(same flag as adding a new block storage domain).
* BackendStorageDomainResource - passed the flag
to ExtendSANStorageDomainParameters.
* rsdl_metadata: added an optional 'override_luns'
argument in update storage.
Change-Id: I492876d33913e8ddc88c30e5189e52bf58361fd1
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java
2 files changed, 12 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9344
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I492876d33913e8ddc88c30e5189e52bf58361fd1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: core:encrypt vds_static pm_password field on ...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core:encrypt vds_static pm_password field on ...
......................................................................
core:encrypt vds_static pm_password field on ...
core:encrypt vds_static pm_password field on upgrade to 3.1
This patch sets the correct configuration values in vdc_options for the
03_00_0420...sql upgrade script.
Since those values are set only in the installer post upgrade step, we
must update them in the DB pre-upgrade step in order to encrypt passwords
successfully.
This patch also removes one of those entries from engine-config tool
because the entry should be read-only.
Change-Id: I5d2cb10f205a90ae0752498a9a3d3f0eda0ec9fb
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/tools/engine-config/src/main/resources/engine-config.properties
2 files changed, 10 insertions(+), 9 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d2cb10f205a90ae0752498a9a3d3f0eda0ec9fb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 4 months
Change in otopi[master]: network: iptables: chain transaction to modified files
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: network: iptables: chain transaction to modified files
......................................................................
network: iptables: chain transaction to modified files
Change-Id: I0017f812a3576a626e2ed8afe12ea52ab6b1c30c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/otopi/network/iptables.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9644
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0017f812a3576a626e2ed8afe12ea52ab6b1c30c
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 4 months
Change in ovirt-host-deploy[master]: doc: environment: add missing types/default
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: doc: environment: add missing types/default
......................................................................
doc: environment: add missing types/default
Change-Id: Ie5b5bc31435fe0456e89ba1026392fc79d94e41b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M README.environment
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9642
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5b5bc31435fe0456e89ba1026392fc79d94e41b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: webadmin: fixed initial focus in edit pool dialog
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: fixed initial focus in edit pool dialog
......................................................................
webadmin: fixed initial focus in edit pool dialog
The name textbox is the default component to get the initial focus in vm
dialogs, but in the edit pool dialog the name textbox is disabled,
thus no component gets focus when the dialog is opened.
To fix this, I changed the component that gets the initial focus in the
edit pool dialog to the description textbox.
Change-Id: I55445daaf90d0c394f6da28cc3d39495b1e3c115
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolEditPopupWidget.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9571
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I55445daaf90d0c394f6da28cc3d39495b1e3c115
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
11 years, 4 months
Change in ovirt-engine-sdk[master]: sdk: rename the project
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: rename the project
......................................................................
sdk: rename the project
Change-Id: Iab399ce1f885941d9927d29411e0852174e7bc27
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M .project
M .pydevproject
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab399ce1f885941d9927d29411e0852174e7bc27
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 4 months
