Change in ovirt-engine[master]: webadmin: Filter Advanced Event columns according to Applica...
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Filter Advanced Event columns according to ApplicationMode
......................................................................
webadmin: Filter Advanced Event columns according to ApplicationMode
This patch updates column availability within 'Advanced view'
of Event main tab.
Columns available only for VirtOnly-compatible ApplicationMode:
- Virtual Machine
- Template
- Data Center
- Storage
Columns available only for GlusterOnly-compatible ApplicationMode:
- Volume
This patch also adds NumberFormatException check when reading
the ApplicationMode value.
Change-Id: I6471ba32962a9f72fc9eb2a341ee6991c4283697
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uimode/UiModeData.java
3 files changed, 35 insertions(+), 13 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4913
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6471ba32962a9f72fc9eb2a341ee6991c4283697
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: webadmin: Gluster Bricks Popup - style change
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Gluster Bricks Popup - style change
......................................................................
webadmin: Gluster Bricks Popup - style change
Backgroud color of the Volume Type field
is changed to grey in Add Bricks Popup.
Change-Id: Idc2c9ee61c80a6675eda47e1dd6e67e387d73671
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.ui.xml
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4924
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc2c9ee61c80a6675eda47e1dd6e67e387d73671
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: webadmin: Host, Volume dialog - auto selections according to ...
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Host,Volume dialog - auto selections according to tree context
......................................................................
webadmin: Host,Volume dialog - auto selections according to tree context
In Create Volume dialog, wrong cluster was selected instead
of the selected cluster in tree. This issue is now fixed.
Change-Id: I2f6c878725114cbc50f00a1d47a505de1f997f38
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
2 files changed, 18 insertions(+), 10 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f6c878725114cbc50f00a1d47a505de1f997f38
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: webadmin: oVirt Modes - hide DC in GlusterOnly
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: oVirt Modes - hide DC in GlusterOnly
......................................................................
webadmin: oVirt Modes - hide DC in GlusterOnly
Data Center list box in cluster, host, volume dialogs will
be hidden if the application is running in GlusterOnly mode.
1. In case of new cluster/host/volume, default data center
will be selected through code at the time of hiding.
2. In case of edit or throught Guide Me,
there will not be any auto selection made.
Change-Id: I61eb8e9d59d809df07834c3c1ad33f2bf684382a
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
5 files changed, 22 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61eb8e9d59d809df07834c3c1ad33f2bf684382a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: restapi: Support Correlation Id
by oliel＠redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Support Correlation Id
......................................................................
restapi: Support Correlation Id
User may pass the header: 'Correlation-Id' and the value will be propagated
to all log entries that result from this flow
Change-Id: Ia353b98595c484d39414277785611a9430f83368
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4842
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia353b98595c484d39414277785611a9430f83368
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core : NestedSQLException during RemoveImageCommand (#767113...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core : NestedSQLException during RemoveImageCommand (#767113)
......................................................................
core : NestedSQLException during RemoveImageCommand (#767113)
https://bugzilla.redhat.com/767113
The following bug was caused because of global transaction which was opened before
call to RemoveImageCommand.
Since we don't need a transaction to be opened at RemoveImageCommand, I marked all commands
which are performing a call to RemoveImageCommand and performing only read operation by attribute
@NonTransactive, which should disable a global transaction
Change-Id: Ie8d9b8b4320f00fa49f917bf45001587b700acc6
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java
4 files changed, 10 insertions(+), 6 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4901
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8d9b8b4320f00fa49f917bf45001587b700acc6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: packaging: Build and run with Fedora 17 jboss-as
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Build and run with Fedora 17 jboss-as
......................................................................
packaging: Build and run with Fedora 17 jboss-as
This patch includes changes to build and run the engine with the
jboss-as package included in Fedora 17.
A private instance of jboss-as is created so that there is no
interference with other applications running on top of the
application server. This private instance will be executed by the
user and group "ovirt" and uses the following files and
directories:
/usr/share/ovirt-engine
A new "modules" subdirectory has been added that holds the JBoss
modules that are missing in the current jboss-as package in
Fedora 17. Also some modules that require fixes.
The application server will be started using a module path that
contains first this "modules" directory and then the "modules"
directory of JBoss itself.
All the content here should be owned by root to prevent writes
by the engine.
/etc/ovirt-engine
This directory stores most of the configuration files. In the
future it should store *all* the configurationfiles.
It is owned by the ovirt user becase the application server
will store here backup copies of the main configuration file.
/etc/ovirt-engine/engine-service.xml
This is the main configuration file of the application server,
copied from standalone-web.xml and modified to fit the needs of
the engine.
My expectation is that maintaining this configuration file will
be easier than maintaing the parts of the engine-setup script
that modify the configuration. However, at the moment both
things are needed.
It is owned by the ovirt user because the application server
reads and then writes it during each run.
/etc/ovirt-engine/engine-service-logging.properties
This contains the log4j configuration used by the application
server using during boot, mostly copied from "logging.properties".
/etc/ovirt-engine/engine-service-users.properties
This file should contain the user names and passwords of the
application server management users. It is empty at the moment.
/var/log/ovirt-engine
This directory holds the log files of the engine: boot.log for
the boot messages, server.log for the application server messages,
engine.log for the engine messages and console.log for the
standard output and errors of the java virtual machine.
The directory is owned by the ovirt user so that the application
server can create/rotate log files.
/var/lib/ovirt-engine
This is the directory where the application server will store
variable data.
The "deployments" subdirectory is created during installation
and it will contain a symlink to the "engine.ear" directory and
the "engine.ear.dodeploy" marker file.
The "content", "timer-service-data" and "tx-object-store"
subdirectories are created by the application server as needed and
should't be removed.
This directory is owned by the "ovirt" user, as the application
server needs to create subdirectories.
/var/cache/ovirt-engine
This is where the application server stores temporary content
like "auth", "vfs" and "work". It is safe to remove this when
the application server is stopped.
This directory is also owned by the "ovirt" user.
The private instance of the application server works as a systemd
service started and stopped with the "engine-service.py" script.
This script gets some configuration variables (heap space, debug
flags, directory names, etc) from the "engine-service" sysconfig
file.
The makefile, spec and engine-setup script have been adjusted to
build and install with the private instance of jboss-as.
Change-Id: I5cda15e5219d1b6c8e8306fc7b4f196e6afc66b1
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M backend/manager/conf/ca/encryptpasswd.sh
M backend/manager/conf/ca/generate-ssh-keys
M backend/manager/conf/ca/store-utils.sh
M backend/manager/conf/kerberos/engine-manage-domains
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/CXFContextInterceptor.java
M backend/manager/modules/utils/src/main/resources/engine-manage-domains.conf
M backend/manager/tools/engine-config/src/main/resources/engine-config
M backend/manager/tools/engine-config/src/main/resources/engine-config.conf
M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/notifier.conf
A deployment/modules/com/sun/xml/bind/main/module.xml
A deployment/modules/javax/ws/rs/api/main/module.xml
A deployment/modules/org/apache/commons/codec/main/module.xml
A deployment/modules/org/apache/httpcomponents/main/module.xml
A deployment/modules/org/codehaus/jackson/jackson-core-asl/main/module.xml
A deployment/modules/org/codehaus/jackson/jackson-jaxrs/main/module.xml
A deployment/modules/org/codehaus/jackson/jackson-mapper-asl/main/module.xml
A deployment/modules/org/codehaus/jackson/jackson-xc/main/module.xml
A deployment/modules/org/hibernate/validator/main/module.xml
A deployment/modules/org/jboss/resteasy/resteasy-atom-provider/main/module.xml
A deployment/modules/org/jboss/resteasy/resteasy-cdi/main/module.xml
A deployment/modules/org/jboss/resteasy/resteasy-jackson-provider/main/module.xml
A deployment/modules/org/jboss/resteasy/resteasy-jaxb-provider/main/module.xml
A deployment/modules/org/jboss/resteasy/resteasy-jaxrs/main/module.xml
A deployment/modules/org/jboss/resteasy/resteasy-jettison-provider/main/module.xml
A deployment/modules/org/jboss/resteasy/resteasy-jsapi/main/module.xml
A deployment/modules/org/jboss/resteasy/resteasy-multipart-provider/main/module.xml
A deployment/modules/org/jboss/resteasy/resteasy-yaml-provider/main/module.xml
A deployment/modules/org/scannotation/scannotation/main/module.xml
D deployment/modules/sun/jdk/main/module.xml
M ear/pom.xml
A ear/src/main/resources/META-INF/MANIFEST.MF
M frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/GenericApiService.java
A packaging/fedora/engine-service-logging.properties
A packaging/fedora/engine-service-users.properties
A packaging/fedora/engine-service.py
A packaging/fedora/engine-service.sysconfig
A packaging/fedora/engine-service.systemd
A packaging/fedora/engine-service.systemv
A packaging/fedora/engine-service.xml
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/engine-upgrade.py
M packaging/fedora/setup/output_messages.py
M packaging/fedora/spec/ovirt-engine.spec.in
M pom.xml
47 files changed, 2,320 insertions(+), 501 deletions(-)
Approvals:
Juan Hernandez: Verified
Ofer Schreiber: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cda15e5219d1b6c8e8306fc7b4f196e6afc66b1
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core : Fixing a list of arguments which should be send to vd...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core : Fixing a list of arguments which should be send to vdsm at hotPlug feature
......................................................................
core : Fixing a list of arguments which should be send to vdsm at hotPlug feature
The following patch should fix a list of arguments which are send to vdsm
at hot plug feature.
The list of arguments should be almost similar to the list at VmInfoBuilder class
Change-Id: I43aab5452f230e3310bb152a3a27402946d0964f
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
3 files changed, 20 insertions(+), 14 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43aab5452f230e3310bb152a3a27402946d0964f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: resolve NPE in VM/Template Export
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: resolve NPE in VM/Template Export
......................................................................
core: resolve NPE in VM/Template Export
When an old template (created before USB support was added to vm
devices) is imported to the system. the UsbPolicy of it is null, this
results in NPE. The sane occurs for VM import.
Change-Id: I6794924558892a4f6999dc0f2257355bae9ca1a7
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4920
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6794924558892a4f6999dc0f2257355bae9ca1a7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: engine: clean up network monitoring code
by lpeer＠redhat.com
Livnat Peer has submitted this change and it was merged.
Change subject: engine: clean up network monitoring code
......................................................................
engine: clean up network monitoring code
This patch is for cleanning up legacy conversion (c# to java) code .
Change-Id: Idfbbbfb9c7c6020ea520a735eea1e847c5ae77c2
Signed-off-by: Livnat Peer <lpeer(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 50 insertions(+), 107 deletions(-)
Approvals:
Livnat Peer: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4871
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idfbbbfb9c7c6020ea520a735eea1e847c5ae77c2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
11 years, 10 months