Change in ovirt-engine[master]: core: Added not null validations to vNIC (#756437)
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Added not null validations to vNIC (#756437)
......................................................................
core: Added not null validations to vNIC (#756437)
https://bugzilla.redhat.com/756437
Added not null validations to NetworkInterface fields name & macAddress
since these fields are mandatory.
Change-Id: Ie1b449cf469af716b82456673319f5391e062a9e
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterfaceValidationTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 77 insertions(+), 4 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4376
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1b449cf469af716b82456673319f5391e062a9e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Add validation to MAC format (#756437)
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add validation to MAC format (#756437)
......................................................................
core: Add validation to MAC format (#756437)
https://bugzilla.redhat.com/756437
The MAC address needs to be in a specific format, so adding a
validation so that when network is created/updated then the MAC
address format is correct.
The validation of MAC size is no longer required, since this new
validation will cover also shorter/longer MAC cases.
A dependency on slf4j-nop was added to the pom.xml file for scope test
to allow testing the validations, since the default validation provider
uses slf4j so we must provide some implementation.
Change-Id: I8d25cc5c48fb2ab48c9137cd167a43459cf03931
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/common/pom.xml
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NetworkInterface.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterfaceValidationTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/utils/pom.xml
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 111 insertions(+), 4 deletions(-)
Approvals:
Mike Kolesnik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4375
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d25cc5c48fb2ab48c9137cd167a43459cf03931
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Change validation groups to inherit default
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Change validation groups to inherit default
......................................................................
core: Change validation groups to inherit default
Validation groups should inherit the default group, since we would
usually want to check the default validations and in addition those
for these validation groups (Create & Update entity).
If no group is specified, the default group is used by the validator.
Change-Id: I0774a4e9e4ea23d99702783291c181118fd2a309
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/group/CreateEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/group/UpdateEntity.java
3 files changed, 7 insertions(+), 5 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0774a4e9e4ea23d99702783291c181118fd2a309
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: engine: Implemented getBricksByBrickId in GlusterVolumeRemov...
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: Implemented getBricksByBrickId in GlusterVolumeRemoveBricksCommand
......................................................................
engine: Implemented getBricksByBrickId in GlusterVolumeRemoveBricksCommand
- Added the validation to update bricks with all the information
- Introduced the RemoveBrick class for validation
Change-Id: I635458c59dc60d34fb6354a12f0049caf97c34bb
Signed-off-by: Dhandapani <dgopal(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeBricksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeRemoveBricksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/group/gluster/RemoveBrick.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
9 files changed, 94 insertions(+), 6 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I635458c59dc60d34fb6354a12f0049caf97c34bb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: change gluster-cluster image
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: change gluster-cluster image
......................................................................
webadmin: change gluster-cluster image
Change-Id: If13832c49142984ba4979b99789bff63ce1de77f
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/cluster_gluster.png
1 file changed, 0 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4911
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If13832c49142984ba4979b99789bff63ce1de77f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <shireesh(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: engine: fix for Rebalance Start event notification.
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: fix for Rebalance Start event notification.
......................................................................
engine: fix for Rebalance Start event notification.
https://bugzilla.redhat.com/823505
Change-Id: Idc86202ffb7967724757baa6026ecaa9d8c4390f
Signed-off-by: Selvasundaram <sesubram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
4 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Selvasundaram: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4752
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc86202ffb7967724757baa6026ecaa9d8c4390f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: engine: Add Gluster host
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add Gluster host
......................................................................
engine: Add Gluster host
Do peer probe gluster server if cluster supports gluster
and If no vds installation is required.
Change-Id: If9a7f36a1b54d0c62297afcdd422938d59ad0997
Signed-off-by: Selvasundaram <sesubram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHostAddVDSParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHostAddVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
15 files changed, 129 insertions(+), 14 deletions(-)
Approvals:
Selvasundaram: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4736
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9a7f36a1b54d0c62297afcdd422938d59ad0997
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <shireesh(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: adding application caption
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: adding application caption
......................................................................
webadmin: adding application caption
application caption: 'Open Virtualization Manager' in login screen
and empty editable caption in main app header
Change-Id: I1cbb549c7b77724555127e3ee4e32bfc43c908f5
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml
5 files changed, 39 insertions(+), 4 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4887
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1cbb549c7b77724555127e3ee4e32bfc43c908f5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: styling buttons in properties sheet
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: styling buttons in properties sheet
......................................................................
webadmin: styling buttons in properties sheet
Adding '+' and '-' images to buttons
Change-Id: I9443b4674192dcff9de0f1d58a16696d650924e2
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.ui.xml
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/icon_decrease.png
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/icon_increase.png
5 files changed, 21 insertions(+), 16 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4886
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9443b4674192dcff9de0f1d58a16696d650924e2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: filtering tree by application mode
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: filtering tree by application mode
......................................................................
webadmin: filtering tree by application mode
using recursion.
Change-Id: I2d807c5ece41c0c2bbe2c7384d6f38045e0a1573
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ApplicationModeHelper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeItemModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendMultipleQueryAsyncResult.java
6 files changed, 109 insertions(+), 57 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d807c5ece41c0c2bbe2c7384d6f38045e0a1573
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
12 years, 7 months