May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: New query to fetch brick by id
by mpastern＠redhat.com 29 May '12

29 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: engine: New query to fetch brick by id ...................................................................... engine: New query to fetch brick by id In the process, renamed GetGlusterVolumeByIdQueryParameters to generic IdQueryParameters and refactored the Query classes that were using it. Change-Id: I7ea7af090f60c22dca7cd944e2f782f940309fb3 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterBrickByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeBricksQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeByIdQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterBrickByIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeBricksQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeByIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GetGlusterVolumeByIdQueryParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/IdQueryParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResourceTest.java 13 files changed, 117 insertions(+), 47 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Selvasundaram: Verified -- To view, visit http://gerrit.ovirt.org/4783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ea7af090f60c22dca7cd944e2f782f940309fb3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Gluster Brick resource implementation
by mpastern＠redhat.com 29 May '12

29 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Gluster Brick resource implementation ...................................................................... restapi: Gluster Brick resource implementation Implementation of BackendGlusterBrickResource - get - replace and related changes / fixes in other files, including the JUnit test case. Change-Id: If46e67bf574d48d615c33096b36f8c02a267bd3f Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterBrickMapper.java 7 files changed, 255 insertions(+), 21 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Selvasundaram: Verified -- To view, visit http://gerrit.ovirt.org/4786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If46e67bf574d48d615c33096b36f8c02a267bd3f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Cluster schema changes
by mpastern＠redhat.com 29 May '12

29 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Cluster schema changes ...................................................................... restapi: Cluster schema changes Introduced the flags "virt_service" and "gluster_service" in the "Cluster" schema These are NOT mandatory; BLL uses default values of virt_service = true and gluster_service = false. Also modified - ClusterMapper to map these new flags. - ClusterMapper test case. - rsdl metadata to introduce the new flags for add/update cluster. Change-Id: I89096bfedd7aa5cfa9b8ad0ad86557e1ddf4eee1 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ClusterMapperTest.java 4 files changed, 14 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Selvasundaram: Verified -- To view, visit http://gerrit.ovirt.org/4824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89096bfedd7aa5cfa9b8ad0ad86557e1ddf4eee1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: rest: fix non working display tag in attach network to clust...
by rgolan＠redhat.com 29 May '12

29 May '12

Roy Golan has submitted this change and it was merged. Change subject: rest: fix non working display tag in attach network to cluster ...................................................................... rest: fix non working display tag in attach network to cluster the network mapper treated the display tag only incase the usages tag exexisted. now the display tag overide the <usage>DISPLAY</usage> for backward compatability Change-Id: Ic04ecbf67d4d640705124b2c52c121a4fc3f79b1 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic04ecbf67d4d640705124b2c52c121a4fc3f79b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix bridgless network recognition
by mkolesni＠redhat.com 29 May '12

29 May '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Fix bridgless network recognition ...................................................................... core: Fix bridgless network recognition Bridgeless network was not recognized as part of GetVdsCapabilities call since it has no ports, but instead returns the name of the interface it is based on. Fixed the return value of the call to update the interface if it is provided in the details (this should also work for bridged networks, since the interface name can be reported on them too). Change-Id: Iaf8b2b2d9e9d5f16e6b14ecd0f6d01ced4e54ca7 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 76 insertions(+), 34 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf8b2b2d9e9d5f16e6b14ecd0f6d01ced4e54ca7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: virt-engine: Support RHEVManager url
by rgolan＠redhat.com 29 May '12

29 May '12

Roy Golan has submitted this change and it was merged. Change subject: virt-engine: Support RHEVManager url ...................................................................... virt-engine: Support RHEVManager url Added rewrite rule from RHEVManager to OvirtEngine to support old rhev-h on ovirt This patch depends on Change-Id: I4f36a302adbafdc5f9d0bb219896c794cbad31dd Change-Id: I3c3ce188155bda87f5cc106e2a6c2408fb0da790 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/conf/standalone.xml M packaging/fedora/setup/engine-setup.py 2 files changed, 20 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c3ce188155bda87f5cc106e2a6c2408fb0da790 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ronen Angluster <ranglust(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: ActionGroup filter by AppMode
by gchaplik＠redhat.com 28 May '12

28 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: ActionGroup filter by AppMode ...................................................................... webadmin: ActionGroup filter by AppMode filtering action groups in new role according to its supported application mode. using recursion. Change-Id: Id7928adf72eb719c5fb80655cf5c39311564a257 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ApplicationModeHelper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java 2 files changed, 29 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7928adf72eb719c5fb80655cf5c39311564a257 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: format code
by gchaplik＠redhat.com 28 May '12

28 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: format code ...................................................................... webadmin: format code format the code of the action group tree no code change Change-Id: Id659555e8022c3a84483444fab944182df7639ea Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java 1 file changed, 134 insertions(+), 49 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id659555e8022c3a84483444fab944182df7639ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Support Appliction Mode for ActionGroup
by gchaplik＠redhat.com 28 May '12

28 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Support Appliction Mode for ActionGroup ...................................................................... core: Support Appliction Mode for ActionGroup Adding property to action group, that indicates in which app mode it's supported. Change-Id: I87462cd1568798deb11323654df9b990750cd04b Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java 1 file changed, 55 insertions(+), 40 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87462cd1568798deb11323654df9b990750cd04b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <shireesh(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: New validations in add/edit cluster
by ofrenkel＠redhat.com 28 May '12

28 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: New validations in add/edit cluster ...................................................................... engine: New validations in add/edit cluster - At least one service (virt/gluster) must be enabled - Cannot disable virt service if cluster contains VMs - Cannot disable gluster service if cluster contains Gluster Volumes Change-Id: I32da5c4541af3e1ccfa04f14f839c0f98bece83b Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 148 insertions(+), 7 deletions(-) Approvals: Shireesh Anjal: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32da5c4541af3e1ccfa04f14f839c0f98bece83b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0