May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Cleanup Permissions Commands
by ofrenkel＠redhat.com 22 May '12

22 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Cleanup Permissions Commands ...................................................................... core: Cleanup Permissions Commands 1. Replaced DbFacade.getInstance().getXXDAO() with getXXDAO() 2. Added serialVersionUID 3. Solved warnings detected by Eclipse IDE. Change-Id: I4a4415ab37fd1b38aa8065c7a54f21459562f30d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddSelfPermissionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddSystemPermissionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PermissionsCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java 5 files changed, 30 insertions(+), 27 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a4415ab37fd1b38aa8065c7a54f21459562f30d Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Roles commands cleanup
by ofrenkel＠redhat.com 22 May '12

22 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Roles commands cleanup ...................................................................... core: Roles commands cleanup 1. Replaced ArrayList declarations with List declarations where possible. 2. Replaced DbFacade.getInstance().getXXDAO() with getXXDAO(). 3. Added serialVersionId. 4. Removed unsused classes: RoleActionCommandBase and RolesActionMapParameters. 5. Addressed Eclipse IDE warnings. 6. Changed protected methods from CSharpNamingConvention to javaNamingConvention. Change-Id: I3eb8e7f5ba3504f3fbd45c8c5685c03539bcb67c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachActionGroupsToRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachActionGroupsFromRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveRoleCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RoleActionCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RolesCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RolesOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRoleCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RolesActionMapParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 11 files changed, 57 insertions(+), 102 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eb8e7f5ba3504f3fbd45c8c5685c03539bcb67c Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Allow admin permissions in user views
by ofrenkel＠redhat.com 22 May '12

22 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Allow admin permissions in user views ...................................................................... core: Allow admin permissions in user views The user permissions views are intended to show all the objects a given user has permissions on, regardless of if it's an admin role or a user role (e.g., a user who is an admin on his own VM should be able to see itin the user portal). This patch fixes this issue. Change-Id: I27e60a3e855cb78a2cb773fdc53c3d1f35d8f058 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql 1 file changed, 38 insertions(+), 44 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4606 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27e60a3e855cb78a2cb773fdc53c3d1f35d8f058 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use same ids for artifacts and plugins
by dfediuck＠redhat.com 22 May '12

22 May '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Use same ids for artifacts and plugins ...................................................................... core: Use same ids for artifacts and plugins Currently we use different identifiers for the repositories used for normal artifacts and the repositories used for plugins. This may be triggering a bug in maven. Apparently maven 3 doesn't consider artifacts downloaded from different repositores to be the same, even if they use the same gid:aid. Maven creates a _maven.repositories where it stores the origin of the artifact like this: checkstyle-5.0.jar>id_of_the_repository= checkstyle-5.0.pom>id_of_the_repository= For example, when the checkstyle artifact is downloaded from the repository with id "maven1.central" the file will contain the following: checkstyle-5.0.jar>maven1.repo= checkstyle-5.0.pom>maven1.repo= Later when the maven-checkstyle-plugin is downloaded it comes from the repository with id "central" and apparently it looks for the checkstyle artifact from repository "central" as well, and it fails. This patch changes the root POM to use the same "centra"l" identifier for both artifacts and plugins. Change-Id: I5b0236f1dd0a1a18e226a22ed3563c462af90444 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b0236f1dd0a1a18e226a22ed3563c462af90444 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: fix rsdl regression
by mpastern＠redhat.com 22 May '12

22 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: fix rsdl regression ...................................................................... restapi: fix rsdl regression Change-Id: Id63bc21986e61162d9be5b063f2179840b57ea1e Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id63bc21986e61162d9be5b063f2179840b57ea1e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:dbfunctions.sh script needs to be compatible with DWH
by emesika＠redhat.com 22 May '12

22 May '12

Eli Mesika has submitted this change and it was merged. Change subject: core:dbfunctions.sh script needs to be compatible with DWH ...................................................................... core:dbfunctions.sh script needs to be compatible with DWH Since history database have separate set of views, view creation should be generalized. Moving view creation to refresh_views method in dbcustomfunctions.sh which is overridden by history. Change checksum to be computed on create_*views.sql (all scripts handling views should follow this format) Change-Id: I444650b30781e1af2250efbb9687e0272f21dfd0 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/dbcustomfunctions.sh M backend/manager/dbscripts/dbfunctions.sh 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I444650b30781e1af2250efbb9687e0272f21dfd0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: add recursive __eqals__ to business entitie #782891
by mpastern＠redhat.com 22 May '12

22 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: add recursive __eqals__ to business entitie #782891 ...................................................................... sdk: add recursive __eqals__ to business entitie #782891 more sophisticated compare based on deep recursive lookup Change-Id: Ifa725c478257d6e28d0d4a9903ac5cbf7d657a4b Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/common.py A src/ovirtsdk/utils/comperator.py M src/ovirtsdk/xml/params.py 3 files changed, 67 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa725c478257d6e28d0d4a9903ac5cbf7d657a4b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Gluster Volume - validations fixed (#823277)
by gchaplik＠redhat.com 22 May '12

22 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Gluster Volume - validations fixed (#823277) ...................................................................... webadmin: Gluster Volume - validations fixed (#823277) https://bugzilla.redhat.com/823277 1. A validation error will be shown in the bottom of the create volume dialog if the user has not added any bricks. 2. Validation error will be shown if the user has not selected any one of the transport types 3. Volume name cannot be empty, yellow frame will be shown if validation fails. Change-Id: If1430c9b9674f1dbca2ceada1a34317715fc047a Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.ui.xml 4 files changed, 39 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1430c9b9674f1dbca2ceada1a34317715fc047a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Gluster Volume - upadting actions (#823273)
by gchaplik＠redhat.com 22 May '12

22 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Gluster Volume - upadting actions (#823273) ...................................................................... webadmin: Gluster Volume - upadting actions (#823273) https://bugzilla.redhat.com/823273 The issues in enabling/disabling the actions on selecting the volumes is fixed. The code for updating the actions is refactored. Change-Id: I8b250824f5f0ed0dca97f94ff75fd559cfb84f59 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 24 insertions(+), 22 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b250824f5f0ed0dca97f94ff75fd559cfb84f59 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Gluster Volume - add bricks enabling (#823284)
by gchaplik＠redhat.com 22 May '12

22 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Gluster Volume - add bricks enabling (#823284) ...................................................................... webadmin: Gluster Volume - add bricks enabling (#823284) https://bugzilla.redhat.com/823284 Removed the code of disabling the add bricks button when volume name is not present as we are not using the volume name in the add bricks dialog currently. Change-Id: I6164971e9c0b139bc9760a823a03305c505ed03d Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6164971e9c0b139bc9760a823a03305c505ed03d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <shireesh(a)redhat.com>

1 0