May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[master]: agent: fixed removal of agent's dir on uninstall (bz#679451)...
by bazulay＠redhat.com 22 May '12

22 May '12

Barak Azulay has submitted this change and it was merged. Change subject: agent: fixed removal of agent's dir on uninstall (bz#679451). ...................................................................... agent: fixed removal of agent's dir on uninstall (bz#679451). Change-Id: I23e6c63421e28ea38277b156c65399299309f9b0 Signed-off-by: Gal Hammer <ghammer(a)redhat.com> --- M ovirt-guest-agent.spec 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Barak Azulay: Looks good to me, approved Gal Hammer: Verified -- To view, visit http://gerrit.ovirt.org/4605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23e6c63421e28ea38277b156c65399299309f9b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: fixed regression in setup
by ydary＠redhat.com 22 May '12

22 May '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed regression in setup ...................................................................... packaging: fixed regression in setup Change-Id: I1ad6a9a5e06a01d9005bdf62592858187bf31ead Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alex Lourie: Verified; Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ad6a9a5e06a01d9005bdf62592858187bf31ead Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: create gluster volume - fixed NPE
by ofrenkel＠redhat.com 22 May '12

22 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: create gluster volume - fixed NPE ...................................................................... engine: create gluster volume - fixed NPE https://bugzilla.redhat.com/823285 Create volume sometimes fails with NPE. This was happening when the VDS command throws exception, and hence the variable errorType remains unassigned. Modified getAuditLogTypeValue to return GLUSTER_VOLUME_CREATE_FAILED in such cases. Als performed following changes: - Introduced method(s) handleVdsError(s) in GlusterCommandBase for standard logic to handle failure in the VDS command - Modified executeCommand to handle VDS error if any coming from CreateGlusterVolumeVDSCommand Change-Id: Ia438153a11fe952e616b1b5ddfaa0a6c1d4f6ec8 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java 2 files changed, 21 insertions(+), 7 deletions(-) Approvals: Shireesh Anjal: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia438153a11fe952e616b1b5ddfaa0a6c1d4f6ec8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Correct validation message in new storage (#800763...
by tnisan＠redhat.com 22 May '12

22 May '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Correct validation message in new storage (#800763) ...................................................................... webadmin: Correct validation message in new storage (#800763) https://bugzilla.redhat.com/800763 Fixed a problem when trying to create a new storage with an empty storage name and then retrying with a non unique name, the validation message still appears as for an empty storage name Change-Id: I2c607617b0cc9c890c5044365ea8608de4409fe7 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c607617b0cc9c890c5044365ea8608de4409fe7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : Fixing all_disk view to handle multiple storage domai...
by emesika＠redhat.com 22 May '12

22 May '12

Eli Mesika has submitted this change and it was merged. Change subject: core : Fixing all_disk view to handle multiple storage domains ...................................................................... core : Fixing all_disk view to handle multiple storage domains These patch will fix a view: all_disks to handle multiple storage domains Change-Id: Ida5e90bdd31ef2eb5741deed99306f420c63a301 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida5e90bdd31ef2eb5741deed99306f420c63a301 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: fixed various rpmlint errors and warnings.
by bazulay＠redhat.com 22 May '12

22 May '12

Barak Azulay has submitted this change and it was merged. Change subject: agent: fixed various rpmlint errors and warnings. ...................................................................... agent: fixed various rpmlint errors and warnings. Change-Id: I7a13d4a345ab3300713e20c291ef8549d0e6f765 Signed-off-by: Gal Hammer <ghammer(a)redhat.com> --- M NEWS M configure.ac M gdm-plugin/gdm-ovirtcred-extension.c M gdm-plugin/gdm-ovirtcred-extension.h M ovirt-guest-agent.spec M ovirt-guest-agent/CredServer.py M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/OVirtAgentLogic.py M ovirt-guest-agent/VirtIoChannel.py 9 files changed, 358 insertions(+), 352 deletions(-) Approvals: Barak Azulay: Looks good to me, approved Gal Hammer: Verified -- To view, visit http://gerrit.ovirt.org/4604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a13d4a345ab3300713e20c291ef8549d0e6f765 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : Changing GetVmsByImageGuidQuery to GetVmsByDiskGuidQu...
by mkublin＠redhat.com 22 May '12

22 May '12

Michael Kublin has submitted this change and it was merged. Change subject: core : Changing GetVmsByImageGuidQuery to GetVmsByDiskGuidQuery ...................................................................... core : Changing GetVmsByImageGuidQuery to GetVmsByDiskGuidQuery >From now there are no need for retrieve a vms by imageGuid, the vms should be retrieved by diskId. The following patch is providing a needed change and some clean up Change-Id: Iaa020e682cd4545249dd87ad825f8b39e8be2d8d Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/vms_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByDiskGuidQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByImageGuidQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmsByImageGuidQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsByDiskGuidParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsByImageGuidParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/GetVmsByImageGuidParametersTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskVmListModel.java 13 files changed, 71 insertions(+), 121 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa020e682cd4545249dd87ad825f8b39e8be2d8d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix job properties in remove VmPool to show cluster na...
by ofrenkel＠redhat.com 22 May '12

22 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix job properties in remove VmPool to show cluster name (#817366) ...................................................................... core: fix job properties in remove VmPool to show cluster name (#817366) https://bugzilla.redhat.com/show_bug.cgi?id=817366 added implementation to getJobMessageProperties in RemoveVmPoolCommand, that add the cluster in order to show its name. setting the cluster id in the ctor so it would be available in the command, allowing cluster details in audit log as well Change-Id: Ic2f584c0a15c09923ee9bde5640666cdad5d4e81 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2f584c0a15c09923ee9bde5640666cdad5d4e81 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: is_inheritable property to MLA entities
by ofrenkel＠redhat.com 22 May '12

22 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: is_inheritable property to MLA entities ...................................................................... core: is_inheritable property to MLA entities Added the is_inheritable property to the Action Group and Role MLA business entities. This patch handles the addition of the property itself in the java and database sides. It does not contain the changes in the logic that update or use this property, which will be added in a later patch. Change-Id: I8732306c515bade05db5cb95b9d571003fdec177 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/multi_level_administration_sp.sql A backend/manager/dbscripts/upgrade/03_01_1100_add_inheritable_roles.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/roles.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/RolesRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 8 files changed, 92 insertions(+), 64 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8732306c515bade05db5cb95b9d571003fdec177 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Roles commands - use the cached getRole()
by ofrenkel＠redhat.com 22 May '12

22 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Roles commands - use the cached getRole() ...................................................................... core: Roles commands - use the cached getRole() The roles commands have a caching mechnism, getRole(), which saves calling getRoleDAO.get(params.getRoleId()) several times. This patch makes sure it's used where possible. Whre the flows aren't straight forward, a unit test was added to ensure the behavior was not changed. Change-Id: I69210adfae7962147e0923745e6b37dcf98d0f0d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachActionGroupsToRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachActionGroupsFromRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RolesCommandBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractRolesCommandTestBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachActionGroupsToRoleCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RolesCommandBaseTest.java 9 files changed, 222 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69210adfae7962147e0923745e6b37dcf98d0f0d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0