Change in ovirt-engine[master]: core: Cleanup StorageHandlingCommandBase
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Cleanup StorageHandlingCommandBase
......................................................................
core: Cleanup StorageHandlingCommandBase
Replaced calls to DbFacade.getInstance().getXXDAO() with getXXXDAO().
Change-Id: Ic911e41aea9ea8fe5c7ff26a697904d12b621167
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
1 file changed, 7 insertions(+), 8 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/4627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic911e41aea9ea8fe5c7ff26a697904d12b621167
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: engine, webadmin: Read ApplicationMode upon WebAdmin startup
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: engine,webadmin: Read ApplicationMode upon WebAdmin startup
......................................................................
engine,webadmin: Read ApplicationMode upon WebAdmin startup
This patch allows WebAdmin application to read ApplicationMode
config property right upon its startup.
Changes in 'engine' component:
1. Added ConfigurationValues.ApplicationMode as allowed config value
when invoking GetConfigurationValue via Backend.RunPublicQuery
(this is needed in order to read ApplicationMode for all users)
Changes in 'webadmin' component:
2. GwtDynamicHostPageServlet refactored a bit:
- introduced writeJsObject() method
- createQueryParams() method changed to initQueryParams()
- removed filterQueries() method, its effect is now achieved
by overriding initQueryParams() in UserportalDynamicHostingServlet
- added convenience runQuery() and runPublicQuery() methods
3. WebadminDynamicHostingServlet now includes 'applicationMode'
JavaScript data object into the host page, with its value being
read via GetConfigurationValue/ApplicationMode as public query
4. Created package 'org.ovirt.engine.ui.webadmin.uimode':
- UiModeData is the overlay type for 'applicationMode' JS object
- UiMode enum represents possible 'applicationMode' values
5. Reading ApplicationMode in WebAdmin ApplicationInit via
handleUiMode() method
Change-Id: I03ab99f18d1bbcba57385bf1a29d32b15050b7bf
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/UserportalDynamicHostingServlet.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebadminDynamicHostingServlet.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uimode/UiMode.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uimode/UiModeData.java
7 files changed, 176 insertions(+), 22 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4433
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03ab99f18d1bbcba57385bf1a29d32b15050b7bf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: userportal, webadmin: when login automatically, disable logi...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal, webadmin: when login automatically, disable login screen
......................................................................
userportal, webadmin: when login automatically, disable login screen
When the user is logged in, and opens for example a new tab,
the application loggs him/her in automatically.
The problem is, that the login screen is not disabled during this
process. So it can happen, that during the process of loggin in
automatically, the user fills in some data into the login form,
which has no meening.
The solution was to disable the login screen and not enable it,
when it is in process of auto login.
Change-Id: I3b2a15eb8d17a00f07590996f96f617014e0ecd6
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java
2 files changed, 28 insertions(+), 18 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b2a15eb8d17a00f07590996f96f617014e0ecd6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: Main tab presenter reveal bound to model availabil...
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Main tab presenter reveal bound to model availability
......................................................................
webadmin: Main tab presenter reveal bound to model availability
This patch makes sure that main tab presenters (AbstractMainTabPresenter)
can only be revealed if the corresponding main model is available.
Besides tab widgets (ModelBoundTab) sensitive to main model availability,
this makes sure that users cannot access restricted main tabs even if they
manipulate browser URL (which initiates GWTP place navigation and presenter
reveal process).
Change-Id: I822f14bc4cde42cfed646206b63a76345ec583a3
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java
2 files changed, 35 insertions(+), 9 deletions(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit http://gerrit.ovirt.org/4622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I822f14bc4cde42cfed646206b63a76345ec583a3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: checking for model only when not null
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: checking for model only when not null
......................................................................
core: checking for model only when not null
Previous patch added a test for the model of USB controllers, and
ordering them accordingly. But, in legacy USB support, the model is
null, which leads to NPE. This patch fixes that behaviour.
Change-Id: I2f5f9253c145c2250f30a58d16c80109fa54a563
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f5f9253c145c2250f30a58d16c80109fa54a563
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Use lower case for place holders of task message
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Use lower case for place holders of task message
......................................................................
core: Use lower case for place holders of task message
The key which is passed to the message resolve should be in lower case
since this is the expected key convention by
AuditLogDirector.resolveMessage()
Change-Id: I6cc07034d0f828cc9337c187ef3956eb5dba2681
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
1 file changed, 3 insertions(+), 5 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/4610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cc07034d0f828cc9337c187ef3956eb5dba2681
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: packaging: engine-setup - Add no-mem-check option
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: engine-setup - Add no-mem-check option
......................................................................
packaging: engine-setup - Add no-mem-check option
Add the ability to avoid the memory check in engine-setup.
Don't show memory message if user asked to se help.
Change-Id: If873f1a7c7684d9612fb420878a7e09e4660f0ad
Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com>
---
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/output_messages.py
2 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4609
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If873f1a7c7684d9612fb420878a7e09e4660f0ad
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: USB devices
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: USB devices
......................................................................
core: USB devices
This commit contains the USB devices implementation for adding Native
USB support to the oVirt engine.
USB devices are composed of:
1. EHCI controller
2. 3 UHCI companion controllers
3. Redirect slots (up to 6)
Change-Id: Id90e976cd85f584de37a08db1981287a6554b8b3
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlNode.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java
15 files changed, 335 insertions(+), 6 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4371
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id90e976cd85f584de37a08db1981287a6554b8b3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: backend: adding config entry for number of USB slots
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: backend: adding config entry for number of USB slots
......................................................................
backend: adding config entry for number of USB slots
This patch adds NumberOfUSBSlots config entry to vdc_options.
It will be used when using native USB support, to specify the number of
USB slots to on the VM.
Change-Id: I120a26e480b91fee9d95764721b6c68405003224
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/tools/engine-config/src/main/resources/engine-config.properties
3 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I120a26e480b91fee9d95764721b6c68405003224
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: engine: adding new support for native USB
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: adding new support for native USB
......................................................................
engine: adding new support for native USB
This patch adds support for a new type of USB, native USB.
Changes in this patch:
* Change the USB Policy patch to include the Native USB support
- Old "Enabled" was changed to "ENABLED_LEGACY"
- Old "Disabled" was changed to "DISABLED"
- New native will have policy of "ENABLED_NATIVE"
* All the changes in the engine (core, REST, UI) that are resulted from this rename
* REST API logic that chooses the default value according to the cluster level
* Backend validations in VM/Template commands
Change-Id: I25aa315fa85838e4371e232017f7d4eeee558c79
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UsbPolicy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/UsbType.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/resource/utils/UsbResourceUtils.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/resource/utils/UsbResourceUtilsTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/UsbMapperUtils.java
A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/utils/UsbMapperUtilsTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/test/resources/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/userportal/UserVmModel.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
44 files changed, 632 insertions(+), 37 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25aa315fa85838e4371e232017f7d4eeee558c79
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 7 months