Change in ovirt-engine-cli[master]: cli: miss-type in "help list" command #803399
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: miss-type in "help list" command #803399
......................................................................
cli: miss-type in "help list" command #803399
https://bugzilla.redhat.com/show_bug.cgi?id=803399
Change-Id: I108964706029c165b1d6ef025f59fd1877a93527
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/command/list.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4590
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I108964706029c165b1d6ef025f59fd1877a93527
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: core : Moving mapping of vm_id to be shared for DiskImage an...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core : Moving mapping of vm_id to be shared for DiskImage and LunDisk
......................................................................
core : Moving mapping of vm_id to be shared for DiskImage and LunDisk
The following fix should make a shared property of vm_id for DiskImage and LunDisk entities
Change-Id: If6ef7d34837de012ad58b3c618e7da5824a74c26
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractDiskRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4589
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If6ef7d34837de012ad58b3c618e7da5824a74c26
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: core: fix pass bridged and mtu property in add/edit network ...
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: fix pass bridged and mtu property in add/edit network api
......................................................................
core: fix pass bridged and mtu property in add/edit network api
passing the "bridged" and "mtu" parameter according to the logical network property
both where included in setupnetworks command but missing in add/edit network flow (AKA old API)
* refactor the parameter class to hold the network entity from the DB.
* pass bridged=true|false according to the network.isVmNetwork() value.
* pass mtu value in case the logical network mtu is not 0 (which means don't override)
Change-Id: Ifacdace1f1517df13d087ed6102cd30496c45855
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/NetworkVdsmVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java
6 files changed, 176 insertions(+), 66 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4198
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifacdace1f1517df13d087ed6102cd30496c45855
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: core: Cleanup RoleDAO and its test
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Cleanup RoleDAO and its test
......................................................................
core: Cleanup RoleDAO and its test
1. Replaced new RolesRowMapper() calls with a static instance, as per
http://ovirt.org/wiki/Backend_Coding_Standards.
2. Replaced * imports with FCQN imports.
3. Fixed javadoc typos.
Change-Id: I37ead9c07904302204b99d919c27061fff4f0b8f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/RolesRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java
3 files changed, 14 insertions(+), 10 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4474
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37ead9c07904302204b99d919c27061fff4f0b8f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: core: Support floating lun in the DAO
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Support floating lun in the DAO
......................................................................
core: Support floating lun in the DAO
Before this patch DiskDAO would crash when attempting to read a floating
lun due to missing treatment for vm_entity_type.
Such a treatment existed in DiskImageDao, however.
This patch extarcts the AbstractBaseDiskRowMapper class, and changes
AbstractDiskRowMapper to handle Disks instead of BaseDisks.
Having done that, AbstractDiskRowMapper can now handle the entityType
field, so that both DiskImageRowMapper and LunDiskRowMapper that extend
it will get that functionality.
In addtition, this patch also adds a floating lun to the fixtures.xml to
test this functionality, and updates the other disks' tests accordingly.
Change-Id: Iec20c0092375cb1a7ee4b7b40f57e75d2c5cd13c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractBaseDiskRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractDiskRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskLunMapDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
10 files changed, 106 insertions(+), 49 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4466
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec20c0092375cb1a7ee4b7b40f57e75d2c5cd13c
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: core: Cleanup RoleGroupMapDAO and its tests
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Cleanup RoleGroupMapDAO and its tests
......................................................................
core: Cleanup RoleGroupMapDAO and its tests
1. Used a static instance of the row mapper as per
http://ovirt.org/wiki/Backend_Coding_Standards.
2. Replaced executeReadAndReturnMap calls to the standard executeRead
and executeReadList.
2. Replaed * imports with FCQN imports.
Change-Id: I63a99b42978955b1c8b82ec0849f095de07c1158
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/RoleGroupMapRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleGroupMapDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleGroupMapDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleGroupMapDAOTest.java
4 files changed, 17 insertions(+), 29 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63a99b42978955b1c8b82ec0849f095de07c1158
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: core: Cleanup roles
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Cleanup roles
......................................................................
core: Cleanup roles
General java cleanups and addressing Eclipse IDE warnings.
Change-Id: I0b73b066b53b82e3b8d5bdd664ece9aa57ce436d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/roles.java
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b73b066b53b82e3b8d5bdd664ece9aa57ce436d
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: core: Minor cleanup in RoleGroupMap
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Minor cleanup in RoleGroupMap
......................................................................
core: Minor cleanup in RoleGroupMap
Removed redundent semi-colon after a method.
Change-Id: Ic016ce1896019883040b408f15d76a7bf2c615c8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RoleGroupMap.java
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4519
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic016ce1896019883040b408f15d76a7bf2c615c8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: restapi: Clone VM from template fails due to unhandled excep...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Clone VM from template fails due to unhandled exception
......................................................................
restapi: Clone VM from template fails due to unhandled exception
Change-Id: I87866a5f304c5be756c1c6dd94a71c31a0b9209f
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4572
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87866a5f304c5be756c1c6dd94a71c31a0b9209f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: restapi: fix incorrect parameter defenition for action.stora...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: fix incorrect parameter defenition for action.storage_domain
......................................................................
restapi: fix incorrect parameter defenition for action.storage_domain
Change-Id: Ic6be6785bc439cbdaea4472075447ef552592617
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4567
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6be6785bc439cbdaea4472075447ef552592617
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 1 month