May 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: Disable re-initialize option for local storage DC

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Disable re-initialize option for local storage DC ...................................................................... webadmin: Disable re-initialize option for local storage DC Disabled the "Re-Initialize Data Center' option on data centers of local storage type Change-Id: Iaeff4a09ecd436f546b8aebbbf668659e48e407a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaeff4a09ecd436f546b8aebbbf668659e48e407a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Change data center re-initialize warning message

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Change data center re-initialize warning message ...................................................................... webadmin: Change data center re-initialize warning message Change-Id: I73011019f91ff8e4e8af6c4eb2df2a53d2366589 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/RecoveryStorageConfirmationPopupView.ui.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73011019f91ff8e4e8af6c4eb2df2a53d2366589 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Flag GetAllAttachableDisks as a user query

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Flag GetAllAttachableDisks as a user query ...................................................................... core: Flag GetAllAttachableDisks as a user query The query was originally written so it passses the filtering parameters to the DAO, but was not flagged as a user query. Now that the DAO is implemented properly, the query could be flagged as a user query. Change-Id: I5c09d71601bdb6ad32f0c673c763cfb6fc272145 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c09d71601bdb6ad32f0c673c763cfb6fc272145 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Filter GetAllAttachableDisksByPoolId

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Filter GetAllAttachableDisksByPoolId ...................................................................... core: Filter GetAllAttachableDisksByPoolId Added permission filtering to GetAllAttachableDisksByPoolId, instead of the stub implementation that was present there. This patch includes the filtering code, a test for it, and some testing data in fixtures.xml. Change-Id: I04f319a036952567f1e7f9a2761ec98753052bae Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/all_disks_sp.sql M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 37 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04f319a036952567f1e7f9a2761ec98753052bae Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Add floating disk to fixtures.xml

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add floating disk to fixtures.xml ...................................................................... core: Add floating disk to fixtures.xml Added a floating disk (image) to the testing database (fixtures.xml), so it can be addressed the unit test. This patch includes the new floating disk, and fixing the related unit tests so that they will be aware to its presence. Change-Id: Ie2b1e927feba707e7ca7f382ce270cedc0a2bb80 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 5 files changed, 45 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2b1e927feba707e7ca7f382ce270cedc0a2bb80 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Cleanup DiskDao and its tests

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Cleanup DiskDao and its tests ...................................................................... core: Cleanup DiskDao and its tests General cleanup in the DAO and its tests: 1. Made private methods static where possible 2. migrated Guid string constants from the test to FixturesTool so they could be reused. 3. Renamed some test methods to be more readable Change-Id: I9551288f38b537c8196f2a2d79012457a0220cc1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java 3 files changed, 22 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9551288f38b537c8196f2a2d79012457a0220cc1 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: GetDiskConfigurationList as a user query

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: GetDiskConfigurationList as a user query ...................................................................... core: GetDiskConfigurationList as a user query Flagged the query as a user query, since it is required for adding disks to VMs in the Power User Portal. Note that no filtering is performed here - This query returns a static Config value, which should be available to all users. Change-Id: Ide93aca062937f5fd43bd9cf3df376c8829a4bf9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDiskConfigurationListQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide93aca062937f5fd43bd9cf3df376c8829a4bf9 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: GetVdsGroupsByStoragePoolId as a user query

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: GetVdsGroupsByStoragePoolId as a user query ...................................................................... core: GetVdsGroupsByStoragePoolId as a user query Made GetVdsGroupsByStoragePoolIdQuery a user query, so it can be called from the User Portal. This patch includes the refactoring of the query, the appropriate parameter change in VdcQueryType and a test to prove the correct DAO method is called. Change-Id: I53a230e1003920594bfad6065ae4be876d13742a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsGroupsByStoragePoolIdQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsGroupsByStoragePoolIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 50 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53a230e1003920594bfad6065ae4be876d13742a Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Cleanup GetDiskConfigurationListQuery

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Cleanup GetDiskConfigurationListQuery ...................................................................... core: Cleanup GetDiskConfigurationListQuery Minor clenaup in GetDiskConfigurationListQuery - replaced FQCNs with imports, extracted constant instead of a literal 4. In addition, added a test case to prove that no functionality was lost in the process. Change-Id: I9126318a7fcb6e0f01e38ff23e5409b9e99ba41a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskConfigurationListQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDiskConfigurationListQueryTest.java 2 files changed, 130 insertions(+), 6 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9126318a7fcb6e0f01e38ff23e5409b9e99ba41a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: DAO for getting all the hosts in the DC

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: DAO for getting all the hosts in the DC ...................................................................... core: DAO for getting all the hosts in the DC Added a method to get all the hosts in the data-center, for future use (i.e., next patch) in the Power User Portal. Change-Id: I82b540c4ee12eb16c809cee6bcf6de60b7b7a3b7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAOWrapperImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java 5 files changed, 122 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82b540c4ee12eb16c809cee6bcf6de60b7b7a3b7 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits May 2012