May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Import Template more than once
by gchaplik＠redhat.com 18 May '12

18 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Import Template more than once ...................................................................... core: Import Template more than once feature page: http://www.ovirt.org/wiki/Features/ImportMoreThanOnce to be continued: -REST support Change-Id: Idf647c5c95c12c58b6609e497b3e181127b501b6 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyParameters.java 3 files changed, 70 insertions(+), 17 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf647c5c95c12c58b6609e497b3e181127b501b6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Move ROOT.war to the EAR
by ecohen＠redhat.com 17 May '12

17 May '12

Einav Cohen has submitted this change and it was merged. Change subject: packaging: Move ROOT.war to the EAR ...................................................................... packaging: Move ROOT.war to the EAR This patch moves the root web application to the EAR file. This has several advantages: 1. There is only one deployment unit to add to the application server, so the setup and packaging is simplified. 2. The root web application works without needing to use the engine-setup tool. This can be very useful for development environments. 3. The root web application is a regular maven subproject so it can be built taking advantage of all the maven capabilities. In particular the content can be dynamically generated using servlets. In fact this is already used to generate the following files: web-conf.js Instead of copying this file from the /etc/ovirt-engine directory the application contains a servlet that reads that file and sends it content. It also can guess the content of the file even if it doesn't exist (useful for development environments). ca.pem Instead of copying this file from the /etc/pki/ovirt-engine directory the application uses a servlet to read it from its original location and send the content with the right content type. engine.ssh.key.txt Instead of copying the file from /etc/pki/ovirt-engine/keys directory the application uses a servlet to read it from its original location. This could be improved to generate the content directly from the keystore. This means three files that don't need to be copied or symlinked during the setup of the engine and can be placed only in the directories they are expected to be according to the file system standards (configuration files only in /etc, so on). This patch also simplifies the setup tools so that they don't need to modify the web.xml file. Change-Id: I1d3aa9af7b78546b5449031c8db23ff766b68496 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/conf/ca/installCA_dev.sh M backend/manager/modules/pom.xml A backend/manager/modules/root/pom.xml A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/FileServlet.java A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/ServletUtils.java A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/WebConfServlet.java A backend/manager/modules/root/src/main/resources/META-INF/MANIFEST.MF A backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml R backend/manager/modules/root/src/main/webapp/engineVersion.js R backend/manager/modules/root/src/main/webapp/favicon.ico R backend/manager/modules/root/src/main/webapp/images/bg_head.gif R backend/manager/modules/root/src/main/webapp/images/bg_main.gif R backend/manager/modules/root/src/main/webapp/images/logo.png A backend/manager/modules/root/src/main/webapp/index.html A backend/manager/modules/root/src/main/webapp/style.css A backend/manager/modules/root/src/resources/META-INF/MANIFEST.MF M ear/pom.xml M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/output_messages.py M packaging/fedora/setup/ovirt_port80.py D packaging/fedora/setup/resources/jboss/ROOT.war/WEB-INF/context.xml D packaging/fedora/setup/resources/jboss/ROOT.war/WEB-INF/jboss-web.xml D packaging/fedora/setup/resources/jboss/ROOT.war/WEB-INF/web.xml D packaging/fedora/setup/resources/jboss/ROOT.war/engine_index.html D packaging/fedora/setup/resources/jboss/ROOT.war/style.css M packaging/fedora/spec/ovirt-engine.spec.in 29 files changed, 538 insertions(+), 396 deletions(-) Approvals: Juan Hernandez: Verified Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d3aa9af7b78546b5449031c8db23ff766b68496 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Boot from CD doesn't work on 3.1 compatibility(820127)
by emesika＠redhat.com 17 May '12

17 May '12

Eli Mesika has submitted this change and it was merged. Change subject: core:Boot from CD doesn't work on 3.1 compatibility(820127) ...................................................................... core:Boot from CD doesn't work on 3.1 compatibility(820127) https://bugzilla.redhat.com/show_bug.cgi?id=820127 Fix addresses basically three issues: 1) Make sure that no null values are added to the structure passed to vdsm 2) Take the boot sequence from dynamic parameters in run-once. 3) Pass in CD/Floppy full path and not only file name. Seems that all problems are regressions of massive refactoring on the stable device addresses feature code. Change-Id: Ida06b34f94e791a344e017cd5a6915e31b827cc9 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 9 insertions(+), 29 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida06b34f94e791a344e017cd5a6915e31b827cc9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Templates disks sub-tab - enable copy
by derez＠redhat.com 17 May '12

17 May '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Templates disks sub-tab - enable copy ...................................................................... webadmin: Templates disks sub-tab - enable copy Enabling 'Copy' button in Templates Disks sub-tab. Change-Id: Ice6e8597d81a7dbbd42012d7669834916e66f978 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/DisksTree.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice6e8597d81a7dbbd42012d7669834916e66f978 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Do not identify disk by snapshot-id
by oliel＠redhat.com 17 May '12

17 May '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Do not identify disk by snapshot-id ...................................................................... restapi: Do not identify disk by snapshot-id Probably for legacy reasons, after disk creation, when resolving the created entity, snapshot-id was used to determine disk identity. This patch removes this and modifies test accordingly. Change-Id: I3ae978ccddaec0a37bf23cfad130e317174e7388 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDisksResourceTest.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ae978ccddaec0a37bf23cfad130e317174e7388 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Adding ApplicationMode to vdc_options
by ofrenkel＠redhat.com 17 May '12

17 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Adding ApplicationMode to vdc_options ...................................................................... engine: Adding ApplicationMode to vdc_options ApplicationMode entry is added to vdc_options table with a default value of 3. This configuration property is used in the client side(frontend) to show the mode specific UI. Currently supported modes are VIRT_ONLY(value-1),GLUSTER_ONLY(value-2), VIRT_GLUSTER(value-3). Change-Id: I2abb71bde26f16c7d64fd122825fa5ee210d79c9 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java 3 files changed, 7 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2abb71bde26f16c7d64fd122825fa5ee210d79c9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: move NlsCheck.java to checks package per declaration in file
by dfediuck＠redhat.com 17 May '12

17 May '12

Doron Fediuck has submitted this change and it was merged. Change subject: move NlsCheck.java to checks package per declaration in file ...................................................................... move NlsCheck.java to checks package per declaration in file Change-Id: I3934f6745c93aa1f2465538a389c60716749c429 Signed-off-by: Itamar Heim <iheim(a)redhat.com> --- R build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3934f6745c93aa1f2465538a389c60716749c429 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Add Vm Payload RSDL Metadata
by oliel＠redhat.com 17 May '12

17 May '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Add Vm Payload RSDL Metadata ...................................................................... restapi: Add Vm Payload RSDL Metadata Change-Id: Idb111e1545324dcb7ffcce706faa2113eae76b25 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb111e1545324dcb7ffcce706faa2113eae76b25 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: fix product name and vendor to oVirt Engine and ovi...
by mpastern＠redhat.com 17 May '12

17 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: fix product name and vendor to oVirt Engine and ovirt.org ...................................................................... restapi: fix product name and vendor to oVirt Engine and ovirt.org Change-Id: I9d82aed8a9ba87a42099d1f9e33f8913817caaa8 Signed-off-by: Itamar Heim <iheim(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d82aed8a9ba87a42099d1f9e33f8913817caaa8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Gluster Volume - Remove Bricks implementation
by gchaplik＠redhat.com 16 May '12

16 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Gluster Volume - Remove Bricks implementation ...................................................................... webadmin: Gluster Volume - Remove Bricks implementation A mew ui action is added in Bricks Sub Tab for removing single/mutiple bricks. A confirmation dialog will be shown before removing the selected bricks. Change-Id: I02b5bbbac3882b7552567f48b5f907bdb2198e59 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java 4 files changed, 130 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02b5bbbac3882b7552567f48b5f907bdb2198e59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0