Change in ovirt-engine[master]: restapi: Add new action - reloadconfigurations
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: restapi: Add new action - reloadconfigurations
......................................................................
restapi: Add new action - reloadconfigurations
This patch adds a new action, to allow Reloadable
Configurations.
Signed-off-by: Muli Salem <msalem(a)redhat.com>
Change-Id: I47002df34e91270985780f742cb9e857382c15c1
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ApiResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
2 files changed, 32 insertions(+), 4 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4503
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47002df34e91270985780f742cb9e857382c15c1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Add ReloadConfigurationsCommand
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Add ReloadConfigurationsCommand
......................................................................
core: Add ReloadConfigurationsCommand
This patch adds the command above, for the Reload Configurations
feature. It also adds the Reloadable Annotation.
Signed-off-by: Muli Salem <msalem(a)redhat.com>
Change-Id: Ie87110a4e5102372791eb93a4fadecf664b11756
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ReloadConfigurationsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/Reloadable.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
7 files changed, 100 insertions(+), 10 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie87110a4e5102372791eb93a4fadecf664b11756
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: tools: Add flag only-reloadable to engine-config
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: tools: Add flag only-reloadable to engine-config
......................................................................
tools: Add flag only-reloadable to engine-config
This patch allows the user to get a list of the reloadable keys
according to the properties file.
Change-Id: Ic57b48d82682223d92f0e2a4108353a861f22ddc
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigMap.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/OptionKey.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java
M backend/manager/tools/engine-config/src/test/java/org/ovirt/engine/core/config/EngineConfigCLIParserTest.java
7 files changed, 95 insertions(+), 17 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic57b48d82682223d92f0e2a4108353a861f22ddc
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: adding alias to vm_device
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: adding alias to vm_device
......................................................................
core: adding alias to vm_device
This patch adds the alias of the device to the vm_device table.
We use this field to sort devices in cases devices from the same type
appear more than once, and the order is important. We set the order
according to the alias. In this patch it is used mostly for video
devices.
Change-Id: I9d543dbb96b002defbe2b85c88a4f24fab8e5f04
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
A backend/manager/dbscripts/upgrade/03_01_1120_vm_device_add_alias_column.sql
M backend/manager/dbscripts/vm_device_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
16 files changed, 93 insertions(+), 26 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Oved Ourfali: Verified
--
To view, visit http://gerrit.ovirt.org/4784
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d543dbb96b002defbe2b85c88a4f24fab8e5f04
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: oVirt Modes - host general tab, dialog changes
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: oVirt Modes - host general tab,dialog changes
......................................................................
webadmin: oVirt Modes - host general tab,dialog changes
Virt related fields in Host General sub tab will be hidden
when application is running in GlusterOnly mode.
SPM tab in Host dialog will be hidden in GlusterOnly mode.
Change-Id: I624888b87037233878bffe59f0e094722e9d6206
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java
2 files changed, 60 insertions(+), 27 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I624888b87037233878bffe59f0e094722e9d6206
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: oVirt Modes - Cluster General tab, dialog changes
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: oVirt Modes - Cluster General tab,dialog changes
......................................................................
webadmin: oVirt Modes - Cluster General tab,dialog changes
Summary of volume details will be shown in the General sub tab
of cluster along side with policy details. Volume details
will be present in GlusterOnly or Gluster supported modes.
Volume details include
1. No. of Volumes present in the cluster
2. Up Count
3. Down Count
Memory Optimization and Resilience Policy tabs in cluster
dialog will be hiiden in GlusterOnly mode.
Change-Id: If2f77e34989d82abad0b7926ce4d9a9fc97da587
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.ui.xml
5 files changed, 175 insertions(+), 28 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4820
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2f77e34989d82abad0b7926ce4d9a9fc97da587
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: Gluster Create Volume - localization, loading adde...
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Gluster Create Volume - localization, loading added
......................................................................
webadmin: Gluster Create Volume - localization, loading added
1. Volume type shown in Add Bricks dialog is now localized.
(Accessed either through create volume dialog or add bricks action)
2. Loading added for create volume action. This prevents the user
from clicking the ok twice.
Change-Id: Idd96d98b163cfb394dcef3c13830d8bfb207deff
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java
4 files changed, 11 insertions(+), 4 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4834
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd96d98b163cfb394dcef3c13830d8bfb207deff
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin, userportal: PlaceManager refactoring
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin,userportal: PlaceManager refactoring
......................................................................
webadmin,userportal: PlaceManager refactoring
WebAdmin's default main section place should depend on current
"UI mode" setting (related to mode-specific UI feature).
For example, in GlusterOnly UI mode, "Virtual Machines" main tab
is not available and the place manager should therefore redirect
the user into different main tab after logging in.
This patch refactors ApplicationPlaceManager, related classes
and GIN configuration bindings.
WebAdmin's UiMode -> default place resolution logic is in
WebAdminPlaceManager.resolveMainSectionPlace() method.
Change-Id: I50c4005ec8e046c63bc22e8410cdd3f26e5908f2
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/SystemModule.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/place/UserPortalPlaceManager.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/DefaultMainSectionExtendedPlace.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/WebAdminPlaceManager.java
7 files changed, 88 insertions(+), 38 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4708
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50c4005ec8e046c63bc22e8410cdd3f26e5908f2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: tools: Add action reload to engine-config
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: tools: Add action reload to engine-config
......................................................................
tools: Add action reload to engine-config
This patch adds the "reload" action to the engine-config tool.
The new action is currently unimplemented and therefore not
documented in the tool, but is intended to reload configurations.
Signed-off-by: Muli Salem <msalem(a)redhat.com>
Change-Id: I22e407ad9a1982b7bc3e50cac35a9c5a34da5581
---
D backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/AlternateFileType.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigMap.java
A backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/OptionKey.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/validation/ConfigActionType.java
M backend/manager/tools/engine-config/src/test/java/org/ovirt/engine/core/config/EngineConfigCLIParserTest.java
7 files changed, 175 insertions(+), 62 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22e407ad9a1982b7bc3e50cac35a9c5a34da5581
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
12 years, 7 months
Change in ovirt-engine[master]: userportal: VNC connection details
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal: VNC connection details
......................................................................
userportal: VNC connection details
in case press console to vnc, the app will open a popup
indicates the VNC connection details.
Change-Id: I0b3a5352822b97d76d5b09ecef5fc42259c863f0
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java
A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VncInfoPopupPresenterWidget.java
A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VncInfoPopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/basic/UserPortalBasicListProvider.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/utils/ConsoleManager.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/ConsoleProtocol.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/ConsoleUtils.java
10 files changed, 113 insertions(+), 11 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4790
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b3a5352822b97d76d5b09ecef5fc42259c863f0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 7 months