Change in ovirt-engine-sdk[master]: sdk: remove yet not supported collections/resources (3+ deep...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: remove yet not supported collections/resources (3+ deep URLs)
......................................................................
sdk: remove yet not supported collections/resources (3+ deep URLs)
Change-Id: I70e5cad7d877013f48588064e3018db62321eaf7
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/codegen/main.py
M src/ovirtsdk/infrastructure/brokers.py
2 files changed, 5 insertions(+), 141 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4821
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70e5cad7d877013f48588064e3018db62321eaf7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 10 months
Change in ovirt-engine-sdk[master]: sdk: rebase to latest api
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: rebase to latest api
......................................................................
sdk: rebase to latest api
added:
=====
partial gluster support
partial quota support
remove template disk (by storage domain)
vm.payload
floating disk
Change-Id: I277397ddd1572fe9c8fb29a91e22e241a14d5922
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/codegen/subcollection/subresource.py
M src/ovirtsdk/api.py
M src/ovirtsdk/infrastructure/brokers.py
M src/ovirtsdk/xml/params.py
4 files changed, 1,962 insertions(+), 52 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4819
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I277397ddd1572fe9c8fb29a91e22e241a14d5922
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Fix handling same network on different nics
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Fix handling same network on different nics
......................................................................
core: Fix handling same network on different nics
The old check would never catch this scenario, since the
networksOverBond list was locally initiated to an empty list.
The check should be simple - network can be defined only once on some
interface.
Clarification:
If it is a bond interface then it can't be defined on the
bond slaves.
If it is a VLAN then it can't be defined on the VLAN's NIC.
Change-Id: I4cb7f7c0c7cc7c2240b72e411d81c2ddbc561766
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
2 files changed, 1 insertion(+), 7 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4713
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cb7f7c0c7cc7c2240b72e411d81c2ddbc561766
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Change SetupNetworks remove network (#820505)
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Change SetupNetworks remove network (#820505)
......................................................................
core: Change SetupNetworks remove network (#820505)
https://bugzilla.redhat.com/820505
Setup networks should remove any network that was attached to a
NIC and is no longer attached to any NIC.
Change-Id: Ie0f987d5e03353726601f026bb2352f917cadaa2
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
2 files changed, 14 insertions(+), 18 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4712
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0f987d5e03353726601f026bb2352f917cadaa2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Add unmanaged networks to Setup Networks
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add unmanaged networks to Setup Networks
......................................................................
core: Add unmanaged networks to Setup Networks
SetupNetworksHelper should keep a list of unmanaged networks, so that
we later know how to treat them (next patch).
Also there is no need to fail if the network is unmanaged and stays on
same nic, no need to raise a violation.
Change-Id: Ifaf9018a49fb09e9c5380f615f248bdcb30c1773
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
2 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4711
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifaf9018a49fb09e9c5380f615f248bdcb30c1773
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: userportal, webadmin: ISO/Floppy list query replacement
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal,webadmin: ISO/Floppy list query replacement
......................................................................
userportal,webadmin: ISO/Floppy list query replacement
The patch http://gerrit.ovirt.org/#change,4341 contained
the replacement of the GetAllIsoImagesList/GetAllFloppyImagesList
to GetAllIsoImagesListByStoragePoolId/GetAllIsoImagesListByStoragePoolId
in user portal.
This patch does the same also for web admin.
Change-Id: Idc29b11fdedb27fb0bc6da77907ba3caf9b89bb6
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
9 files changed, 101 insertions(+), 281 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc29b11fdedb27fb0bc6da77907ba3caf9b89bb6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: userportal: When VM Pool and VM has same name, UP freezes (#...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: When VM Pool and VM has same name, UP freezes (#824805)
......................................................................
userportal: When VM Pool and VM has same name, UP freezes (#824805)
https://bugzilla.redhat.com/824805
The problem was in the org.ovirt.engine.ui.uicommonweb.Linq
class in the Sort method called from
the UserPortalListModel.OnVmAndPoolLoad(). This sort method
can not deal with the situation that two values are equal and
causes infinite loop.
Solved by changing it's implementation to call Collections.sort()
Change-Id: Ie9cbb4e0fcc66af591ce33fc617398d8c9483b36
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
1 file changed, 2 insertions(+), 17 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4754
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9cbb4e0fcc66af591ce33fc617398d8c9483b36
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: userportal: SpiceUsbAutoShare configuration is ignored (#767...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: SpiceUsbAutoShare configuration is ignored (#767081)
......................................................................
userportal: SpiceUsbAutoShare configuration is ignored (#767081)
https://bugzilla.redhat.com/767081
While "SpiceUsbAutoShare" is set to true in vdc_options, the
Auto-Share USB checkbox in the user portal is not checked by default.
The problem was, that the SpiceUsbAutoShare was completly ignored.
Solved by adding the reading of this value to the
Configurator.updateSpiceUsbAutoShare() method which is called from the
constructor of SpiceConsoleModel via of the Configurator.Configure().
In most cases this value will be read from the cache, but for the
first time it will really reach out to the DB and it can take a
while. That is the reason, why the ConsolePopupPresenterWidget
listens to UsbAutoShareChangedEvent and re-renders the popup
if such an event arrives.
Change-Id: Iaf72cb10aeaf0c7bafca17ed91ac0fd330501d80
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/console/ConsolePopupPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java
8 files changed, 87 insertions(+), 26 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4653
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf72cb10aeaf0c7bafca17ed91ac0fd330501d80
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: UnPowerMock GetVmTemplatesByImageGuidQueryTest
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: UnPowerMock GetVmTemplatesByImageGuidQueryTest
......................................................................
core: UnPowerMock GetVmTemplatesByImageGuidQueryTest
Removed PowerMock dependency from GetVmTemplatesByImageGuidQuery.
In order to achieve this improvement a minor refactor was performed in
GetVmTemplatesByImageGuidQuery to expose updateDisksFromDb(VmTemplate).
Change-Id: I34befd85f6bc863af680bdfa0d08666df7cc8a9e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByImageGuidQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmTemplatesByImageGuidQueryTest.java
2 files changed, 10 insertions(+), 12 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4779
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34befd85f6bc863af680bdfa0d08666df7cc8a9e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: UnPowerMock GetAllDisksByVmIdQueryTest
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: UnPowerMock GetAllDisksByVmIdQueryTest
......................................................................
core: UnPowerMock GetAllDisksByVmIdQueryTest
Removed PowerMock dependency from GetAllDisksByVmIdQueryTest and
replaced it with spying the query.
In order to achieve this improvemnt a minor refactor was requred in
GetAllDisksByVmIdQuery to expose the getAllImageSnapshots(DiskImage)
method.
Change-Id: Ib1adfb92d3b7f88aa7527faa9d2572bb65340c73
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQueryTest.java
2 files changed, 12 insertions(+), 17 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4778
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1adfb92d3b7f88aa7527faa9d2572bb65340c73
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months