June 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: engine: Avoid PM/storage alerts for GlusterOnly clusters

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Avoid PM/storage alerts for GlusterOnly clusters ...................................................................... engine: Avoid PM/storage alerts for GlusterOnly clusters https://bugzilla.redhat.com/829842 https://bugzilla.redhat.com/830820 Bugs: - Activation of server triggers "Failed to connect host to storage servers" event - Power Management related events/alerts should be removed This was happening because various class level boolean variables indicating errors related to storage pool and fencing are set to false by default, and trigger corresponding audit logs/ events when getAuditLogTypeValue() is called. This should not happen if the host belongs to a cluster that does not support virtualization e.g. gluster cluster. Also modified VdsCommand to generate the power management alert only when virt service is enabled on the cluster. Change-Id: I22d93df0cf6b2594d7eabf972c038baf893eccdf Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22d93df0cf6b2594d7eabf972c038baf893eccdf Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: disks tab - disable template disk removal

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disks tab - disable template disk removal ...................................................................... webadmin: disks tab - disable template disk removal Disk template disk removal from disks main tab Change-Id: I30607571953ac7faa1e53f4662eec5b567ff4725 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30607571953ac7faa1e53f4662eec5b567ff4725 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: IscsiStorageView tabs style modifications

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: IscsiStorageView tabs style modifications ...................................................................... webadmin: IscsiStorageView tabs style modifications https://bugzilla.redhat.com/833380 Fixed tabs style in IscsiStorageView Change-Id: I34387d610e77df8ca0dff2f0d41fb6d3eb273225 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34387d610e77df8ca0dff2f0d41fb6d3eb273225 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-dwh[master]: Remove trove, jboss-serialization, and xml-apis

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: Remove trove, jboss-serialization, and xml-apis ...................................................................... Remove trove, jboss-serialization, and xml-apis Change-Id: I8396fc0e132d0c0b34481b608c76b1112cf0f107 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M data-warehouse/history_etl/etl_sources/advancedPersistentLookupLib/pom.xml M data-warehouse/history_etl/etl_sources/advancedPersistentLookupLib/src/main/java/org/talend/designer/components/lookup/persistent/AbstractOrderedBeanLookup.java M data-warehouse/history_etl/etl_sources/advancedPersistentLookupLib/src/main/java/org/talend/designer/components/lookup/persistent/PersistentLookupManager.java M data-warehouse/history_etl/etl_sources/advancedPersistentLookupLib/src/main/java/org/talend/designer/components/lookup/persistent/PersistentRowSorterIterator.java M data-warehouse/history_etl/etl_sources/advancedPersistentLookupLib/src/main/java/org/talend/designer/components/lookup/persistent/PersistentSortedLookupManager.java M data-warehouse/history_etl/etl_sources/packaging/pom.xml M data-warehouse/history_etl/history_service/history_service.sh M manifest/ovirt-engine-dwh-manifest.csv M packaging/ovirt-engine-dwh.spec.in M pom.xml 10 files changed, 15 insertions(+), 166 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8396fc0e132d0c0b34481b608c76b1112cf0f107 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core+ui: allow vm/template/pool/disk name to contain period

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core+ui: allow vm/template/pool/disk name to contain period ...................................................................... core+ui: allow vm/template/pool/disk name to contain period This patch allows the name of vm/disk/pool/template to contain dots. Change-Id: I17dc34fa4ed63604473bd53a7debf2ab4f68df84 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 30 insertions(+), 40 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17dc34fa4ed63604473bd53a7debf2ab4f68df84 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-dwh[master]: etl: fixed regressions due to major version change

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: etl: fixed regressions due to major version change ...................................................................... etl: fixed regressions due to major version change Change-Id: I3fe7e8fa53cd8a947d48b9a91a2a3a4eb2b4191c Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/etl_sources/packaging/pom.xml M data-warehouse/history_etl/history_service/history_service.sh M data-warehouse/history_etl/history_service/ovirt-engine-dwhd M data-warehouse/historydbscripts_postgres/create_reports_views.sql 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fe7e8fa53cd8a947d48b9a91a2a3a4eb2b4191c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core:Validate attach disk to contained VM (#833077)

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Validate attach disk to contained VM (#833077) ...................................................................... core:Validate attach disk to contained VM (#833077) https://bugzilla.redhat.com/833077 Fix validation for attaching disk to the same VM. Shareable disk can not be attached to the same VM (same for regular disk). Change-Id: Ia653df7c843630f0adb91cb032cf4e1eb952f085 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia653df7c843630f0adb91cb032cf4e1eb952f085 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Remove trailing comma from network names list

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove trailing comma from network names list ...................................................................... core: Remove trailing comma from network names list The patch removes the trailing comma from the list of network names. Change-Id: I29014d216a65c0a63bd256a8d19168604cc55d1c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 1 file changed, 14 insertions(+), 19 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29014d216a65c0a63bd256a8d19168604cc55d1c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Network is created as bridge-less (#833028)

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Network is created as bridge-less (#833028) ...................................................................... core: Network is created as bridge-less (#833028) https://bugzilla.redhat.com/833028 When network is being created over bond, no value is being set for the vm network attribue of the AddNetwork command which causes the network to be created as bridge-less. The patch uses a c'tor of the AddNetwork command which is capable to get the network entity and set its attributes properly. Change-Id: Id52d9d618603cd64c5d19650f6437d9d92c9a75e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddBondCommand.java 1 file changed, 22 insertions(+), 23 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id52d9d618603cd64c5d19650f6437d9d92c9a75e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Replace StringHelper with StringUtils

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Replace StringHelper with StringUtils ...................................................................... core: Replace StringHelper with StringUtils The patch replaces usage of StringHelper with StringUtils. Change-Id: I681302bbd982cf7a9de766c477cb76565a156df6 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddBondCommand.java 1 file changed, 17 insertions(+), 9 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I681302bbd982cf7a9de766c477cb76565a156df6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

11 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits June 2012