Change in ovirt-engine-cli[master]: cli: cli does not support 3+ deep collections/resources #827...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: cli does not support 3+ deep collections/resources #827845
......................................................................
cli: cli does not support 3+ deep collections/resources #827845
https://bugzilla.redhat.com/show_bug.cgi?id=827845
Change-Id: I19caf851824aeefca2a9ace72b8df67ebd9a20f3
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/command/command.py
M src/ovirtcli/shell/cmdshell.py
2 files changed, 39 insertions(+), 21 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19caf851824aeefca2a9ace72b8df67ebd9a20f3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine-cli[master]: cli: refactor /help/ to support parameters overload
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: refactor /help/ to support parameters overload
......................................................................
cli: refactor /help/ to support parameters overload
for instance:
...
* role (contexts: [[], ['group'], ['user']])
...
i.e supported overloads are:
- delete role X
- delete role X --group A
- delete role X --user B
Change-Id: I2ecd14bfc56e0ea4bf4fbbae370142fa67a94013
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/cli/command/command.py
M src/ovirtcli/command/command.py
M src/ovirtcli/utils/methodhelper.py
M src/ovirtcli/utils/typehelper.py
4 files changed, 87 insertions(+), 28 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ecd14bfc56e0ea4bf4fbbae370142fa67a94013
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: Gluster volume access control list validation added
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Gluster volume access control list validation added
......................................................................
restapi: Gluster volume access control list validation added
A new validation is added to check the presence of access_control_list and
auth.allow option. Either both of them should have the same value or only
one of them should be present. A validation error will be thrown if the request
doesn't satisfy the above checks.
Change-Id: I1a6ea7e44346b98d2c265bf695b782fe245da2fc
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/Messages.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/resources/org/ovirt/engine/api/restapi/logging/Messages.properties
3 files changed, 43 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a6ea7e44346b98d2c265bf695b782fe245da2fc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: \from\ url parameter treated as query parameter
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: \from\ url parameter treated as query parameter
......................................................................
restapi: \from\ url parameter treated as query parameter
Change-Id: I6964abb525276bfb31ecfe4fb24990d23528abe6
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
1 file changed, 4 insertions(+), 6 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6964abb525276bfb31ecfe4fb24990d23528abe6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: Unable to reach /api/clusters/<id>/networks/<id> . ...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Unable to reach /api/clusters/<id>/networks/<id> . receive ERROR 405
......................................................................
restapi: Unable to reach /api/clusters/<id>/networks/<id> . receive ERROR 405
Change-Id: I36345a08a4e939964be73ee7c44aea03e42a6a94
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedNetworkResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResource.java
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36345a08a4e939964be73ee7c44aea03e42a6a94
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: text: change the term presented to user from ip tables to ho...
by ecohen@redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: text: change the term presented to user from ip tables to host firewall
......................................................................
text: change the term presented to user from ip tables to host firewall
Change-Id: I96ec9d86dadc711963f86484dea3a82c24d084fc
Signed-off-by: Itamar Heim <iheim(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96ec9d86dadc711963f86484dea3a82c24d084fc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: userportal: Fixed Floppy & CD-ROM lists on Run once dialog.
by vszocs@redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: Fixed Floppy & CD-ROM lists on Run once dialog.
......................................................................
userportal: Fixed Floppy & CD-ROM lists on Run once dialog.
Fixed Floppy & CD-ROM lists on Run once dialog.
Change-Id: Ib49e875d5e16450e54f8448f911767e6433571e6
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib49e875d5e16450e54f8448f911767e6433571e6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: Use JBoss JACC artifact
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Use JBoss JACC artifact
......................................................................
restapi: Use JBoss JACC artifact
The artifact that we currently use is not available in the Fedora
17 repositories.
Change-Id: I397a9dfb5cc79bfc141013cd3b1153bc1fa365ea
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Juan Hernandez: Verified
--
To view, visit http://gerrit.ovirt.org/4812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I397a9dfb5cc79bfc141013cd3b1153bc1fa365ea
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: setup networks- check conn and save config
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: setup networks- check conn and save config
......................................................................
webadmin: setup networks- check conn and save config
The commit includes:
1. Adding to the setup netwroks form-
- Check Connectivity checkbox
(renamed to- Rollback changes if Host looses
Connectivity to the Engine).
- Save network configuration checkbox
2. Removing save network configuration button from
host->interfaces panel if the dc vertion is 3.1
or uppper.
Change-Id: I270f49501ba2dc7854d1779ef93e22aff7687079
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java
8 files changed, 114 insertions(+), 22 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I270f49501ba2dc7854d1779ef93e22aff7687079
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Fix vNIC count parameter for add VM
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Fix vNIC count parameter for add VM
......................................................................
core: Fix vNIC count parameter for add VM
The parameter is the number of vNICs about to be allocated, so changed
it's name & the callers now send number of NICs to allocate (according
to their amount in the template).
Change-Id: I4285920adb02a7e15fe0ed1410359eb9acacbed3
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java
5 files changed, 30 insertions(+), 13 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5466
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4285920adb02a7e15fe0ed1410359eb9acacbed3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 7 months