June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Minor cleanup on disk moving commands
by derez＠redhat.com 17 Jun '12

17 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Minor cleanup on disk moving commands ...................................................................... core: Minor cleanup on disk moving commands 1. Solved some hiding issues (detected by Eclipse IDE) 2. Replaced DbFacade.getInstance() with getDbFacade() 3. Replaced Backend.getInstance().runVdsCommand() with runVdsCommand() Change-Id: If554729a606c64f4a65393b875073556fea962b3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java 2 files changed, 67 insertions(+), 70 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If554729a606c64f4a65393b875073556fea962b3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: changed setup to use the engine service
by ydary＠redhat.com 17 Jun '12

17 Jun '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed setup to use the engine service ...................................................................... packaging: changed setup to use the engine service Change-Id: I8431e06f11f46dcb0284dcb82cfe1adba7a32931 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/common_utils.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8431e06f11f46dcb0284dcb82cfe1adba7a32931 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Re-enable AddDiskToVmCommandTest
by derez＠redhat.com 17 Jun '12

17 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Re-enable AddDiskToVmCommandTest ...................................................................... core: Re-enable AddDiskToVmCommandTest This test was marked with @Ignore a while ago. This patch enables the test again, and removes the annotation. In order to achieve this, some subtle refactoring was performed on AddDiskCommand, AbstractDiskVmCommand and CommandBase (extracting methods to hide external resources), and PowerMockito was removed from the test. A single test which tests the validation of the disk type passed to the command was removed, since this functionallity is no longer supported. Change-Id: I3b061a6f381f4e19d6666b24140b0583a244a63d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java 4 files changed, 137 insertions(+), 164 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b061a6f381f4e19d6666b24140b0583a244a63d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-dwh[master]: etl: changed version to 3.1
by ydary＠redhat.com 17 Jun '12

17 Jun '12

Yaniv Dary has submitted this change and it was merged. Change subject: etl: changed version to 3.1 ...................................................................... etl: changed version to 3.1 Change-Id: I3dff7c308d2156d93235e95ae76e2546da0bf2bb Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M Makefile D data-warehouse/history_etl/context_files/ovirt_engine_dwh/aggregationtodaily_3_0/contexts/Default.properties C data-warehouse/history_etl/context_files/ovirt_engine_dwh/aggregationtodaily_3_1/contexts/Default.properties R data-warehouse/history_etl/context_files/ovirt_engine_dwh/aggregationtohourly_3_1/contexts/Default.properties R data-warehouse/history_etl/context_files/ovirt_engine_dwh/configurationsync_3_1/contexts/Default.properties R data-warehouse/history_etl/context_files/ovirt_engine_dwh/dailytimekeepingjob_3_1/contexts/Default.properties R data-warehouse/history_etl/context_files/ovirt_engine_dwh/deletetimekeepingjob_3_1/contexts/Default.properties R data-warehouse/history_etl/context_files/ovirt_engine_dwh/historydelete_3_1/contexts/Default.properties R data-warehouse/history_etl/context_files/ovirt_engine_dwh/historyetl_3_1/contexts/Default.properties R data-warehouse/history_etl/context_files/ovirt_engine_dwh/hostconfigcheck_3_1/contexts/Default.properties D data-warehouse/history_etl/context_files/ovirt_engine_dwh/hourlytimekeepingjob_3_0/contexts/Default.properties C data-warehouse/history_etl/context_files/ovirt_engine_dwh/hourlytimekeepingjob_3_1/contexts/Default.properties R data-warehouse/history_etl/context_files/ovirt_engine_dwh/minimalversioncheck_3_1/contexts/Default.properties R data-warehouse/history_etl/context_files/ovirt_engine_dwh/parallelrun_3_1/contexts/Default.properties C data-warehouse/history_etl/context_files/ovirt_engine_dwh/samplerunjobs_3_1/contexts/Default.properties R data-warehouse/history_etl/context_files/ovirt_engine_dwh/sampletimekeepingjob_3_1/contexts/Default.properties D data-warehouse/history_etl/context_files/ovirt_engine_dwh/statisticssync_3_0/contexts/Default.properties R data-warehouse/history_etl/context_files/ovirt_engine_dwh/statisticssync_3_1/contexts/Default.properties R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtodaily_3_1/AggregationToDaily.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtohourly_3_1/AggregationToHourly.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/configurationsync_3_1/ConfigurationSync.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/dailytimekeepingjob_3_1/DailyTimeKeepingJob.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/deletetimekeepingjob_3_1/DeleteTimeKeepingJob.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/historydelete_3_1/HistoryDelete.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/historyetl_3_1/HistoryETL.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/hostconfigcheck_3_1/HostConfigCheck.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/hourlytimekeepingjob_3_1/HourlyTimeKeepingJob.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/minimalversioncheck_3_1/MinimalVersionCheck.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/parallelrun_3_1/ParallelRun.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/samplerunjobs_3_1/SampleRunJobs.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_3_1/SampleTimeKeepingJob.java R data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/statisticssync_3_1/StatisticsSync.java M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/DataOperation.java M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/Mathematical.java M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/Numeric.java M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/Relational.java M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/StringHandling.java M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/TalendDataGenerator.java M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/TalendDate.java M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/TalendString.java A data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/DBDateParser.java M data-warehouse/history_etl/history_service/history_service.sh A data-warehouse/history_etl/tos_project/code/routines/RoutineHistoryETL_3.1.item A data-warehouse/history_etl/tos_project/code/routines/RoutineHistoryETL_3.1.properties R data-warehouse/history_etl/tos_project/context/connectionJDBC_3.1.item R data-warehouse/history_etl/tos_project/context/connectionJDBC_3.1.properties R data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.1.item R data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.1.properties R data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.1.item R data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.1.properties R data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.1.item R data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.1.properties R data-warehouse/history_etl/tos_project/process/DailyTimeKeepingJob_3.1.item R data-warehouse/history_etl/tos_project/process/DailyTimeKeepingJob_3.1.properties R data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.1.item R data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.1.properties R data-warehouse/history_etl/tos_project/process/HistoryDelete_3.1.item R data-warehouse/history_etl/tos_project/process/HistoryDelete_3.1.properties R data-warehouse/history_etl/tos_project/process/HistoryETL_3.1.item R data-warehouse/history_etl/tos_project/process/HistoryETL_3.1.properties R data-warehouse/history_etl/tos_project/process/HostConfigCheck_3.1.item R data-warehouse/history_etl/tos_project/process/HostConfigCheck_3.1.properties R data-warehouse/history_etl/tos_project/process/HourlyTimeKeepingJob_3.1.item R data-warehouse/history_etl/tos_project/process/HourlyTimeKeepingJob_3.1.properties R data-warehouse/history_etl/tos_project/process/MinimalVersionCheck_3.1.item R data-warehouse/history_etl/tos_project/process/MinimalVersionCheck_3.1.properties R data-warehouse/history_etl/tos_project/process/ParallelRun_3.1.item R data-warehouse/history_etl/tos_project/process/ParallelRun_3.1.properties R data-warehouse/history_etl/tos_project/process/SampleRunJobs_3.1.item R data-warehouse/history_etl/tos_project/process/SampleRunJobs_3.1.properties R data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.1.item R data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.1.properties R data-warehouse/history_etl/tos_project/process/StatisticsSync_3.1.item R data-warehouse/history_etl/tos_project/process/StatisticsSync_3.1.properties M data-warehouse/history_etl/tos_project/talend.project M data-warehouse/historydbscripts_postgres/dbcustomfunctions.sh M pom.xml 77 files changed, 2,099 insertions(+), 1,579 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dff7c308d2156d93235e95ae76e2546da0bf2bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: divided the views into seperate files.
by ydary＠redhat.com 17 Jun '12

17 Jun '12

Yaniv Dary has submitted this change and it was merged. Change subject: history: divided the views into seperate files. ...................................................................... history: divided the views into seperate files. Views are now versioned into seperate files and ovirt engine report views are not in the same file. Change-Id: Ic38620bbd6b6fa37c34e00ef125bde97e550c94d Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A data-warehouse/historydbscripts_postgres/create_reports_views.sql D data-warehouse/historydbscripts_postgres/create_views.sql A data-warehouse/historydbscripts_postgres/create_views_3_0.sql A data-warehouse/historydbscripts_postgres/create_views_3_1.sql M data-warehouse/historydbscripts_postgres/dbcustomfunctions.sh 5 files changed, 1,669 insertions(+), 1,668 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic38620bbd6b6fa37c34e00ef125bde97e550c94d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding column filtering white list to fixtures
by emesika＠redhat.com 17 Jun '12

17 Jun '12

Eli Mesika has submitted this change and it was merged. Change subject: core: adding column filtering white list to fixtures ...................................................................... core: adding column filtering white list to fixtures Adding vds table column filtering white list to fixtures file Change-Id: Ide31caa53e295ca4afbe708930fa3499be4ae20a Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/test/resources/fixtures.xml 1 file changed, 332 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide31caa53e295ca4afbe708930fa3499be4ae20a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:add support for engine case-insensitive search
by emesika＠redhat.com 17 Jun '12

17 Jun '12

Eli Mesika has submitted this change and it was merged. Change subject: core:add support for engine case-insensitive search ...................................................................... core:add support for engine case-insensitive search Bug origin is the caching mechanism we are using to store queries. Currently the cash is a Map with a string concatenation of the query text and max results as the key and the SQL generated as the value. The key should be enhanced to include the Case Sensitive flag value such that 2 identical queries with different values for that flag will be stored in separate cash entries Change-Id: I129a971e568ea5773a26ef32283ecb16b9252390 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I129a971e568ea5773a26ef32283ecb16b9252390 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix VmNetworkInterfaceValidationTest
by mkolesni＠redhat.com 17 Jun '12

17 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Fix VmNetworkInterfaceValidationTest ...................................................................... core: Fix VmNetworkInterfaceValidationTest Test for short MAC was failing intermittently due to wrong random calculation which sometimes would not shorten the MAC address. Change-Id: Ieade6d0f5b07bf3d282de49a6c16e01bc9bd400b Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterfaceValidationTest.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieade6d0f5b07bf3d282de49a6c16e01bc9bd400b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Casting to Disk in GuideMe AddDisk
by derez＠redhat.com 17 Jun '12

17 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Casting to Disk in GuideMe AddDisk ...................................................................... webadmin: Casting to Disk in GuideMe AddDisk GetVmDiskList - Casting to Disk instead of DiskImage (fixing ClassCastExepction for LunDisk). Change-Id: I3bc02bdb07d498cd41441ec49480b4865e202e39 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bc02bdb07d498cd41441ec49480b4865e202e39 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing remove of VM with direct lun disk
by derez＠redhat.com 17 Jun '12

17 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: engine: Fixing remove of VM with direct lun disk ...................................................................... engine: Fixing remove of VM with direct lun disk A following patch will allow to remove a vm which has a direct lun disks Change-Id: I8267b48adbcb6aa9f7a56ae4b1635c848b726084 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 3 files changed, 45 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Michael Kublin: Verified -- To view, visit http://gerrit.ovirt.org/5396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8267b48adbcb6aa9f7a56ae4b1635c848b726084 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0