Change in ovirt-engine[master]: core: Fix slave changes detection
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Fix slave changes detection
......................................................................
core: Fix slave changes detection
Old detection method detected just added slaves (bond grew).
Added detection for removed slaves also (bond shrank).
Tests were added to make sure the detection works.
Change-Id: I357824cc2c251ffaf22bdd0164a0a62b79bdf330
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
2 files changed, 55 insertions(+), 8 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5307
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I357824cc2c251ffaf22bdd0164a0a62b79bdf330
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Change removed bonds to strings
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Change removed bonds to strings
......................................................................
core: Change removed bonds to strings
No need to hold the whole interface, hold just the names of the bonds
that got removed.
A set was used since each bond name appears on more than one past slave
so this collection type is better for the job. In the future it will be
used to check if a bond name is contained within..
Change-Id: Id2684e962d2e99dcc8e1c609fdeef079fc290331
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java
6 files changed, 22 insertions(+), 19 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5306
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2684e962d2e99dcc8e1c609fdeef079fc290331
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: SetupNetworksHelper handle unmanaged VLAN
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: SetupNetworksHelper handle unmanaged VLAN
......................................................................
core: SetupNetworksHelper handle unmanaged VLAN
Code didn't handle a case of unmanaged network on VLAN that didn't
exist before, so fixed and added a test to make sure it is handled.
The unmanagedNetworks list is not necessary anymore.
Change-Id: I7d58191db622989c8de66cbd1fa1ac74fe0946bf
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
2 files changed, 26 insertions(+), 5 deletions(-)
Approvals:
Mike Kolesnik: Verified
Livnat Peer: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d58191db622989c8de66cbd1fa1ac74fe0946bf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Add test for bond with no slaves
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add test for bond with no slaves
......................................................................
core: Add test for bond with no slaves
Bond with no slaves should not be sent, just as bond with only 1 slave,
so added a test to make sure this is being validated.
Change-Id: I3cd01dbb69ced63bd6fbdb803b812423100a0f58
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cd01dbb69ced63bd6fbdb803b812423100a0f58
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Overhaul SetupNetworksHelper
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Overhaul SetupNetworksHelper
......................................................................
core: Overhaul SetupNetworksHelper
Now that tests are in order, we can rewrite SetupNetworksHelper a bit:
1. Changed fully to class fields since it looks cleaner and makes more
sense now that tests don't rely on inner methods.
2. Some methods which were used only once got removed.
3. validations were fixed to correctly address cases where
iface/bond/network were already processed.
Change-Id: I96266c56b0d7f2d0c6aacb45e4a39087f94258f1
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
2 files changed, 94 insertions(+), 126 deletions(-)
Approvals:
Mike Kolesnik: Verified
Livnat Peer: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5234
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96266c56b0d7f2d0c6aacb45e4a39087f94258f1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: SetupNetworksHelperTest rework
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: SetupNetworksHelperTest rework
......................................................................
core: SetupNetworksHelperTest rework
1. Added tests for bonds & networks basic changes & validations.
2. Got rid of tests that check internal logic since it is not supposed
to be exposed, and the tests should test the public methods only.
3. Some tests were refactored/rewritten to keep it DRY.
Change-Id: I68b69e748d216d119c0ac419358eb4b6c42d7ffe
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
1 file changed, 410 insertions(+), 329 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5233
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68b69e748d216d119c0ac419358eb4b6c42d7ffe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: adding login permissions
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: adding login permissions
......................................................................
core: adding login permissions
This patch adds the login action group, relevant to LoginUserCommand and
LoginAdminCommand.
In this patch:
1. Adding the action group.
2. Adding a "bottom" object type + object (used for the permissions
check, as every object is the parent of bottom). If there is an object
with permissions for a specific user, and the role contains the login
action group, then the user can login to the system. Otherwise, the user
won't be able to login.
3. Upgrade: The login action group will be added to every predefined role (except for the TemplateUser and the
QuotaUser roles).
4. Common Stored procedures - added a new function that adds an action
group to all the roles, except ones we would like to filter.
5. UI changes - add the new action group under system configuration in
the configuration menu. Also, mark the login action group as a user
action group in the UI.
Change-Id: Ib86ec99739ff73fa500a9de6c056b324c353929c
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/dbscripts/common_sp.sql
M backend/manager/dbscripts/create_functions.sql
M backend/manager/dbscripts/multi_level_administration_sp.sql
A backend/manager/dbscripts/upgrade/03_01_1230_add_login_action_group.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcObjectType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
19 files changed, 178 insertions(+), 23 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5251
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib86ec99739ff73fa500a9de6c056b324c353929c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Minor cleanup in GetDeviceListVDSCommandTest
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Minor cleanup in GetDeviceListVDSCommandTest
......................................................................
core: Minor cleanup in GetDeviceListVDSCommandTest
Made a private helper method static.
Change-Id: Ie3c1084098ddaea10bbe7b2a1ec814fd7f69ad3f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5315
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3c1084098ddaea10bbe7b2a1ec814fd7f69ad3f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: validation added for volume brick directory(#82966...
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: validation added for volume brick directory(#829664)
......................................................................
webadmin: validation added for volume brick directory(#829664)
https://bugzilla.redhat.com/829664
Following validations are added.
1. Brick directory should start with /
2. Lenth should be at least 2
3. Should not have / as 2n'd charactor
4. Should not have any spaces in between
Change-Id: I766ce81d5dddd6fe0bd96abc6ec9efb3e81e72e8
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
2 files changed, 37 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5313
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I766ce81d5dddd6fe0bd96abc6ec9efb3e81e72e8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: disabling host address in host dialog(#829844)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: disabling host address in host dialog(#829844)
......................................................................
webadmin: disabling host address in host dialog(#829844)
https://bugzilla.redhat.com/829844
Host address cannot be changed once the host is added
except the host status is InstallFailed. The host address
field in host dialof greyed out in host edit.
Change-Id: I42c92abc42e2827f8cfa718b6dfe619e0de3e005
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5309
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42c92abc42e2827f8cfa718b6dfe619e0de3e005
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months