Change in ovirt-engine[master]: core: removing DiskInfoList from parameters (#834527)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: removing DiskInfoList from parameters (#834527)
......................................................................
core: removing DiskInfoList from parameters (#834527)
https://bugzilla.redhat.com/834527
in MoveOrCopyParameters the disks list is sent twice,
in DiskInfoList and in VM.DiskMap.
removing DiskInfoList, and moving all its references to Vm.DiskMap.
this change solves a bug which in REST without supplying the disksList in
import VM with collapse Snapshots, the command fails.
Change-Id: I04bf874baec89c7e2b229c1299949f1044e22c61
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
4 files changed, 19 insertions(+), 39 deletions(-)
Approvals:
Michael Kublin: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/5744
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04bf874baec89c7e2b229c1299949f1044e22c61
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: core: add SASL_QOP to engine-config properties file
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: add SASL_QOP to engine-config properties file
......................................................................
core: add SASL_QOP to engine-config properties file
This patch adds the SASL_QOP config option to the engine config
properties file, so that it could be changed using engine-config, and
not only manually.
Change-Id: I1c3251713a11a8f697621eb5ca818553cc7b791a
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/tools/engine-config/src/main/resources/engine-config.properties
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c3251713a11a8f697621eb5ca818553cc7b791a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: webadmin: Design fixes of SetupNetworks form
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Design fixes of SetupNetworks form
......................................................................
webadmin: Design fixes of SetupNetworks form
https://bugzilla.redhat.com/823881
Design fixes of SetupNetworks form- adding scrolls,
changing colors, etc...
Change-Id: Ib2c27baa3fbfdb1c891f6f15d3d921247766fffd
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/edit_hover.png
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/edit_mousedown.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/nic_edit.png
9 files changed, 111 insertions(+), 33 deletions(-)
Approvals:
Alona Kaplan: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2c27baa3fbfdb1c891f6f15d3d921247766fffd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: core: changed wrong error message when editing a shared disk...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: changed wrong error message when editing a shared disk (#835092)
......................................................................
core: changed wrong error message when editing a shared disk (#835092)
https://bugzilla.redhat.com/835092
when editing a shared disk on a vm with one of the other vm's being up
a wrong message was presented to the user.
Change-Id: I58908db8842979437085fde49ad967cbdc6180e0
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5721
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58908db8842979437085fde49ad967cbdc6180e0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: core: Remove unnecessary checks in canRemoveDiskBasedOnImage...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Remove unnecessary checks in canRemoveDiskBasedOnImageStorageCheck()
......................................................................
core: Remove unnecessary checks in canRemoveDiskBasedOnImageStorageCheck()
There is no need to check for VmEntityType.TEMPLATE again.
Removed check for retValue, as it is the first time and it will be true.
Change-Id: Ida64918741d5b57ba39e10c103e5ae0ceb606909
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
1 file changed, 2 insertions(+), 5 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida64918741d5b57ba39e10c103e5ae0ceb606909
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
11 years, 9 months
Change in ovirt-engine[master]: core: Performance improvement
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Performance improvement
......................................................................
core: Performance improvement
Setting check for image validity run only once
No need to check it each time, will not change anything
Change-Id: I00f269a14d87121fc2a6b5d6c5f43c83b7a87f0a
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00f269a14d87121fc2a6b5d6c5f43c83b7a87f0a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: core: Removing all code and reference to time leased pool
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Removing all code and reference to time leased pool
......................................................................
core: Removing all code and reference to time leased pool
The following functionality is not required anymore, removed
Change-Id: Ia0d799bd587dcf4837b5d04026457f0b9d0f7ff5
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
A backend/manager/dbscripts/upgrade/03_01_1260_remove_time_lease_vm_pool_map_table.sql
M backend/manager/dbscripts/vm_pools_sp.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachAdGroupTimeLeasedPoolCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToTimeLeasedPoolCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachAdGroupFromTimeLeasedPoolCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromTimeLeasedPoolCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TimeLeasedVmPoolManager.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateAdGroupTimeLeasedPoolCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserToTimeLeasedPoolCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ADElementTimeLeasedVmPoolParametersBase.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachAdGroupTimeLeasedPoolCommandParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachUserToTimeLeasedPoolParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DetachAdGroupFromTimeLeasedPoolParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DetachUserFromTimeLeasedPoolParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateUserVmPoolParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/time_lease_vm_pool_map.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/time_lease_vm_pool_map_id.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAOHibernateImpl.java
D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/vmpools/TimeLeaseVmPoolMapDAOHibernateImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmPoolDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
27 files changed, 16 insertions(+), 1,443 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5736
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0d799bd587dcf4837b5d04026457f0b9d0f7ff5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: core: fix canDoAction message variable format
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: fix canDoAction message variable format
......................................................................
core: fix canDoAction message variable format
Error messages of invalid custom properties where not interpolated
because mising ${} arround the variable.
Change-Id: I228b25a7ff4dac9ad690c47160d033eabd3e0df6
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I228b25a7ff4dac9ad690c47160d033eabd3e0df6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: engine: Allow to iterate over remaining ldap servers on Null...
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: engine: Allow to iterate over remaining ldap servers on NullPointerException.
......................................................................
engine: Allow to iterate over remaining ldap servers on NullPointerException.
When engine-manage-domain is run to add ldap server, current code finds all
ldap servers in the domain and then finds guid on each. In some cases it
gets NullPointerException because the "uniqueId" is not found. In those cases
we currently go to the default "Exception" and break out of ldap server loop.
In my view, we should log/print the message and continue to serve the loop.
This patch is based on http://gerrit.ovirt.org/#/c/4439/2. Since now we have
support for ITDS, the original patch has been updated.
Change-Id: Iaf89ef5d423cde2e420d6196b38506a23416abb8
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
1 file changed, 23 insertions(+), 14 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5148
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf89ef5d423cde2e420d6196b38506a23416abb8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: core: Fix engine log rotation
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix engine log rotation
......................................................................
core: Fix engine log rotation
Rotation should be set to 10M, not 1M
Acked-by:
Change-Id: I45ad476cb2ccc266740bb9e974babef4cea4cd57
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/conf/standalone.xml
M packaging/fedora/engine-service.xml
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5673
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45ad476cb2ccc266740bb9e974babef4cea4cd57
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months