Change in ovirt-engine[master]: engine: Fix for Replace Gluster Brick test case failure
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Fix for Replace Gluster Brick test case failure
......................................................................
engine: Fix for Replace Gluster Brick test case failure
Change-Id: I74d301bccb1e4f0f1eec45c22f358cfb1e0beaf5
Signed-off-by: Selvasundaram <sesubram(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Selvasundaram: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5253
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74d301bccb1e4f0f1eec45c22f358cfb1e0beaf5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: adding maven step for upgrade script name validation
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: adding maven step for upgrade script name validation
......................................................................
core: adding maven step for upgrade script name validation
This patch adds a pom.xml under dbscripts that uses the maven exec
plugin to execute a bash script that checks for upgrade scripts
duplications.
manager pom.xml was modified to include the new dbscripts module and
compile it as first step to throw the error as soon as possible before
other steps are issued.
Change-Id: I26146122acc0b6dfaaea73b232fa3c42a7baff18
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
A backend/manager/dbscripts/check_for_duplicate_upgrade_scripts.sh
A backend/manager/dbscripts/pom.xml
M backend/manager/pom.xml
3 files changed, 45 insertions(+), 0 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26146122acc0b6dfaaea73b232fa3c42a7baff18
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: display disk provisioned and actual size
by oliel@redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: display disk provisioned and actual size
......................................................................
restapi: display disk provisioned and actual size
Change-Id: I64c1c231e3d5e60ad35bacf8031775a7220fbb32
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java
4 files changed, 44 insertions(+), 6 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64c1c231e3d5e60ad35bacf8031775a7220fbb32
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Handle correct NIC ID from OVF (#827061)
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Handle correct NIC ID from OVF (#827061)
......................................................................
core: Handle correct NIC ID from OVF (#827061)
https://bugzilla.redhat.com/827061
Someone forgot to handle NIC ID correctly, although they changed the
OVF format.
ID was added to NIC in the new OVF format, so need to set new ID only
if the OVF didn't contain ID for the nic.
Overriding the ID always would cause the VM Device for the NIC to be
added but not updated with actual data that was saved in the OVF.
Change-Id: Id842c8b4546e80676f8e8e023e0e66ff9cec5814
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id842c8b4546e80676f8e8e023e0e66ff9cec5814
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: RSDL - Fix meta-data of some collections
by oliel@redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: RSDL - Fix meta-data of some collections
......................................................................
restapi: RSDL - Fix meta-data of some collections
Change-Id: I1fdb132e1ea93ef61b13a75fec11c55cc3045725
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
1 file changed, 14 insertions(+), 14 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4996
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fdb132e1ea93ef61b13a75fec11c55cc3045725
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: common: Introducing groupIds property to VdcUser
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: common: Introducing groupIds property to VdcUser
......................................................................
common: Introducing groupIds property to VdcUser
Introducing the new groupIds property to VdcUser
and IVdcUser (getter, setter and field)
Change-Id: I6db20570d278a56c9ba2798c9f30e291ba53b2ac
Acked-by:
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/IVdcUser.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java
2 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6db20570d278a56c9ba2798c9f30e291ba53b2ac
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Adding new MLA related functions
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Adding new MLA related functions
......................................................................
core: Adding new MLA related functions
This functions provide information on roles
of user when its group IDs are explicitly provided
Change-Id: I9f6e82a6eb615312c2a0d488f09d45d5db1c890e
Acked-By:
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/dbscripts/create_functions.sql
M backend/manager/dbscripts/multi_level_administration_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
3 files changed, 40 insertions(+), 3 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5198
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f6e82a6eb615312c2a0d488f09d45d5db1c890e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Adding new methods at RoleDAO
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Adding new methods at RoleDAO
......................................................................
core: Adding new methods at RoleDAO
These methods reflect the new role stored procedures
Change-Id: Id64f09cef79ac05bd86d5875dff2f0a1d81a94b3
Acked-By:
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAOHibernateImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java
4 files changed, 54 insertions(+), 3 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5199
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id64f09cef79ac05bd86d5875dff2f0a1d81a94b3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Preventing adding unauthorized users
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Preventing adding unauthorized users
......................................................................
core: Preventing adding unauthorized users
As a result of this patch, users that were not
authorized to perform login to webadmin will not
be added to the DB upon the login attempt.
Change-Id: I4a3936b4ce0cd35e916a0ac97b6278908fb8aa1e
Acked-by:
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdminOperationCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandlerTest.java
4 files changed, 23 insertions(+), 16 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5201
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a3936b4ce0cd35e916a0ac97b6278908fb8aa1e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: ui: fix naming to oVirt Engine
by ecohen@redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: ui: fix naming to oVirt Engine
......................................................................
ui: fix naming to oVirt Engine
Change-Id: I5cdb57667ff5d7a8d9e8664e7edb198ba93b8823
Signed-off-by: Itamar Heim <iheim(a)redhat.com>
---
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/common/AboutModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
4 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4481
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cdb57667ff5d7a8d9e8664e7edb198ba93b8823
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
12 years, 7 months