June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: engine-setup-validators - Fix controller declerat...
by oschreib＠redhat.com 26 Jun '12

26 Jun '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-setup-validators - Fix controller decleration ...................................................................... packaging: engine-setup-validators - Fix controller decleration The controller variable in validateIpaAndHttpdStatus was declared inside an if statment, which caused a "referenced before assignment" error. Change-Id: I191cae9a7cfa48f36f3c7d23dae0424b35b8f934 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/fedora/setup/engine_validators.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I191cae9a7cfa48f36f3c7d23dae0424b35b8f934 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixes in timezone values in sysprep
by oourfali＠redhat.com 26 Jun '12

26 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: fixes in timezone values in sysprep ...................................................................... core: fixes in timezone values in sysprep This patch fixes some errors in the timezones in the sysprep files Change-Id: I3be0aec5b6b755d018d3a87d7e937feb84fce3f3 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3be0aec5b6b755d018d3a87d7e937feb84fce3f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: UI: edit cluster set first CPU item when the CPU is null
by shavivi＠redhat.com 26 Jun '12

26 Jun '12

Shahar Havivi has submitted this change and it was merged. Change subject: UI: edit cluster set first CPU item when the CPU is null ...................................................................... UI: edit cluster set first CPU item when the CPU is null Change-Id: I6baaf89af219ef22b1e3f371ff7a342180ce7be9 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6baaf89af219ef22b1e3f371ff7a342180ce7be9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: UI: Add port mirroring action group to configuration manager
by shavivi＠redhat.com 26 Jun '12

26 Jun '12

Shahar Havivi has submitted this change and it was merged. Change subject: UI: Add port mirroring action group to configuration manager ...................................................................... UI: Add port mirroring action group to configuration manager Change-Id: I38e402b7275174595b35bfeee2336209caf771a5 Signed-off-by: Shahar Havivi<shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 12 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38e402b7275174595b35bfeee2336209caf771a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: UI: wrong capitalization of MAC in error message
by shavivi＠redhat.com 26 Jun '12

26 Jun '12

Shahar Havivi has submitted this change and it was merged. Change subject: UI: wrong capitalization of MAC in error message ...................................................................... UI: wrong capitalization of MAC in error message Change-Id: If4a78cf175771fd813d9799ce3323df138bf3064 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4a78cf175771fd813d9799ce3323df138bf3064 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: changed maven version and group to static values
by ydary＠redhat.com 26 Jun '12

26 Jun '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed maven version and group to static values ...................................................................... packaging: changed maven version and group to static values This is because it is not standard to use expressions and maven displays warnings due to this. Change-Id: I147c70341ca40fec0f4bd4f007ec9297fc269804 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M pom.xml M reports/jars/ChartsCustomizers/pom.xml M reports/jars/EngineAuthentication/pom.xml M reports/jars/ReportsLineBarChartTheme/pom.xml M reports/jars/ReportsPieChartTheme/pom.xml M reports/jars/WebadminLineBarChartTheme/pom.xml M reports/jars/pom.xml M reports/pom.xml 8 files changed, 26 insertions(+), 30 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I147c70341ca40fec0f4bd4f007ec9297fc269804 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Correct error string on destroy Storage Domain
by tnisan＠redhat.com 26 Jun '12

26 Jun '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Correct error string on destroy Storage Domain ...................................................................... webadmin: Correct error string on destroy Storage Domain Change-Id: I88482313b574f6d4264b0e73e81dd05ac1ddfb48 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88482313b574f6d4264b0e73e81dd05ac1ddfb48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: List VMs according to user permissions
by asaf＠redhat.com 26 Jun '12

26 Jun '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: restapi: List VMs according to user permissions ...................................................................... restapi: List VMs according to user permissions When filtering is enabled, list VMs according to the standard user permissions By using the standard 'getAllVms' query with filtering enabled. Change-Id: Idd605844b8df428deaf2765cf3e8907a56c639fa Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd605844b8df428deaf2765cf3e8907a56c639fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: VM make template option stucks
by tnisan＠redhat.com 26 Jun '12

26 Jun '12

Tal Nisan has submitted this change and it was merged. Change subject: userportal: VM make template option stucks ...................................................................... userportal: VM make template option stucks Caused from a null pointer exception, the model used the Storage Domain property which is not used anymore, the domain selection in the dialog is for each disk respectively. Aside for that, the disks were all copied to the default Storage Domains and the Storage Domain selection was ignored, this was also fixed Change-Id: I412a60eb41303641a2336da45ac6430efa3b26a0 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I412a60eb41303641a2336da45ac6430efa3b26a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [rmd] ConfigUtilsBase
by lhornyak＠redhat.com 26 Jun '12

26 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: [rmd] ConfigUtilsBase ...................................................................... core: [rmd] ConfigUtilsBase Removed the deprecated Refobject usage from ConfigUtilsBase. Change-Id: I871d292723a5752732e6d1b9aea13d8ac0e9facb Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ConfigUtilsBase.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/DefaultValuesConfigUtil.java 3 files changed, 51 insertions(+), 54 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I871d292723a5752732e6d1b9aea13d8ac0e9facb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0