June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: non admin user api - Filtering vms/vm pools (#78308...
by asaf＠redhat.com 05 Jun '12

05 Jun '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: restapi: non admin user api - Filtering vms/vm pools (#783087) ...................................................................... restapi: non admin user api - Filtering vms/vm pools (#783087) https://bugzilla.redhat.com/783087 - Support for filtering VM(s) when 'filter' header set to true when accessing /api/vms & /api/vms/{id} urls. - Support for filtering VM pool(s) when 'filter' header set to true when accessing /api/vmpools & /api/vmpools/{id} urls. - Added the 'filter' header to the rsdl metadata file in the appropriate names. Change-Id: I8c7d3be5a61efa3c225dcab96e89c87e8e35839b Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java 3 files changed, 20 insertions(+), 9 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c7d3be5a61efa3c225dcab96e89c87e8e35839b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Permission filtering for GetAllVdsGroups.
by asaf＠redhat.com 05 Jun '12

05 Jun '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: core: Permission filtering for GetAllVdsGroups. ...................................................................... core: Permission filtering for GetAllVdsGroups. Change-Id: Ic11ced57afb59ab4629c2e29447703cabe580a8c Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/dbscripts/vds_groups_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVdsGroupsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAOHibernateImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java 7 files changed, 83 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic11ced57afb59ab4629c2e29447703cabe580a8c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix regression in Import VM
by gchaplik＠redhat.com 05 Jun '12

05 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: fix regression in Import VM ...................................................................... core: fix regression in Import VM wrong volume type and format in case of import vm more than once Change-Id: If356f68775873e67099b24c6b88d976daff10361 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If356f68775873e67099b24c6b88d976daff10361 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix use of namespaces in OVF writers
by gchaplik＠redhat.com 05 Jun '12

05 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix use of namespaces in OVF writers ...................................................................... core: Fix use of namespaces in OVF writers Commit 80583b2c4c76f390f87102bf514ec41eca6dd153 introduced some errors in the OVF writers that cause the OVF files to be generated incorrectly. Change-Id: I9e5833a41e85c5c15ae4ee21af83240bbb756875 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e5833a41e85c5c15ae4ee21af83240bbb756875 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename upgrade script
by rgolan＠redhat.com 05 Jun '12

05 Jun '12

Roy Golan has submitted this change and it was merged. Change subject: core: rename upgrade script ...................................................................... core: rename upgrade script Change-Id: I73fe26116fe4b59dc30e73cac14449068c7e1341 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- R backend/manager/dbscripts/upgrade/03_01_1180_remove_and_rename_columns_vm_dynamic.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73fe26116fe4b59dc30e73cac14449068c7e1341 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix for empty cpupinning
by lhornyak＠redhat.com 05 Jun '12

05 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: fix for empty cpupinning ...................................................................... core: fix for empty cpupinning Empty cpupinning is not handled correctly by the backend. Change-Id: I0ae9fe26cd6f16a722297c99743eb392cf084438 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ae9fe26cd6f16a722297c99743eb392cf084438 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: store the create time of a vm under vm_dynamic.vm_last...
by rgolan＠redhat.com 05 Jun '12

05 Jun '12

Roy Golan has submitted this change and it was merged. Change subject: core: store the create time of a vm under vm_dynamic.vm_last_boot_time ...................................................................... core: store the create time of a vm under vm_dynamic.vm_last_boot_time whenever a VM is started, before invoking the Create VDSM verb, we store the current time in vm_dynamic.last_start_time. renamed vm_last_boot_time to last_start_time removed unused vm_last_up_time Change-Id: I75c1b589521173b43a3d791c76fbedf69434a60f Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/create_dwh_views.sql M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1160_remove_and_rename_columns_vm_dynamic.sql M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java 12 files changed, 63 insertions(+), 59 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75c1b589521173b43a3d791c76fbedf69434a60f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: make VmBase.isoPath default to empty string
by rgolan＠redhat.com 05 Jun '12

05 Jun '12

Roy Golan has submitted this change and it was merged. Change subject: core: make VmBase.isoPath default to empty string ...................................................................... core: make VmBase.isoPath default to empty string making the VmBase property isoPath to an empty string is defensive coding against creation of null values when building an XmlRpcStruct which will result exceptions and not being able to run actions against VDSM. while the fix is small, the real solution is to get rid of isoPath since we have cd information kept in vm_devices already. Change-Id: I1dc98767943ddfbc18884d87c22e1f1634bc4b65 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dc98767943ddfbc18884d87c22e1f1634bc4b65 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix en-US locale sent to Jasper to en_US
by oourfali＠redhat.com 05 Jun '12

05 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: fix en-US locale sent to Jasper to en_US ...................................................................... webadmin: fix en-US locale sent to Jasper to en_US no bz Change-Id: I88f7062965ef483924b75b6e0e93012b1a0ef512 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88f7062965ef483924b75b6e0e93012b1a0ef512 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : Fixing locking mechanism at disk scenarious
by mkublin＠redhat.com 05 Jun '12

05 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core : Fixing locking mechanism at disk scenarious ...................................................................... core : Fixing locking mechanism at disk scenarious The following fix should fix a use case for disk scenario, when we are trying to attach/update bootable disk Change-Id: I98089d7388b5bf3ddd6a6fd164f8d82e7ed4bb1f Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 5 files changed, 45 insertions(+), 13 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98089d7388b5bf3ddd6a6fd164f8d82e7ed4bb1f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0