July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: RSDL not expose /storagedomains search capabilities
by mpastern＠redhat.com 09 Jul '12

09 Jul '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL not expose /storagedomains search capabilities ...................................................................... restapi: RSDL not expose /storagedomains search capabilities Change-Id: Ib9d02f8734d4441d5d1bfdfa2946ca3afd08253e Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9d02f8734d4441d5d1bfdfa2946ca3afd08253e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-setup - Replace hardcoded ovirt string
by oschreib＠redhat.com 09 Jul '12

09 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-setup - Replace hardcoded ovirt string ...................................................................... packaging: engine-setup - Replace hardcoded ovirt string Replace hardcoded ovirt string with variable Change-Id: I767cf4dd2bca3bbf38a1a68601fdda31ea2873e6 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M packaging/fedora/setup/output_messages.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Looks good to me, approved Kiril Nesenko: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I767cf4dd2bca3bbf38a1a68601fdda31ea2873e6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Expect required, usages on update network
by mkolesni＠redhat.com 09 Jul '12

09 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Expect required, usages on update network ...................................................................... restapi: Expect required, usages on update network When Update on a cluster's network is called, we expect that the usages & required fields be updated according to what they were set to. Updated the test to reflect that. Change-Id: I846c25fefd62235924c0d91163c7b2875be0a364 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworkResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java 3 files changed, 23 insertions(+), 16 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I846c25fefd62235924c0d91163c7b2875be0a364 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Fix update cluster network (#822631)
by mkolesni＠redhat.com 09 Jul '12

09 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Fix update cluster network (#822631) ...................................................................... restapi: Fix update cluster network (#822631) https://bugzilla.redhat.com/822631 The REST should use UpdateNetworkOnCluster command when updating a cluster's network assignment. There is no need to filter solely based on display network, since the assignment can have more characteristics to it, and it's the responsibility of the engine to update & validate whatever is needed. Change-Id: I3ba860433d0a77caad6405fb30b9b29b0af3a847 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java 2 files changed, 10 insertions(+), 13 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ba860433d0a77caad6405fb30b9b29b0af3a847 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Organize import in cluster network & test
by mkolesni＠redhat.com 09 Jul '12

09 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Organize import in cluster network & test ...................................................................... restapi: Organize import in cluster network & test Organized imports using eclipse in the BackendClusterNetworkResource & BackendClusterNetworkResourceTest classes. This was done in order to allow using organize imports when working on changes in these classes. Change-Id: I0e3f6633c0ffc7d7056ad069a3b5867b3c3a58e3 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java 2 files changed, 8 insertions(+), 10 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e3f6633c0ffc7d7056ad069a3b5867b3c3a58e3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add command to update cluster network
by mkolesni＠redhat.com 09 Jul '12

09 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add command to update cluster network ...................................................................... engine: Add command to update cluster network This command will be used to update the cluster network attachment. Change-Id: I4c85099df16fe6cdffba33108bcb3ec570642ea0 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkOnClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 68 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c85099df16fe6cdffba33108bcb3ec570642ea0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Extract NetworkClusterParameters
by mkolesni＠redhat.com 09 Jul '12

09 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Extract NetworkClusterParameters ...................................................................... core: Extract NetworkClusterParameters This parameters class should be used by command handling attachment (and detachment) of network to cluster. Change-Id: I9f4d08c995398661abf752cc4db9a076b0f0db0e Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsGroupParameter.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/NetworkClusterParameters.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResourceTest.java 4 files changed, 57 insertions(+), 22 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f4d08c995398661abf752cc4db9a076b0f0db0e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add get by id to NetworkClusterDAO
by mkolesni＠redhat.com 09 Jul '12

09 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add get by id to NetworkClusterDAO ...................................................................... engine: Add get by id to NetworkClusterDAO Method is needed to retrieve existing network to cluster attachment. Change-Id: I45a8e5ff2613f8e1891ca82d52d812d6932dc1ef Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkClusterDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkClusterDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkClusterDAOHibernateImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkClusterDAOTest.java 4 files changed, 40 insertions(+), 7 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45a8e5ff2613f8e1891ca82d52d812d6932dc1ef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add NetworkClusterId
by mkolesni＠redhat.com 09 Jul '12

09 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add NetworkClusterId ...................................................................... core: Add NetworkClusterId This class will hold the netwrok to cluster attachment id, and will be used for working with the network_cluster entity in a more organized fashion as a BusinessEntity. Change-Id: Ia054164fc5323a4bf89b0d75aeaf3dc854bf3e3a Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NetworkClusterId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network_cluster.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 3 files changed, 110 insertions(+), 34 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia054164fc5323a4bf89b0d75aeaf3dc854bf3e3a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: use host-subject (certificate) to validate host identit...
by mpastern＠redhat.com 09 Jul '12

09 Jul '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: use host-subject (certificate) to validate host identity during spice initiation ...................................................................... cli: use host-subject (certificate) to validate host identity during spice initiation Change-Id: I45cc9ef17564da82b39c8089627c77a7ed12dca3 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/command/command.py M src/cli/messages.py M src/ovirtcli/command/console.py M src/ovirtcli/platform/posix/spice.py 4 files changed, 29 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45cc9ef17564da82b39c8089627c77a7ed12dca3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0