July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: sdk: Host object doesnt expose storage collection #838269
by mpastern＠redhat.com 09 Jul '12

09 Jul '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: Host object doesnt expose storage collection #838269 ...................................................................... sdk: Host object doesnt expose storage collection #838269 https://bugzilla.redhat.com/show_bug.cgi?id=838269 Change-Id: Ia3c26932bd5dc32e2e1dbe598c4a2af33bd0d9e8 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/main.py M src/codegen/subcollection/subcollection.py M src/ovirtsdk/infrastructure/brokers.py 3 files changed, 64 insertions(+), 17 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3c26932bd5dc32e2e1dbe598c4a2af33bd0d9e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: rebase to latest api
by mpastern＠redhat.com 09 Jul '12

09 Jul '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: rebase to latest api ...................................................................... sdk: rebase to latest api to delete DC method added [@param action.force: boolean] api.networks no longer searchable collection to create SD added [@param storagdomain.storage.override_luns: boolean] VM.delete() no longer requires Action() parameter Change-Id: I6fdd707438a4b39836bc6d9496a7cacf474c38ef Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 185 insertions(+), 67 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fdd707438a4b39836bc6d9496a7cacf474c38ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Disable remove button for blank template
by derez＠redhat.com 08 Jul '12

08 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: userportal: Disable remove button for blank template ...................................................................... userportal: Disable remove button for blank template extended view->select blank template The backend validates it correctly, only the frontend check in UserPortalTemplateListModel.UpdateActionAvailability() was missing. Change-Id: I26fa0ee656a3c9834c0caa1110eab09b637d61c7 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalTemplateListModel.java 2 files changed, 13 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26fa0ee656a3c9834c0caa1110eab09b637d61c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: missing StoragePool name in task description
by derez＠redhat.com 08 Jul '12

08 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: core: missing StoragePool name in task description ...................................................................... core: missing StoragePool name in task description https://bugzilla.redhat.com/817375 * No translation in task's description caused by missing StoragePool name in 'jobProperties'. * Overriden 'getJobMessageProperties' in 'StorageHandlingCommandBase' (adding 'VdcObjectType.StoragePool'). Change-Id: I48e501cbe8f261ddc1ecf7f17a754f5c2a5bacf8 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48e501cbe8f261ddc1ecf7f17a754f5c2a5bacf8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin:RunOnce has Linux boot options for Windo...
by derez＠redhat.com 08 Jul '12

08 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: userportal,webadmin:RunOnce has Linux boot options for Windows (#836220) ...................................................................... userportal,webadmin:RunOnce has Linux boot options for Windows (#836220) https://bugzilla.redhat.com/836220 There is a Linux Boot Options drop down for the Windows base VM. The problem was, that the visibility of an incorrect panel has been adjusted according to the OS type. Change-Id: Ia0cb7df2bf9f3a65d51e1c1f5a8568835a2a1c1c Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0cb7df2bf9f3a65d51e1c1f5a8568835a2a1c1c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AuditLog - remove redundant apostrophes in DiskAlias
by derez＠redhat.com 08 Jul '12

08 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: core: AuditLog - remove redundant apostrophes in DiskAlias ...................................................................... core: AuditLog - remove redundant apostrophes in DiskAlias AuditLogMessages.properties: ${DiskAlias} parameter - removing redundant wrapping apostrophes. Change-Id: Ic9c4c2126840ccdf281228b5e0f4c8a7eda56aef Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 23 insertions(+), 23 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9c4c2126840ccdf281228b5e0f4c8a7eda56aef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding indexing to task related columns at audit log
by yzaslavs＠redhat.com 08 Jul '12

08 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adding indexing to task related columns at audit log ...................................................................... core: Adding indexing to task related columns at audit log As part of exposing correlation ID to API and search, it is required to index the relevant columns (job_id, correlation_id) at audit_log Change-Id: Ib001f4ffed0b6350fb8f4d6686955ac4a7d2308d Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1270_add_task_idx_audit_log.sql 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib001f4ffed0b6350fb8f4d6686955ac4a7d2308d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core no events for attaching/detaching disks
by derez＠redhat.com 08 Jul '12

08 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: core no events for attaching/detaching disks ...................................................................... core no events for attaching/detaching disks https://bugzilla.redhat.com/819289 Added missing LogTypes for attaching/detaching disks. Change-Id: Ibab0bdc0d8d638c003854bc5ffe77a1d96256e58 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 9 files changed, 37 insertions(+), 16 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibab0bdc0d8d638c003854bc5ffe77a1d96256e58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Delete oldNetworkName from UpdateNetworkToVds
by masayag＠redhat.com 08 Jul '12

08 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Delete oldNetworkName from UpdateNetworkToVds ...................................................................... core: Delete oldNetworkName from UpdateNetworkToVds The patch deletes the oldNetworkName from the parameter class of UpdateNetworkToVds. This parameter is obtained internally on engine side by the modified interface rather than relying on the clients to provide that information. Change-Id: I16ea515e15b87a76e0120c839e39c3e61fe12f73 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 3 files changed, 1 insertion(+), 18 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16ea515e15b87a76e0120c839e39c3e61fe12f73 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Allow attaching network to bond
by masayag＠redhat.com 08 Jul '12

08 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Allow attaching network to bond ...................................................................... webadmin: Allow attaching network to bond The patch permits attaching of network to any interface (bonded or not) if it has no network attached to it. Change-Id: Ib930ed665e889d9dd389f9dc251ee91008ae6a4a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib930ed665e889d9dd389f9dc251ee91008ae6a4a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0