July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Disable editing of Vm in pool (#837693)
by derez＠redhat.com 21 Jul '12

21 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Disable editing of Vm in pool (#837693) ...................................................................... webadmin: Disable editing of Vm in pool (#837693) https://bugzilla.redhat.com/837693 The VM which is a part of the pool should not be edited. This patch disables the "Edit" action button in the "Virtual Machines" tab when the selected VM is in a pool. Change-Id: I3a0d097a12f7acfa07a39fe63eb1900e4b73e905 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a0d097a12f7acfa07a39fe63eb1900e4b73e905 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: doesn't try SSO
by derez＠redhat.com 21 Jul '12

21 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: userportal: doesn't try SSO ...................................................................... userportal: doesn't try SSO The UserPortal did not try to perform SSO. The problem was, that the SSO is performed only when the Configurator.privateIsAdmin field is false (see SpiceConsoleModel.PostSendVmTicket), but it was always true. Fixed by setting this field separatly to true for WebAdmin (WebAdminConfigurator) and to false (UserPortalConfigurator). Change-Id: I470e21f5e23a603b1f2cfc415e73e99b9c899e08 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 3 files changed, 8 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I470e21f5e23a603b1f2cfc415e73e99b9c899e08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Do not allow runon/pin-to host (#839230)
by derez＠redhat.com 21 Jul '12

21 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: userportal: Do not allow runon/pin-to host (#839230) ...................................................................... userportal: Do not allow runon/pin-to host (#839230) https://bugzilla.redhat.com/839230 Removed the whole Host tab from new/edit VM dialog for user portal as it contained only the host and cpu pinning. There are no relevant queries to disable - all data are read from the retrieved VM. Change-Id: I6c3bc32e9e0c606ac4eaf118977ab522dd553835 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDesktopNewPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmServerNewPopupView.java 3 files changed, 20 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c3bc32e9e0c606ac4eaf118977ab522dd553835 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: ovirt-engine: update maven findbugs plugin version to 2.5.1
by iheim＠redhat.com 21 Jul '12

21 Jul '12

Itamar Heim has submitted this change and it was merged. Change subject: ovirt-engine: update maven findbugs plugin version to 2.5.1 ...................................................................... ovirt-engine: update maven findbugs plugin version to 2.5.1 Change-Id: I31b9fde05b78953c8636d8fb2b3c14d8bd9db96f Signed-off-by: eedri(a)redhat.com --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eyal Edri: Verified Itamar Heim: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31b9fde05b78953c8636d8fb2b3c14d8bd9db96f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: CommandBase: Solve hiding issues
by lhornyak＠redhat.com 20 Jul '12

20 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: CommandBase: Solve hiding issues ...................................................................... core: CommandBase: Solve hiding issues Renamed method params and local variables to prevent them from hiding member variables. Change-Id: Ie8ba1ee05764321755db5e4612f45a779547a4d6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/6467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8ba1ee05764321755db5e4612f45a779547a4d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: CommandBase: Removed StringHelper
by lhornyak＠redhat.com 20 Jul '12

20 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: CommandBase: Removed StringHelper ...................................................................... core: CommandBase: Removed StringHelper Removed the usage of the deprecated StingHelper class: 1. aggregate was replaced with apache commons' StringUtils.join 2. EqOp was replaces with a simple call to equals, since it was used to compare a variable to a constant string Change-Id: Ie8f43b7f8b329595822dfdb32a77cb33c5cb638e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/6466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8f43b7f8b329595822dfdb32a77cb33c5cb638e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed allow snapshot column data from fixtures
by tnisan＠redhat.com 19 Jul '12

19 Jul '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed allow snapshot column data from fixtures ...................................................................... core: Removed allow snapshot column data from fixtures The fixtures DB data included values for the now non-existing column allow_snapshot, they were removed Change-Id: I2538cc02fe3b062d0c3d5db110efc25696f3571c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/dal/src/test/resources/fixtures.xml 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2538cc02fe3b062d0c3d5db110efc25696f3571c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add warning when running VM as stateless with unsnapab...
by tnisan＠redhat.com 19 Jul '12

19 Jul '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Add warning when running VM as stateless with unsnapable disks (#834891) ...................................................................... core: Add warning when running VM as stateless with unsnapable disks (#834891) https://bugzilla.redhat.com/834891 When trying to run a VM with disks that do not allow snapshots (currently sharable disks and LUN disks), log an event with warning severity Change-Id: I44eec85962a5edf69e5977894de2c3518d4e1dc0 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 18 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44eec85962a5edf69e5977894de2c3518d4e1dc0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removing allow snapshot property from BaseDisk entity
by tnisan＠redhat.com 19 Jul '12

19 Jul '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Removing allow snapshot property from BaseDisk entity ...................................................................... core: Removing allow snapshot property from BaseDisk entity Removed the allow snapshot property from the BaseDisk entity This is a computed value and should not be persisted but rather calculated when needed Change-Id: I826eb81adf573d586408db21d71add7aaefb188c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/dbscripts/base_disks_sp.sql M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1300_remove_allow_snapshot_col.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunDisk.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractBaseDiskRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDisksResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java 23 files changed, 29 insertions(+), 87 deletions(-) Approvals: Tal Nisan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I826eb81adf573d586408db21d71add7aaefb188c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix broken RemoveStorageDomianTest
by mkublin＠redhat.com 19 Jul '12

19 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fix broken RemoveStorageDomianTest ...................................................................... core: Fix broken RemoveStorageDomianTest Commit f7d691107453705bc65bc516480d2f6addb904ea broke RemoveStorageDomainTest, since the behavior of transaction management was not defined in the test. This commit fixes the test by simply running the code the would have been run in the newly introduced autonomous transaction. Change-Id: Ib2c3e39d76a87e849c92a75aaa00c50d332ed19f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainTest.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/6461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2c3e39d76a87e849c92a75aaa00c50d332ed19f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0