July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Improve RemoveStorageDomainCommand
by mkublin＠redhat.com 19 Jul '12

19 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improve RemoveStorageDomainCommand ...................................................................... engine: Improve RemoveStorageDomainCommand The following patch will perform a following improvements: 1. Disable the global transaction at RemoveStorageDomainCommand 2. Set in the memory lock on storage domain during an operation Change-Id: Ide7dd501c26cb4735adfc57612da740398d66df9 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java 1 file changed, 24 insertions(+), 4 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide7dd501c26cb4735adfc57612da740398d66df9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: vms with shared disk will pause ...(#834893)
by emesika＠redhat.com 19 Jul '12

19 Jul '12

Eli Mesika has submitted this change and it was merged. Change subject: core: vms with shared disk will pause ...(#834893) ...................................................................... core: vms with shared disk will pause ...(#834893) https://bugzilla.redhat.com/show_bug.cgi?id=834893 vdsm: vms with shared disk will pause due to I/O errors on double use of PCI Address The main fix to this bug is on the vdsm (separate patch will be sent ), this patch simplifies the vdsm patch code since we assume that disk, floppy and CD will set the shared flag. Change-Id: Ic3f5b74544aec23c8953726b40d6cf4bbcff5019 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3f5b74544aec23c8953726b40d6cf4bbcff5019 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:VM name and Data Domain appears ...(#839727)
by emesika＠redhat.com 19 Jul '12

19 Jul '12

Eli Mesika has submitted this change and it was merged. Change subject: core:VM name and Data Domain appears ...(#839727) ...................................................................... core:VM name and Data Domain appears ...(#839727) ovirt-engine-backend [Task Manager]: VM name and Data Domain appears as <UNKNOWN> in task manager when Importing a vm https://bugzilla.redhat.com/show_bug.cgi?id=839727 Problem was that ImportVmCommand and ImportVmTemplateCommand did not implemented the getJobMessageProperties which is used to set message parameters with actual values. Also fixed same problem (mentioned also in the bug) with AddVmCommand and AddVmFromScratchCommand. Change-Id: Ibbff488263b98afa3b4427cbfb481a1615775bea Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java 3 files changed, 31 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbff488263b98afa3b4427cbfb481a1615775bea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: spring-asm*.jar is required on rhel
by oschreib＠redhat.com 19 Jul '12

19 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spring-asm*.jar is required on rhel ...................................................................... packaging: spring-asm*.jar is required on rhel Split removal of spring-asm*.jar, to allow easy porting to rhel. Change-Id: Idc295434e08b56cb7eed1a8e295af0145bba0357 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc295434e08b56cb7eed1a8e295af0145bba0357 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Reduce VM class instantiation in VmManagementParameter...
by masayag＠redhat.com 19 Jul '12

19 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Reduce VM class instantiation in VmManagementParametersBase ...................................................................... core: Reduce VM class instantiation in VmManagementParametersBase Each call to VmManagementParametersBase.getVM() used to instantiate an instance of the VM class and set it with the same VM static date. The complete treatment would have be to use the VmStatic data rather the VM class, however it requires a wider change. Change-Id: I37b9153c829c77f7c78620e0a3a32b426619722e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/6446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37b9153c829c77f7c78620e0a3a32b426619722e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: user editable configuration files should be protected
by oschreib＠redhat.com 18 Jul '12

18 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: build: user editable configuration files should be protected ...................................................................... build: user editable configuration files should be protected The following configuration files should be protected during upgrade: /etc/engine-config/engine-config.conf /etc/engine-manage-domains/engine-manage-domains.conf Change-Id: Ibedfb181250d17e11cd0cc584f8331f575558d78 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibedfb181250d17e11cd0cc584f8331f575558d78 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RegisterVdsQuery - BitSet instead of indexOf
by tnisan＠redhat.com 18 Jul '12

18 Jul '12

Tal Nisan has submitted this change and it was merged. Change subject: core: RegisterVdsQuery - BitSet instead of indexOf ...................................................................... core: RegisterVdsQuery - BitSet instead of indexOf instead of using String's indexOf function for checking if a char is valid for VDS Id - use Bitset. Change-Id: I87bfd86839080b47d898de1f11c6f8f404eb0fc8 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RegisterVdsQueryTest.java 2 files changed, 76 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87bfd86839080b47d898de1f11c6f8f404eb0fc8 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: wrong error when trying to run VM pinned to host wit...
by shavivi＠redhat.com 18 Jul '12

18 Jul '12

Shahar Havivi has submitted this change and it was merged. Change subject: engine: wrong error when trying to run VM pinned to host with down status ...................................................................... engine: wrong error when trying to run VM pinned to host with down status Change-Id: I0d71b15f2eecd741c768433ad8c870866b8dd99a Signed-off-by: Shahar Havivi<shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 8 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d71b15f2eecd741c768433ad8c870866b8dd99a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Rename column "Host/IP" -> "Hostname/IP" (#744640)
by achub＠redhat.com 18 Jul '12

18 Jul '12

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: Rename column "Host/IP" -> "Hostname/IP" (#744640) ...................................................................... webadmin: Rename column "Host/IP" -> "Hostname/IP" (#744640) Change-Id: I044a353cb1551f2fcffad9ff1106071f90a5d4bc Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I044a353cb1551f2fcffad9ff1106071f90a5d4bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: clear VM device address when changing a vm disk interf...
by rgolan＠redhat.com 18 Jul '12

18 Jul '12

Roy Golan has submitted this change and it was merged. Change subject: core: clear VM device address when changing a vm disk interface (#838462) ...................................................................... core: clear VM device address when changing a vm disk interface (#838462) https://bugzilla.redhat.com/838462 when changing a disk interface and restarting a VM libvirt fails for the address is already in use, thus we need to clear it so it will get allocated with a new one. Change-Id: I7f28c2bf53bdadce38368d0f88e1a8f15208c9dc Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/dbscripts/vm_device_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java 5 files changed, 57 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f28c2bf53bdadce38368d0f88e1a8f15208c9dc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0