July 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: AuditLog messages when attaching multiple SDs

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: AuditLog messages when attaching multiple SDs ...................................................................... core: AuditLog messages when attaching multiple SDs https://bugzilla.redhat.com/817339 Added AuditLog messages when attaching multiple Storage Domains to a DataCenter. Change-Id: I9908d2128ec336fd904d8c4c7ce4975e73ffd23f Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 13 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9908d2128ec336fd904d8c4c7ce4975e73ffd23f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: AddStoragePoolWithStorages remove redundant transactio...

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: AddStoragePoolWithStorages remove redundant transactions ...................................................................... core: AddStoragePoolWithStorages remove redundant transactions * Removing redundant transactions from 'AddStoragePoolWithStoragesCommand' * Adding '@NonTransactiveCommandAttribute' * Removing redundant '@InternalCommandAttribute' Change-Id: I8b1774945dda0df001a2f1b0cfee856138bb05df Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java 1 file changed, 60 insertions(+), 100 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b1774945dda0df001a2f1b0cfee856138bb05df Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Show CanDoAction errors from HotPlugUnplugVmNic in...

by ecohen＠redhat.com

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Show CanDoAction errors from HotPlugUnplugVmNic in UI ...................................................................... webadmin: Show CanDoAction errors from HotPlugUnplugVmNic in UI https://bugzilla.redhat.com/840130 When attempting to deactivate a VM's NIC (action HotPlugUnplugVmNic) and CanDoAction fails, the error message is not propagated to the UI. The JS error is: "[...]Cannot find constant 'VdcActionType___HotPlugUnplugVmNic'[...]" This patch provides the definition needed for GWT to display the error dialog in the UI. Change-Id: Ib5321e7c6c9865c9dae15a6f85ae52d747f5ee6e Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5321e7c6c9865c9dae15a6f85ae52d747f5ee6e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Upgrade config value of supported format to V3

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: core: Upgrade config value of supported format to V3 ...................................................................... core: Upgrade config value of supported format to V3 commit 0d75ccc5 was trying to update a config value using fn_add_config which doesn't update the existing value(it only adds if value doesn't exist). The right way to do it is fn_update_config Change-Id: I93813e12038ec9d13aa0814dd8869858f2f508c1 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93813e12038ec9d13aa0814dd8869858f2f508c1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-guest-agent[master]: agent: new implementation for nics' information function.

by bazulay＠redhat.com

Barak Azulay has submitted this change and it was merged. Change subject: agent: new implementation for nics' information function. ...................................................................... agent: new implementation for nics' information function. The new implementation allows the agent to run without requiring the python-ethtool package to be installed. Change-Id: I2cc663150cb1dc17e568fb429ea786b6baa4ca9e Signed-off-by: Gal Hammer <ghammer(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 33 insertions(+), 13 deletions(-) Approvals: Barak Azulay: Looks good to me, approved Gal Hammer: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cc663150cb1dc17e568fb429ea786b6baa4ca9e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-guest-agent[master]: agent: new implementation for installed application function...

by bazulay＠redhat.com

Barak Azulay has submitted this change and it was merged. Change subject: agent: new implementation for installed application function. ...................................................................... agent: new implementation for installed application function. The new implementation allows the agent to run on Linux distribution which is not based on rpm packages (i.e. Debian). If the distribution's package system is not implemented an empty list of packages is returned. Change-Id: If9694c933dedc9b4f7c76e84e2f621fdee3278a5 Signed-off-by: Gal Hammer <ghammer(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 27 insertions(+), 15 deletions(-) Approvals: Barak Azulay: Looks good to me, approved Gal Hammer: Verified -- To view, visit http://gerrit.ovirt.org/6180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9694c933dedc9b4f7c76e84e2f621fdee3278a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: java.lang.reflect.InvocationTargetException when remov...

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: core: java.lang.reflect.InvocationTargetException when removing vm and exporting it at the same time: Race (#840418) ...................................................................... core: java.lang.reflect.InvocationTargetException when removing vm and exporting it at the same time: Race (#840418) https://bugzilla.redhat.com/840418 The following patch is second part, these patch will intorduce using of lcok mechanism during ExportVm, which will prevent races on same vm Change-Id: I1f9d8d8e6d047c9383cd9a5d5d855c68c3599b6c Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f9d8d8e6d047c9383cd9a5d5d855c68c3599b6c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: java.lang.reflect.InvocationTargetException when remov...

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: core: java.lang.reflect.InvocationTargetException when removing vm and exporting it at the same time (#840418) ...................................................................... core: java.lang.reflect.InvocationTargetException when removing vm and exporting it at the same time (#840418) https://bugzilla.redhat.com/840418 These is a first part of the patch, it will solve a possible NullPointerException at constructor of command and will perfrom some fixes at canDoAction with simplifying of code. If we failed on some canDoAction we will finich immediately Change-Id: Ifee2ed7696b33e3d9fcd4c2e8fcde06a8364baed Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 61 insertions(+), 62 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifee2ed7696b33e3d9fcd4c2e8fcde06a8364baed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: userportal: not passing hostsubject to spice-xpi

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: userportal: not passing hostsubject to spice-xpi ...................................................................... userportal: not passing hostsubject to spice-xpi The problem was, that the add_object_column_white_list_table.sql was ran as pre-upgrade script, but it tried to fill the object_column_white_list according to the not-yet crated view named 'vds'. Solved by creating also post-upgrade scripts, as a last step of the upgrade process and making the add_object_column_white_list_table.sql to be a post-upgrade script. Change-Id: Ice7c00a158a8778a6cb424be4e9720715a4df283 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh A backend/manager/dbscripts/upgrade/post_upgrade/add_object_column_white_list_table.sql D backend/manager/dbscripts/upgrade/pre_upgrade/add_object_column_white_list_table.sql 3 files changed, 86 insertions(+), 74 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice7c00a158a8778a6cb424be4e9720715a4df283 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Set action and type when HotPlugUnplugVmNic fails

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Set action and type when HotPlugUnplugVmNic fails ...................................................................... core: Set action and type when HotPlugUnplugVmNic fails https://bugzilla.redhat.com/826462 When CanDoAction for HotPlugUnplugVmNic (deactivate interface) fails, the variables $action and $type in the error message were not being replaced. Change-Id: I01a6f954e3ebe86aeeb86410ff8a29760f1543e5 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugUnplugVmNicCommand.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01a6f954e3ebe86aeeb86410ff8a29760f1543e5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits July 2012