July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fixing host can stuck at UnAssigned status during acti...
by mkublin＠redhat.com 30 Jul '12

30 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fixing host can stuck at UnAssigned status during activate ...................................................................... core: Fixing host can stuck at UnAssigned status during activate Because of too many opened unneeded transactions host can stuck at UnAssigned status during activate. In order to fix these I disable unneeded global transaction Change-Id: I72d51e80aa5e8fc9e620a14696bf1e8a9f49b0ed Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 14 insertions(+), 6 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72d51e80aa5e8fc9e620a14696bf1e8a9f49b0ed Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Fix Bad Links On New User
by oliel＠redhat.com 30 Jul '12

30 Jul '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Fix Bad Links On New User ...................................................................... restapi: Fix Bad Links On New User Change-Id: I2500a4257c4a788623100b8c992fdcb1c13b8d6c Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java 2 files changed, 22 insertions(+), 6 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2500a4257c4a788623100b8c992fdcb1c13b8d6c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Import linux VM with legacy usb policy (#834254)
by asaf＠redhat.com 30 Jul '12

30 Jul '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: engine: Import linux VM with legacy usb policy (#834254) ...................................................................... engine: Import linux VM with legacy usb policy (#834254) https://bugzilla.redhat.com/834254 Force disabled usb policy for any Linux type VM with legacy usb enabled, This is required in order to support restoring Linux VMs with Legacy USB policy as this policy was allowed in previous versions. Change-Id: I0dd8f02add7082422bd9897e64b10ca3c8396a1b Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0dd8f02add7082422bd9897e64b10ca3c8396a1b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Linux Pool/VM-USB support for "Legacy" can't be ch...
by asaf＠redhat.com 30 Jul '12

30 Jul '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Linux Pool/VM-USB support for "Legacy" can't be changed (#834254) ...................................................................... webadmin: Linux Pool/VM-USB support for "Legacy" can't be changed (#834254) https://bugzilla.redhat.com/834254 Submitted an upgrade script that modifies USB support to 1 (Disabled) for current Linux VMs which USB support set to 0 (Legacy). Change-Id: I9171081bc7be8e2f747c384d270c57d5fda10cd3 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1320_update_usb_policy_of_linux_vms.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9171081bc7be8e2f747c384d270c57d5fda10cd3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disable storage type selectbox when editing DC (#8...
by asaf＠redhat.com 30 Jul '12

30 Jul '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Disable storage type selectbox when editing DC (#834890) ...................................................................... webadmin: Disable storage type selectbox when editing DC (#834890) https://bugzilla.redhat.com/834890 Disable storage type selectbox when editing a DataCenter which already contains storage domains attached. Change-Id: If06da875486acff9faa739805631d649e2c0fdfb Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java 1 file changed, 20 insertions(+), 12 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If06da875486acff9faa739805631d649e2c0fdfb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: ignore address-less interfaces when creating id
by dfediuck＠redhat.com 30 Jul '12

30 Jul '12

Doron Fediuck has submitted this change and it was merged. Change subject: bootstrap: ignore address-less interfaces when creating id ...................................................................... bootstrap: ignore address-less interfaces when creating id There are interfaces that has mac of zero, and there are interfaces without any mac. Example: --- # cat /sys/class/net/*/address f0:de:f1:3a:43:8d 00:00:00:00:00:00 1e:11:dd:d7:2c:b0 6a:e4:ca:72:54:75 1e:11:dd:d7:2c:b0 00:90:51:00:1a:d4 --- Code should also ignore the macless interfaces. + add full path to cat. Change-Id: I95a5718023da976bf955d90ee8b8b8dff6ba07c7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95a5718023da976bf955d90ee8b8b8dff6ba07c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Define NetworkImplementationDetails as serializable
by masayag＠redhat.com 30 Jul '12

30 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Define NetworkImplementationDetails as serializable ...................................................................... core: Define NetworkImplementationDetails as serializable The patch adds serialization support for NetworkImplementationDetails to overcome issues in webadmin. Change-Id: Ifbf22940704d3cf4877214c2509bcc18419fab7b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNetworkInterface.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbf22940704d3cf4877214c2509bcc18419fab7b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Bad error on activating a host twice (#844177)
by oourfali＠redhat.com 30 Jul '12

30 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: Bad error on activating a host twice (#844177) ...................................................................... core: Bad error on activating a host twice (#844177) https://bugzilla.redhat.com/844177 This patch sets the action and type of the command by overriding the setActionMessageParameters method, instead of adding it explicitly, thus it is set also when the command fails on CommandBase operations. Change-Id: I0e44a7863197dd2ac9108da871213a84c469f454 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/6750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e44a7863197dd2ac9108da871213a84c469f454 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: preserve /from/ query param in sake if backward com...
by mpastern＠redhat.com 30 Jul '12

30 Jul '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: preserve /from/ query param in sake if backward compatibility ...................................................................... restapi: preserve /from/ query param in sake if backward compatibility Change-Id: I81f17784568735e0d8a6dda7afb3a6581de5661f Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81f17784568735e0d8a6dda7afb3a6581de5661f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: Easy SSL requirements options EngineAuthentication ...
by ydary＠redhat.com 30 Jul '12

30 Jul '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: Easy SSL requirements options EngineAuthentication jar ...................................................................... reports: Easy SSL requirements options EngineAuthentication jar This patch adds two options to ease the SSL requirements: 1. sslIgnoreCertErrors - ignore certificate errors 2. sslIgnoreHostVerification - don't verify host name Both default to false. In order to set them to true (and by that ignore the validation checks), the applicationContext-security-web.xml file has to be changed, putting the following lines in the EngineSimplePreAuthFilter: <property name="sslIgnoreCertErrors" value="true"/> <property name="sslIgnoreHostVerification" value="true"/> Change-Id: I59523eb2e09067905060b688416aea960558f568 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M reports/jars/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java 1 file changed, 57 insertions(+), 1 deletion(-) Approvals: Muli Salem: Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/6697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59523eb2e09067905060b688416aea960558f568 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0