July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix upgrade script
by emesika＠redhat.com 05 Jul '12

05 Jul '12

Eli Mesika has submitted this change and it was merged. Change subject: core: fix upgrade script ...................................................................... core: fix upgrade script missing a comma in update vmTemplate Change-Id: I9d5835be1613bb80ff4c556a3cbf918d3c8f86a4 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/dbscripts/vm_templates_sp.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/5962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d5835be1613bb80ff4c556a3cbf918d3c8f86a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVmCommand - removing redundant update
by derez＠redhat.com 05 Jul '12

05 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: core: ImportVmCommand - removing redundant update ...................................................................... core: ImportVmCommand - removing redundant update * Removing redundant 'imageToDestinationDomainMap' updating. * Checking 'getCopyCollapse' flag before updating the images list that is retrieved from parameters. Change-Id: I3063f09991ed746201610795cfcbd8f0dc5bf155 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 4 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3063f09991ed746201610795cfcbd8f0dc5bf155 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: template update, migration and pinned host (#835138)
by gchaplik＠redhat.com 05 Jul '12

05 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: template update, migration and pinned host (#835138) ...................................................................... engine: template update, migration and pinned host (#835138) https://bugzilla.redhat.com/835138 currently template doesn't support migration support and pinning vm to a host. the reason for that is these properties, were in vm_static instead of vm_base. besides that add support for it in the dao layer, and gui. Change-Id: I5b3168d57ad415a8b42d06f433f2373b868942a8 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java 8 files changed, 114 insertions(+), 48 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/5918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b3168d57ad415a8b42d06f433f2373b868942a8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: Events on HA VM failures
by oourfali＠redhat.com 05 Jul '12

05 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: backend: Events on HA VM failures ...................................................................... backend: Events on HA VM failures Generate events when a highly available virtual mahine crashes or fails to restart. Change-Id: Ifd2fe3c69409633aaf8143b11994e0962cd37ab7 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 32 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd2fe3c69409633aaf8143b11994e0962cd37ab7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Added missing resources
by asaf＠redhat.com 04 Jul '12

04 Jul '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Added missing resources ...................................................................... webadmin: Added missing resources Added missing resource VdcActionType___MoveOrCopyDisk to LocalizedEnums.(java,properties) Change-Id: I260a7d21ff162cd06fe65d47e61d96c972510241 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I260a7d21ff162cd06fe65d47e61d96c972510241 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: PM options fields are not visible in edit host dia...
by asaf＠redhat.com 04 Jul '12

04 Jul '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: PM options fields are not visible in edit host dialog (#834388) ...................................................................... webadmin: PM options fields are not visible in edit host dialog (#834388) https://bugzilla.redhat.com/834388 Power Management UI input fields are not visible in edit host dialog. Change-Id: I0c9fbfe99e1e233469c5d1fe74cd97306d9812a9 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c9fbfe99e1e233469c5d1fe74cd97306d9812a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: some simplification in VdsSelector
by lhornyak＠redhat.com 04 Jul '12

04 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: some simplification in VdsSelector ...................................................................... core: some simplification in VdsSelector Removed NPE check since it has been checked in caller routine already. Change-Id: Ieb999b731200a25d75c9be4085ceb9f9eb38e999 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb999b731200a25d75c9be4085ceb9f9eb38e999 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: filter the vds by query
by lhornyak＠redhat.com 04 Jul '12

04 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: filter the vds by query ...................................................................... core: filter the vds by query Moves some filtering logic to the DB query. These filters are: - type - vds group id - status - minimum number of cpu's Change-Id: Ia899a81c46f7c0b3fc1e6addecaeb874d356df00 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAOWrapperImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java 6 files changed, 93 insertions(+), 136 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia899a81c46f7c0b3fc1e6addecaeb874d356df00 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Replace logged stacktrace with error message
by masayag＠redhat.com 04 Jul '12

04 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Replace logged stacktrace with error message ...................................................................... core: Replace logged stacktrace with error message The patch replaces the stacktrace being printed to the log on missing keystore file with an error message. Change-Id: Iba75efd4382bcf6795d714aeecea018b047a5500 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/5950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba75efd4382bcf6795d714aeecea018b047a5500 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: no focus on first field when re-installing on a ho...
by asaf＠redhat.com 04 Jul '12

04 Jul '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: no focus on first field when re-installing on a host (#834121) ...................................................................... webadmin: no focus on first field when re-installing on a host (#834121) https://bugzilla.redhat.com/834121 There's no focus on the first field in the dialog of re-installing a host as field focus on views is invoked before the model is initialized, fixed by stopping the model progress only after the model fields are initialized. Change-Id: I00bf94efb1ca327267f5cd8e3105868940816a08 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00bf94efb1ca327267f5cd8e3105868940816a08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0