Change in ovirt-engine[master]: webadmin: adding WithElementId to NFS dialog widgets
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: adding WithElementId to NFS dialog widgets
......................................................................
webadmin: adding WithElementId to NFS dialog widgets
Adding 'WithElementId' annotation to storage popup widgets
(needed for preserving static DOM IDs).
Change-Id: I8b08e09f6e9196a344596d15a64f577d6f466fbb
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/LocalStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.java
3 files changed, 47 insertions(+), 17 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5891
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b08e09f6e9196a344596d15a64f577d6f466fbb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: engine: Remove unused variable 'numberOfValidRecords'.
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Remove unused variable 'numberOfValidRecords'.
......................................................................
engine: Remove unused variable 'numberOfValidRecords'.
This is a private variable that is incremented in the class
but never used anywhere else. Looks redundant, so removing it.
Change-Id: I798bd2a7d59678e646c2b7a85ade8116b34dff13
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/dns/DnsSRVLocator.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5851
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I798bd2a7d59678e646c2b7a85ade8116b34dff13
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 5 months
Change in ovirt-reports[master]: reports: fix repositories in EngineAuthentication pom.xml fi...
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fix repositories in EngineAuthentication pom.xml file
......................................................................
reports: fix repositories in EngineAuthentication pom.xml file
This patch adds repositories that we depend on in the
EngineAuthentication jar file.
Change-Id: Ic0aa90e64be7fe7a6fbf0473df23e20d333c0cf6
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M reports/jars/EngineAuthentication/pom.xml
1 file changed, 39 insertions(+), 0 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5844
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0aa90e64be7fe7a6fbf0473df23e20d333c0cf6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: core: Perfromance improvement
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Perfromance improvement
......................................................................
core: Perfromance improvement
Removed unneeded queries to db, during call for two methods
Change-Id: Ifb10ac2e55d86a4d9e23c4654cb2f31e564fb845
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb10ac2e55d86a4d9e23c4654cb2f31e564fb845
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: core: some StringHelper removal
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: some StringHelper removal
......................................................................
core: some StringHelper removal
removed some of the StringHelper.isNullOrEmpty calls from backend
Change-Id: I61e08278631173e05e2e99e54c2329a5e3c231be
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateComputerAccountCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java
7 files changed, 39 insertions(+), 43 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5859
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61e08278631173e05e2e99e54c2329a5e3c231be
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: packaging: Improvements for the engine start/stop script
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Improvements for the engine start/stop script
......................................................................
packaging: Improvements for the engine start/stop script
Some improvements for the engine start/stop script:
1. Read directly the /etc/sysconfig/ovirt-engine file, so the
engine-service.sh file is no longed needed in environments that
use SystemV scripts.
2. Check the ownership of log files.
3. Check the ownership of the locks directory.
4. Use the standard SystemV start/stop messages and colors.
5. Move the engine-service-logging.properties and from
/etc/ovirt-engine to /usr/share/ovirt-engine and have it owned by
root instead by ovirt, as the engine doesn't need to write to it.
6. Remove the engine-service-users.properties and the
corresponding configuration from the engine-service.xml file.
7. Set resource limits.
8. Add the ENGINE_PROPERTIES variable that can be used to provide
extra system properties to java virtual machine of the engine.
9. Add the restart option and friendly status messages.
Change-Id: I1bada51416584b0f7df1c87484aa3cc8c51aeeb0
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
D packaging/fedora/engine-service-users.properties
M packaging/fedora/engine-service.py
M packaging/fedora/engine-service.sysconfig
M packaging/fedora/engine-service.systemd
D packaging/fedora/engine-service.systemv
M packaging/fedora/engine-service.xml
M packaging/fedora/spec/ovirt-engine.spec.in
8 files changed, 281 insertions(+), 139 deletions(-)
Approvals:
Juan Hernandez: Verified
Ofer Schreiber: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5355
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bada51416584b0f7df1c87484aa3cc8c51aeeb0
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: core: comment fix
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: comment fix
......................................................................
core: comment fix
Fixes minor misspell in the comment.
Change-Id: I523b344e127d41bb8f401b7bc67a42d489d1d2f7
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5890
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I523b344e127d41bb8f401b7bc67a42d489d1d2f7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: restapi: filtering the api according to ApplicationMode
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: filtering the api according to ApplicationMode
......................................................................
restapi: filtering the api according to ApplicationMode
Currently the Application Mode can contain 3 values.
VirtOnly, GlusterOnly and AllModes.
The value of Application Mode is stored in vdc_options table.
It will be read at the time of login and stored in Current.
In GlusterOnly mode, the links pointing to data center, storage domains
vms will not included. Summary vm details also not included.
In VirtOnly mode, the glusterVolumes under the cluster resource will
be hidden.
Appropriate test cases are written for all 3 modes.
Change-Id: I1cf9bebe85ebc3e321006bc6e45c8ba08bfca6dd
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/security/auth/LoginValidatorTest.java
6 files changed, 315 insertions(+), 42 deletions(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Kanagaraj M: Verified
--
To view, visit http://gerrit.ovirt.org/5353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1cf9bebe85ebc3e321006bc6e45c8ba08bfca6dd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 5 months
Change in ovirt-engine-sdk[master]: sdk: cleanup
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: cleanup
......................................................................
sdk: cleanup
Change-Id: I6293083c5a9284f6a92ea1af1a9ce2473876756e
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtsdk/utils/parsehelper.py
M src/ovirtsdk/xml/params.py
2 files changed, 5 insertions(+), 14 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5889
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6293083c5a9284f6a92ea1af1a9ce2473876756e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 5 months
Change in ovirt-engine-sdk[master]: sdk: fix capabilities get/list methods
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: fix capabilities get/list methods
......................................................................
sdk: fix capabilities get/list methods
Capabilities resource has unique structure which is not
fully comply with RESTful collection pattern, but preserved
in sake of backward compatibility
Change-Id: Ic7cf1063342b86af87eda8bba818e89f6ae5330e
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/codegen/collection/collection.py
M src/ovirtsdk/infrastructure/brokers.py
M src/ovirtsdk/xml/params.py
3 files changed, 63 insertions(+), 13 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7cf1063342b86af87eda8bba818e89f6ae5330e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 5 months