July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Cleanup in AuditLogableBase
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup in AuditLogableBase ...................................................................... core: Cleanup in AuditLogableBase Did some general java cleanups: * Added final to immutable members * Removed dependency on the deprecated StringHelper, replaced with commons lang's StringUtils * Replaced FQCNs with imports * Unwrapped some if {return XXX} else {return YYYY} clauses Change-Id: I78cb09b8fe4e607c696a8ded8432604bb95d9fa2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 1 file changed, 12 insertions(+), 15 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78cb09b8fe4e607c696a8ded8432604bb95d9fa2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup in AuditLogDirector
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup in AuditLogDirector ...................................................................... core: Cleanup in AuditLogDirector Did some general java cleanups: * Added final to immutable members * Removed dependency on the deprecated StringHelper * Eclispe IDE formatting Change-Id: Ib87aa8c82d96a9b70340df4ef6cc1d57b7fff74c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib87aa8c82d96a9b70340df4ef6cc1d57b7fff74c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup in TimeoutBase
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup in TimeoutBase ...................................................................... core: Cleanup in TimeoutBase Did some general java cleanup: * Replaced FQCNs with imports * Added final to immutable members * Removed dependency on the deprecated StringHelper Change-Id: I899bbe668d8593dc4ec0947ff157affc2f1ec2ac Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java 1 file changed, 11 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I899bbe668d8593dc4ec0947ff157affc2f1ec2ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Sometimes getting exception when trying to preview sna...
by mkublin＠redhat.com 03 Jul '12

03 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Sometimes getting exception when trying to preview snapshots (#836162) ...................................................................... core: Sometimes getting exception when trying to preview snapshots (#836162) https://bugzilla.redhat.com/836162 The following problem was caused because of a memory lock was released before appropriate data was committed. Solution: Disable a global transaction at TryBackToAllSnapshotsOfVmCommand (preview scenario) Change-Id: I07ec66f6c725827526250a03e04f133783ed7270 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/snapshots_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SnapshotDaoTest.java 5 files changed, 108 insertions(+), 33 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07ec66f6c725827526250a03e04f133783ed7270 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing unused 'KEY_PATTERN'.
by yzaslavs＠redhat.com 03 Jul '12

03 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Removing unused 'KEY_PATTERN'. ...................................................................... engine: Removing unused 'KEY_PATTERN'. The value of the field VmPropertiesUtils.KEY_PATTERN is not used. Change-Id: Ic69d6140ffb61931576ff2d1d9bc4e7fb58bf8c5 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/vmproperties/VmPropertiesUtils.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic69d6140ffb61931576ff2d1d9bc4e7fb58bf8c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing unused local variables from ManageDomains.
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Removing unused local variables from ManageDomains. ...................................................................... engine: Removing unused local variables from ManageDomains. Three variables removed are not being used in the class. Change-Id: I75bcde2799bc7b521750a39163325cfe7dc5b15a Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75bcde2799bc7b521750a39163325cfe7dc5b15a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replacing StringHelper with Apache StringUtils.
by lhornyak＠redhat.com 02 Jul '12

02 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Replacing StringHelper with Apache StringUtils. ...................................................................... engine: Replacing StringHelper with Apache StringUtils. StringHelper is deprecated. Change-Id: I49e09589afadefe3c7f9ad5aa25e316a7d80c0d6 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosUpgrade.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49e09589afadefe3c7f9ad5aa25e316a7d80c0d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removed unused log in KDCLocator
by lhornyak＠redhat.com 02 Jul '12

02 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Removed unused log in KDCLocator ...................................................................... engine: Removed unused log in KDCLocator 'log' is not used in this class. Change-Id: I01698a0166a2cb28a954e181aef55799aba43a74 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KDCLocator.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01698a0166a2cb28a954e181aef55799aba43a74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Supply Action/Type params in VDS activation error mess...
by asaf＠redhat.com 02 Jul '12

02 Jul '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: core: Supply Action/Type params in VDS activation error messages (#783457) ...................................................................... core: Supply Action/Type params in VDS activation error messages (#783457) https://bugzilla.redhat.com/783457 Supply Action/Type params in VDS activation error messages. Change-Id: Ibc104fd2afdf52a37306fd4c487f221d84e7bf91 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc104fd2afdf52a37306fd4c487f221d84e7bf91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Take care of PreStarted VMs and ExectuionContext
by yzaslavs＠redhat.com 02 Jul '12

02 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Take care of PreStarted VMs and ExectuionContext ...................................................................... core: Take care of PreStarted VMs and ExectuionContext This patch fixes a potential to get NPE in PreStarted VMs flow. In addition it fixes command/parameters mismatch issue. Change-Id: I5534534b59825c85816d2256375e6737b3e545a0 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5534534b59825c85816d2256375e6737b3e545a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0