July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Adding VdcObjectType.Storage to JobMessageProperties
by derez＠redhat.com 29 Jul '12

29 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Adding VdcObjectType.Storage to JobMessageProperties ...................................................................... core: Adding VdcObjectType.Storage to JobMessageProperties * StorageHandlingCommandBase: adding VdcObjectType.Storage to JobMessageProperties. * ExecutionMessages.properties removing redundant 'StoragePool' references in. Change-Id: I534d2b6f57e237d01cc32d3a725b1a0eaefae64e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I534d2b6f57e237d01cc32d3a725b1a0eaefae64e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: number_of_vms search - support all operators
by derez＠redhat.com 29 Jul '12

29 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: core: number_of_vms search - support all operators ...................................................................... core: number_of_vms search - support all operators Use NumericConditionRelationAutoCompleter for 'number_of_vms', to support all comparison operators ("<", ">", "<=", ">=", "=", "!="). Change-Id: I639018fbdddd68503a62e580dbc00f20c23c4ba7 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I639018fbdddd68503a62e580dbc00f20c23c4ba7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: adding warning to Force Remove DC dialog
by derez＠redhat.com 29 Jul '12

29 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: adding warning to Force Remove DC dialog ...................................................................... webadmin: adding warning to Force Remove DC dialog https://bugzilla.redhat.com/843096 * Added an abstract ForceRemoveConfirmationPopup - extended by the following views: DataCenterForceRemovePopup and StorageDestroyPopup Change-Id: Idd72db69665623dfd487affdabff39f4bc19e2f3 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ForceRemoveConfirmationPopupPresenterWidget.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ForceRemoveConfirmationPopupView.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ForceRemoveConfirmationPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DataCenterModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/DataCenterForceRemovePopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterForceRemovePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StorageDestroyPopupView.java 10 files changed, 224 insertions(+), 99 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd72db69665623dfd487affdabff39f4bc19e2f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: adding tool-tips to icon columns
by derez＠redhat.com 29 Jul '12

29 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: adding tool-tips to icon columns ...................................................................... webadmin: adding tool-tips to icon columns Added tool-tips to: * DiskImageStatusColumn * SnapshotStatusColumn * DcStatusColumn * NetworkStatusColumn * QuotaDcStatusColumn * StorageDomainSharedStatusColumn * StorageDomainStatusColumn * TaskStatusColumn * Active/Inactive Disk Column Change-Id: Ie1f98752140a5b9acb44abca87aab369611f1241 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskImageStatusColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SnapshotStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/DcStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/NetworkStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/QuotaDcStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainSharedStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/TaskStatusColumn.java 10 files changed, 22 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1f98752140a5b9acb44abca87aab369611f1241 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DiskStorageType enum translation
by derez＠redhat.com 29 Jul '12

29 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: DiskStorageType enum translation ...................................................................... webadmin: DiskStorageType enum translation Adding "Disk$" prefix to DiskStorageType in Enums.java and Enums.properties (since DiskStorageType is an inner enum in Disk object). Change-Id: I4d3ebd1fb6d0bc9c2f9b4bf434a065f250f9bd90 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d3ebd1fb6d0bc9c2f9b4bf434a065f250f9bd90 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Missing RoleType and JobExecutionStauts Enums
by derez＠redhat.com 29 Jul '12

29 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Missing RoleType and JobExecutionStauts Enums ...................................................................... webadmin: Missing RoleType and JobExecutionStauts Enums Added missing RoleType and JobExecutionStauts to Enums.java and Enums.properties. Change-Id: I8cf32bcb73c381d25dd10a9bfda39107dc47c29b Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 2 files changed, 23 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cf32bcb73c381d25dd10a9bfda39107dc47c29b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Complete text for cpu err msg (#834870)
by derez＠redhat.com 29 Jul '12

29 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Complete text for cpu err msg (#834870) ...................................................................... webadmin: Complete text for cpu err msg (#834870) https://bugzilla.redhat.com/834870 When a user specifies bad format in CPU pinning topology, an error code is received, instead of the relevant translated text. This fix adds the error key to AppErrors, so it will get translated and the user will get a proper notification. Change-Id: Id86194930eedcfe10f3c16c189212bd9af3e4859 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id86194930eedcfe10f3c16c189212bd9af3e4859 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding logic to DeactivateStorageDomainCommand.canDoAc...
by yzaslavs＠redhat.com 29 Jul '12

29 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adding logic to DeactivateStorageDomainCommand.canDoAction ...................................................................... core: Adding logic to DeactivateStorageDomainCommand.canDoAction The added logic fails canDoAction in case there are running tasks on a storage pool and there is an attempt to deactivate a master storage domain Change-Id: Icea6b7f841903628757ebb1991684f1c43e8bbd8 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icea6b7f841903628757ebb1991684f1c43e8bbd8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding new engine message
by yzaslavs＠redhat.com 29 Jul '12

29 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adding new engine message ...................................................................... core: Adding new engine message This patch adds a new engine message for the case deactivating a storage domain fails if it is master and there are running tasks on the pool. Change-Id: Iefb4adb75e3def2a03e5d35dc601345a4ec597a9 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 10 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefb4adb75e3def2a03e5d35dc601345a4ec597a9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Getting running tasks on VDSM for data center
by yzaslavs＠redhat.com 29 Jul '12

29 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Getting running tasks on VDSM for data center ...................................................................... core: Getting running tasks on VDSM for data center This added pgsql function accepts as a parameter ID of data center and returns the IDs of the running tasks of it. The DAO part matching this function is also included in this patch This is a first patch in a series of patches to handle blocking of deactive storage domain for master storage domain in case there are running tasks on the pool Change-Id: Ibf8037ba1d12f40b924108fde5c4b9bdbcda8437 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dbscripts/async_tasks_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java 4 files changed, 44 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf8037ba1d12f40b924108fde5c4b9bdbcda8437 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0