July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fixing running vm from pool at UserPoral
by yzaslavs＠redhat.com 02 Jul '12

02 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing running vm from pool at UserPoral ...................................................................... core: Fixing running vm from pool at UserPoral The following fix attaches a new defined step of taking vm from pool to the RunVM command invoked from AttachUserToVmFromPoolAndRun command. It also runs that command with a proper execution context. Change-Id: If863986604a9da15c6c52e6623bac8628a751cf6 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 3 files changed, 27 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If863986604a9da15c6c52e6623bac8628a751cf6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing addSubStep at CommandBase
by yzaslavs＠redhat.com 02 Jul '12

02 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing addSubStep at CommandBase ...................................................................... core: Fixing addSubStep at CommandBase A subStep should added also in case there is no job associated with the command. This can happen when a child command is created, and the job from the parent command was not propagated to it. This happens for example during AttachUserToVmFromPoolAndRunCommand - When creating an execution context for child command, it is required to set the step. However, the job identifies only the parent command that was invoked by the client. Adding a sub step on steps that are created by the parent command will create NPE if there will be an attempt to get the parent step from the job. This patch fixes this issue. Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> Change-Id: I0def5f5ffb896ee946ff3472af92c86074977ed1 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0def5f5ffb896ee946ff3472af92c86074977ed1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove unused log.
by yzaslavs＠redhat.com 02 Jul '12

02 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Remove unused log. ...................................................................... engine: Remove unused log. 'log' variable is not used in this class. Change-Id: Ic087b0605b471d17274ea8d122f7dafe73591ec8 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapSRVLocator.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic087b0605b471d17274ea8d122f7dafe73591ec8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup and UnPowerMock RunVmCommand[Test]
by lhornyak＠redhat.com 02 Jul '12

02 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup and UnPowerMock RunVmCommand[Test] ...................................................................... core: Cleanup and UnPowerMock RunVmCommand[Test] Extracted the logic of CanRunVM to an external class (VmRunHandler) in order to decouple RunVmCommand from other commands. Additional static methods were extracted in VmHadnler and ImagesHandler to better decouple the command. Once this was done, the PowerMockito could be removed from RunVmCommandTest, and the test could generally be cleaned up for better readability, extendability and performance. Change-Id: I2650d70f75fddc4fae0c570273d64c0a1ae9d21a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 10 files changed, 535 insertions(+), 528 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2650d70f75fddc4fae0c570273d64c0a1ae9d21a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: (Partially) Cleanup RunVmCommand
by lhornyak＠redhat.com 02 Jul '12

02 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: (Partially) Cleanup RunVmCommand ...................................................................... core: (Partially) Cleanup RunVmCommand (Partial) java cleanup to RunVmCommand: 1. Replaced deprecated StringHelper with common's StringUtils. 2. Replaced singleton access to external resources with protected access methods where possible. 3. Removed redundent null checks on canDoMessages. 4. Removed commented out block. 5. Made the log final. 6. Eclipse IDE formatting. Change-Id: I1674446fbd448d800824cfc29c960a90329f31fa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 54 insertions(+), 80 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1674446fbd448d800824cfc29c960a90329f31fa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: (Partially) Cleanup VmCommand
by lhornyak＠redhat.com 02 Jul '12

02 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: (Partially) Cleanup VmCommand ...................................................................... core: (Partially) Cleanup VmCommand Performed some general java cleanup in VmCommand: 1. Replaced singleton resource access (e.g. DbFacade.getInstance(), Backend.getInstance()) with protected access methods where possible. 2. Replace FQCNs with imports. 3. Replace depracated StringHelper with commons' StringUtils. 4. Document empty method. 5. Eclipse IDE formatting. Change-Id: Ie933ed461ae9b74e10f7bfc45fb7d9416d4fc31b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 1 file changed, 33 insertions(+), 35 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie933ed461ae9b74e10f7bfc45fb7d9416d4fc31b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Force creation support for block storage
by derez＠redhat.com 02 Jul '12

02 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Force creation support for block storage ...................................................................... webadmin: Force creation support for block storage New iSCSI/FCP storage domain Dialog / DataCenter GuideMe Dialog: * If LUNs in status 'Used' are selected, displaying a confirmation window (with a latch) for approving force creation on the Used LUNs. * Added 'StorageForceCreatePopup-View/Presenter'. Change-Id: I101a5c6700c5e59eea24835ef78b30f6a7330955 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetLunsByVgIdQuery.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractConfirmationPopupView.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/LunModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/StorageModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/guide/GuidePopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/storage/StorageForceCreatePopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StorageDestroyPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StorageForceCreatePopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StorageForceCreatePopupView.ui.xml 17 files changed, 413 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I101a5c6700c5e59eea24835ef78b30f6a7330955 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: LunStatus Enum and CreateVG force flag
by derez＠redhat.com 02 Jul '12

02 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: restapi: LunStatus Enum and CreateVG force flag ...................................................................... restapi: LunStatus Enum and CreateVG force flag ** Added 'LunStatus' Enum: Free, Used, Unusable. * Modified 'StorageLogicalUnitMapper' and 'api' accordingly. ** Added 'override_luns' CreateVG boolean * An optional flag when creating a block device storage domain. * BackendStorageDomainResource: updated 'getSanAddParams' method. * rsdl_metadata: added an optional 'force' argument in add storage. * api: added 'override_luns' boolean to 'IscsiStorage' type. Change-Id: I97615bf04c40f580d56352cb022530b5a0043192 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/LunStatus.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java 7 files changed, 79 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97615bf04c40f580d56352cb022530b5a0043192 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding LunStatus to LUNs business entity
by derez＠redhat.com 02 Jul '12

02 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Adding LunStatus to LUNs business entity ...................................................................... core: Adding LunStatus to LUNs business entity * LunStatus enum: Free, Used, Unusable * Parsing LUNs statuses in GetDeviceListVDSCommand. * Removed obsolete 'includePartitioned' flag. Change-Id: If38fe209751236ed379ef42354f775447f997bc7 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetDeviceListQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunStatus.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDeviceListVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 10 files changed, 38 insertions(+), 49 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If38fe209751236ed379ef42354f775447f997bc7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding force creation support to CreateVG
by derez＠redhat.com 02 Jul '12

02 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Adding force creation support to CreateVG ...................................................................... core: Adding force creation support to CreateVG * Added 'SupportForceCreateVG' configuration value (true for version 3.1 and higher). * Passed 'force' flag to CreateVG iff 'SupportForceCreateVG' is true. * Added new 'CreateVG' method signatures in 'VdsServer' files. Change-Id: Id210012a25f8608b8404155be7f7c44642122dc2 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddSANStorageDomainParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVGVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVGVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 10 files changed, 71 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id210012a25f8608b8404155be7f7c44642122dc2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0