Change in ovirt-engine[master]: webadmin: Unsynced networks boot parameters can be changed (...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Unsynced networks boot parameters can be changed (#848354)
......................................................................
webadmin: Unsynced networks boot parameters can be changed (#848354)
https://bugzilla.redhat.com/848354
If after marking the network as to-sync and changing its parameter,
the to-sync is unmarked, the changed parameters should be reverted.
Change-Id: I688e46577f03dd55024b8eea9c38aec57dfcd511
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
3 files changed, 53 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7586
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I688e46577f03dd55024b8eea9c38aec57dfcd511
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: checking quota even if can-do fails (#846777)
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: checking quota even if can-do fails (#846777)
......................................................................
core: checking quota even if can-do fails (#846777)
https://bugzilla.redhat.com/846777
there is a problem in quota flow, that I validate and set (set is the wrong part here)
quota even if the command fails. that causes a lot of problems when the command fails
and the quota get validated, and the use of that command is getting cached...
therefore, the validate & set quota will be invoked iff all the command will go on to
the execute part.
Change-Id: I0f4dd77582985f521ef0009b421cbd0e83466b57
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7585
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f4dd77582985f521ef0009b421cbd0e83466b57
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: webadmin: block operation with unsync network (#848373)
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: block operation with unsync network (#848373)
......................................................................
webadmin: block operation with unsync network (#848373)
https://bugzilla.redhat.com/848373
- Block operation with unsync network- same as unmanaged network.
- If sync network is detached- The network will get the dc values and will
be condsidered as synced (when detaching the network will automatically
be added to the sync list sent to the backend.)
Change-Id: I0225ec2240ceab7777373812c2742e261ca8534a
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/DcNetworkParams.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
7 files changed, 148 insertions(+), 2 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7580
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0225ec2240ceab7777373812c2742e261ca8534a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: webadmin: Remove checkboxes from 3.0 and less host interface...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Remove checkboxes from 3.0 and less host interfaces tab(#831845)
......................................................................
webadmin: Remove checkboxes from 3.0 and less host interfaces tab(#831845)
https://bugzilla.redhat.com/831845
Remove the selection checkboxes from 3.0 and less host-interfaces sub tab.
Change-Id: Ia0d4f21c4e1b8570a8aa3be954e6bd8868f7d01d
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
5 files changed, 73 insertions(+), 13 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7541
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0d4f21c4e1b8570a8aa3be954e6bd8868f7d01d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: core: SPMAsyncTask: Make logger final
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: SPMAsyncTask: Make logger final
......................................................................
core: SPMAsyncTask: Make logger final
Flagged the logger as final to stress the fact that it's immutable.
In addition, any minor performance enhancement we can get for free would
be welcome here.
Change-Id: I89c182046d7b18a0c86dcd132f6629baaf41d801
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, but someone else must approve
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89c182046d7b18a0c86dcd132f6629baaf41d801
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: core: Disk move job description details (#849981)
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Disk move job description details (#849981)
......................................................................
core: Disk move job description details (#849981)
https://bugzilla.redhat.com/849981
This patch adds details to the CopyOrMoveDiskCommand job, to contain the
source and target storage domains.
Change-Id: Id325e9871d1bac01be1119d92853984bd6ebe1bc
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
2 files changed, 20 insertions(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7607
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id325e9871d1bac01be1119d92853984bd6ebe1bc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: Cluster with Virt and Gluster enabled - configurable
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Cluster with Virt and Gluster enabled - configurable
......................................................................
engine: Cluster with Virt and Gluster enabled - configurable
A new configuration property is added vdc_options named 'AllowClusterWithVirtGlusterEnabled'.
It is to determine whether the user is allowed to create
a cluster with both Virt and Gluster services enable or not.
It will have the default value as true, so that
user can have a cluster with Virt and Gluster enabled.
Required entries are added to engine-config.properties.
Change-Id: I63c501501545f35ee445861f71ec3c7197d66e06
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/tools/engine-config/src/main/resources/engine-config.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
12 files changed, 48 insertions(+), 1 deletion(-)
Approvals:
Kanagaraj M: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7453
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63c501501545f35ee445861f71ec3c7197d66e06
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: core:Enable update for storage domain name(#851835)
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core:Enable update for storage domain name(#851835)
......................................................................
core:Enable update for storage domain name(#851835)
https://bugzilla.redhat.com/show_bug.cgi?id=851835
Update storage domain name fails since lastTimeUsedAsMaster property is
sent from the client is not synchronized with the DB value.
This is because this field is not reflected to the user and it is
internally used in the engine.
The proposed fix is to update the field with the old value from the DB
before update the storage domain in the DB.
Change-Id: I77de69fb8bd28a3c2c1ec1a9be576cb7b4e9dd69
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java
1 file changed, 12 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/7598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77de69fb8bd28a3c2c1ec1a9be576cb7b4e9dd69
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: Changing Directory service exception handling (#844733...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Changing Directory service exception handling (#844733)
......................................................................
core: Changing Directory service exception handling (#844733)
https://bugzilla.redhat.com/844733
The following patch introduces the following:
a. Exception hierarchy for Directory services issues -
a.1. A new DirectoryServiceException class serving base class for
Engine DS exceptions
a.2. Renaming EngineDirectoryServiceException to AuthenticationResultException
and have it extend DirectoryServiceException
b. Throwing DirectoryServiceException at GetRootDSE instead
of current exception swallowing
Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6573
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/AuthenticationResultException.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectoryServiceException.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/EngineDirectoryServiceException.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPIDirContextAuthenticationStrategy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPILdapTemplateWrapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSETask.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LDAPTemplateWrapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchExceptionHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/PrepareLdapConnectionTask.java
12 files changed, 82 insertions(+), 58 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7532
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6573
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: core: setting proper timeout mechanism for GetRootDSE (#8447...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: setting proper timeout mechanism for GetRootDSE (#844733)
......................................................................
core: setting proper timeout mechanism for GetRootDSE (#844733)
https://bugzilla.redhat.com/844733
This is a first patch in series of patches that deals with
a problem that search users reaches a timeout.
In this patch, a proper timeout mechanism is used.
Although it was assumed that changing LdapQueryTimeout
to a low value (i.e - 3 seconds) will yield a timeout after
the provided amount of time, in fact it took longer for
GetRootDSE to timeout.
This patch fixes this issue.
Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6579
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LDAPTemplateWrapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/tools/engine-config/src/main/resources/engine-config.properties
7 files changed, 37 insertions(+), 4 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7479
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6579
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months