August 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: storage_pool cleanup
by lhornyak＠redhat.com 29 Aug '12

29 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: storage_pool cleanup ...................................................................... core: storage_pool cleanup - removed condition from setter Change-Id: I50990e21ed751f3e2119bdfd3bce7ef2eb6bf694 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50990e21ed751f3e2119bdfd3bce7ef2eb6bf694 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix comparison NPE
by lhornyak＠redhat.com 29 Aug '12

29 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: fix comparison NPE ...................................................................... core: fix comparison NPE - changes comparison from parameter.equals(CONSTANT) to CONSTANT.equals(parameter) Change-Id: Iaf25967982cdcba6cb286a1016d07165ea775560 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf25967982cdcba6cb286a1016d07165ea775560 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Use /var/lib/exports for ISOs (#852106)
by juan.hernandez＠redhat.com 29 Aug '12

29 Aug '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Use /var/lib/exports for ISOs (#852106) ...................................................................... packaging: Use /var/lib/exports for ISOs (#852106) https://bugzilla.redhat.com/852106 Use /var/lib/exports as the suggested directory for the NFS ISO storage domain created by the setup tool. Change-Id: I74fe17a045337aedce303c57f9ede71a00e0583d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/setup/basedefs.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74fe17a045337aedce303c57f9ede71a00e0583d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: populate iso domain to nfs share (#852056)
by juan.hernandez＠redhat.com 29 Aug '12

29 Aug '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: populate iso domain to nfs share (#852056) ...................................................................... packaging: populate iso domain to nfs share (#852056) Regression since 3.0. Was removed during: 6250645 Packaging: Update configuration in logcollector and isouploader (#784303) Change-Id: I55abba4831aafc129e0d0b96be9429237c924f95 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55abba4831aafc129e0d0b96be9429237c924f95 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: quota - import vm (#846224)
by gchaplik＠redhat.com 29 Aug '12

29 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: quota - import vm (#846224) ...................................................................... core: quota - import vm (#846224) https://bugzilla.redhat.com/846224 in case we use quota, we should use the vm inside the parameters, instead of the getVm() that reads the vm from the ovf. Change-Id: I228b4defa06bd3a71cf042cb1a894e06d560eba4 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I228b4defa06bd3a71cf042cb1a894e06d560eba4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add warning message to log when running VM stateless (...
by tnisan＠redhat.com 29 Aug '12

29 Aug '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Add warning message to log when running VM stateless (#834891) ...................................................................... core: Add warning message to log when running VM stateless (#834891) https://bugzilla.redhat.com/834891 Add a warning message to the log when running a VM with non snappable disks as stateless Change-Id: I6c7421f45dfa75847482a7abd23ddb5feb7d6f9e Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c7421f45dfa75847482a7abd23ddb5feb7d6f9e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Removing unneeded signalAll
by mkublin＠redhat.com 29 Aug '12

29 Aug '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Removing unneeded signalAll ...................................................................... core: Removing unneeded signalAll The following patch should remove unneeded signalAll from InMemoryLockManager.acquireLockWait The following signallAll is not needed because of all threads will wake up during releaseLock. The signalAll removed from InMemoryLockManager.acquireLockWait in order not to cause unneeded busy wait for waiting threads Change-Id: I21974c2043eee97edaf09a7006a2ac6f25c6e194 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21974c2043eee97edaf09a7006a2ac6f25c6e194 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Import Template Redesign (#840280)
by gchaplik＠redhat.com 29 Aug '12

29 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Import Template Redesign (#840280) ...................................................................... webadmin: Import Template Redesign (#840280) https://bugzilla.rehdat.com/840280 Since Import VM was redesigned it is very easy to use the same View & model also for Import Template purposes. Change-Id: Ib874cdd9395c14cdc724d5e97047476346ca0cf0 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/StorageModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/storage/backup/ImportTemplatePopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportTemplatePopupView.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportTemplatePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/IsProblematicImportVmColumn.java 13 files changed, 367 insertions(+), 1,049 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib874cdd9395c14cdc724d5e97047476346ca0cf0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Import VM dialog redesign (#845947)
by gchaplik＠redhat.com 29 Aug '12

29 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Import VM dialog redesign (#845947) ...................................................................... webadmin: Import VM dialog redesign (#845947) https://bugzilla.redhat.com/845947 https://bugzilla.redhat.com/827097 https://bugzilla.redhat.com/848933 https://bugzilla.redhat.com/840280 https://bugzilla.redhat.com/800424 https://bugzilla.redhat.com/783119 https://bugzilla.redhat.com/830539 https://bugzilla.redhat.com/840628 - A better looking and more intuitive view for import vm dialog (mock-ups in https://bugzilla.redhat.com/840280) - includes a dialog for conflicting vm (vm that already exist in the system) - refactoring the way the dialog works (fetching all the data when dialog loads) - fixing paper cuts bug in the dialog (mainly wrong messages) - adding quota according to multiple storage domain (per disk) Change-Id: I1b6551b235c66e6a32db0f8842cd8e410d6e0318 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportCloneModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportData.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportDiskListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/StorageModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/storage/backup/ImportCloneDialogPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportCloneDialogPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportCloneDialogPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CustomSelectionCell.java 18 files changed, 1,110 insertions(+), 1,235 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b6551b235c66e6a32db0f8842cd8e410d6e0318 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Exception when updating lun disk properties (#844153...
by mlipchuk＠redhat.com 29 Aug '12

29 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Exception when updating lun disk properties (#844153) ...................................................................... engine: Exception when updating lun disk properties (#844153) https://bugzilla.redhat.com/844153 When updating properties of a LUN disk, the audit logger attempted to retrieve the storage pool id of the disk. The method to return the id cast the Parameter to a DiskImage, even though the Parameter was a LunDisk, causing a ClassCastException. Because the storage pool isn't in the audit log, remove the method UpdateVmDiskCommand.getStoragePoolId() altogether. Change-Id: Iba86289c25937002c9c07a06db5651bca4485d38 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba86289c25937002c9c07a06db5651bca4485d38 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0