Change in ovirt-engine[master]: core+ui: USB policy template issues (#850719)
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core+ui: USB policy template issues (#850719)
......................................................................
core+ui: USB policy template issues (#850719)
https://bugzilla.redhat.com/850719
This patch containsL
1. The UI didn't set the proper USB policy on make template from VM.
This patch fixes that behaviour.
2. When copying VM devices, the specParams should be copied in case of
USB devices.
3. Updating USB devices logic.
Change-Id: I90d40c5c13ca997b2981b8e63a3c9c1cf3551869
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
2 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90d40c5c13ca997b2981b8e63a3c9c1cf3551869
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 3 months
Change in ovirt-engine[master]: core: added information to ConnectStorageVDScommand logs (#8...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: added information to ConnectStorageVDScommand logs (#835546)
......................................................................
core: added information to ConnectStorageVDScommand logs (#835546)
https://bugzilla.redhat.com/835546
added to the getPrintableConnectionsList() of ConnectStorageServerVDSCommandParameters additional information which is passed to
the VDS.
Change-Id: I1b613bd18ef9586040862cac56373705f3e65237
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_server_connections.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStorageServerVDSCommandParameters.java
2 files changed, 24 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5748
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b613bd18ef9586040862cac56373705f3e65237
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: core: Commented out right TransactionSupprotTest
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Commented out right TransactionSupprotTest
......................................................................
core: Commented out right TransactionSupprotTest
A previous patch (with change id
9a4433b790ce28da5bfd7861ebb007e9a7bcacb7) commented out a bunch of tests
that use PowerMock. Among them,
org.ovirt.engine.core.utils.TransactionSupportTest was commented out by
mistake - the patch was supposed to comment out
org.engine.core.utils.transaction.TransactionSupportTest.
This patch rectifies this mistake.
Note that uncommenting
org.ovirt.engine.core.utils.TransactionSupportTest is somewhat
pointless, since it's flagged with @Ignore anyway, but it's done for
completeness sake.
Change-Id: Id031f8d74ff21bfd5738f24644521decaa2c9f66
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/TransactionSupportTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/transaction/TransactionSupportTest.java
2 files changed, 601 insertions(+), 600 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7536
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id031f8d74ff21bfd5738f24644521decaa2c9f66
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: core : correct message when suspend vm witout image disks(#8...
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core : correct message when suspend vm witout image disks(#841504)
......................................................................
core : correct message when suspend vm witout image disks(#841504)
https://bugzilla.redhat.com/841504
if VM has no image disks so there is no place to write the suspend file
to. before this message the message that was presented to the user was
regarding low disk space and not related to the fact that the VM doesn't
have any image disks.
Change-Id: I11fb32b54cf159fb63e172504342861493d2aa77
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 18 insertions(+), 0 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11fb32b54cf159fb63e172504342861493d2aa77
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 3 months
Change in ovirt-engine[master]: core:encrypt vds_static pm_password field on upgrade to 3.1
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core:encrypt vds_static pm_password field on upgrade to 3.1
......................................................................
core:encrypt vds_static pm_password field on upgrade to 3.1
In 3.0 all host having PM configured add the agent password
(pm_password) in plain-text.
In 3.1 when we configure PM, we also encrypt its password and it stored
in the database.
This patch goes over all hosts that are upgrading from 3.0 to 3.1 and
encrypt the agent password in the database (vds_static.pm_password) if
it has PM configured (pm_enabled = true)
The patch gets all information needed for the encryption from the
database configuration values (stored in vdc_options) table) and uses
the encryption exposed by store-utils to get the work done.
All the above is executed via a shell script
The script is numbered as 03_00_0420 since 03_00_0410 was the last 3.0
script and we want the shell script to run only when upgrading from 3.0
to 3.1.
Also, please note that the pm_password field in vds_static was changed
from varchar to text in 03_01_0030 and we had to verify that this change
occurs also in our patch. This is OK since the general function used for
that to change the type validates the source type.
Change-Id: I4196ef1070ffabdbc7b8b2846fc4f0340ef07ac8
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
A backend/manager/dbscripts/upgrade/03_00_0420_encrypt_pm_passwd.sh
1 file changed, 37 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7022
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4196ef1070ffabdbc7b8b2846fc4f0340ef07ac8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 3 months
Change in ovirt-engine[master]: core: db function extensions
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: db function extensions
......................................................................
core: db function extensions
Adding a new function that accepts the option_name and value and return
back the option_value.
This function is needed as an infrastructure for further bug resolving.
In case of a shell upgrade script export variables to be used by it.
Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6587
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/dbscripts/dbfunctions.sh
1 file changed, 14 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7021
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6587
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 3 months
Change in ovirt-engine[master]: webadmin: Check HTTP response status for Reports.xml
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Check HTTP response status for Reports.xml
......................................................................
webadmin: Check HTTP response status for Reports.xml
In ReportInit.parseReportsXML method, HTTP response status
should be checked first, before trying to parse response
text as XML.
For example, missing Reports.xml will cause 404 (not found)
HTTP response, with response text being HTML (error page).
Change-Id: I40823031291c6223cf9acb484e5b20d74baa8142
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40823031291c6223cf9acb484e5b20d74baa8142
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 3 months
Change in ovirt-engine[master]: core: Fix notifier parameters
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix notifier parameters
......................................................................
core: Fix notifier parameters
The default parameters of the notifier service are not adjusted
when the engine is configured. This patch changes the notifier so
that it will get the parameters directly from the engine
configuration file /etc/sysconfig/ovirt-engine.
Change-Id: Ic4adb0c079b5d008e83dcf5449582916d8bd9ef3
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/notifier.conf
M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/notifier.sh
M backend/manager/tools/engine-notifier/engine-notifier-service/pom.xml
M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java
M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
M backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/connection-test-notifier.conf
M backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/error-notifier.conf
D backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/login-config.xml
M backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/notifier.conf
D backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/postgres-ds.xml
10 files changed, 26 insertions(+), 224 deletions(-)
Approvals:
Juan Hernandez: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7187
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4adb0c079b5d008e83dcf5449582916d8bd9ef3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 3 months
Change in ovirt-engine[master]: core: Add local configuration helper
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Add local configuration helper
......................................................................
core: Add local configuration helper
This patch adds the LocalConfig class intended to centralize the
management of local configuration stored in the
/etc/sysconfig/ovirt-engine file (or whatever the ENGINE_VARS
environment variable points to).
The name "local" is intended to convey the difference between the
configuration that is specific to a particular node and the
configuration that is "global", stored in the database, and shared
by all the nodes in a (future) cluster.
The intended use is something like this:
LocalConfig config = LocalConfig.getInstance();
String myVar = config.getProperty("MY_VAR");
In addition to this generic interface it also supports other
methods to get the values of well known variables, like port
numbers and directories, for example:
int httpPort = config.getExternalHttpPort();
int httpsPort = config.getExternalHttpPort();
These methods contain some logic to decide if the external
port is the one used by the web server or the one used by the
application server.
Change-Id: Ib0106a71c3a1c7c145d4ca836225ce2a26aa115f
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java
1 file changed, 326 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6673
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0106a71c3a1c7c145d4ca836225ce2a26aa115f
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Anonymous Coward #1000055
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 3 months
Change in ovirt-engine[master]: webadmin: SDs missing from tree (#851853)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: SDs missing from tree (#851853)
......................................................................
webadmin: SDs missing from tree (#851853)
https://bugzilla.redhat.com/851853
The webadmin's left hand side tree was missing individual
storage domains under the storage group Tree pane.
The problem was a wrong use of 'instanceof' operator.
Change-Id: I2de63a284c120f059fa11095e9997f6b22a195da
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7524
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2de63a284c120f059fa11095e9997f6b22a195da
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 3 months