Change in ovirt-engine[master]: webadmin: CPU pinning topology description (#835399)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: CPU pinning topology description (#835399)
......................................................................
webadmin: CPU pinning topology description (#835399)
https://bugzilla.redhat.com/835399
update the description to be more informative
Change-Id: I6c475fc371227b27f557c1fc9cb85a0e6a31a7ff
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7050
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c475fc371227b27f557c1fc9cb85a0e6a31a7ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: hide DC quota subtab (#844626)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: hide DC quota subtab (#844626)
......................................................................
webadmin: hide DC quota subtab (#844626)
https://bugzilla.redhat.com/844626
we show the quota subtab iff the quota is not disables on the
selected datacenter.
Change-Id: Ic6aaf294ca4a733a6913f1883a3a0d9fa4ca6fc3
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
1 file changed, 16 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6aaf294ca4a733a6913f1883a3a0d9fa4ca6fc3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: cleanup: remove org.ovirt.engine.core.utils.hostinstall.Cred...
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: cleanup: remove org.ovirt.engine.core.utils.hostinstall.Credentials
......................................................................
cleanup: remove org.ovirt.engine.core.utils.hostinstall.Credentials
Used internally at MinaInstallWrapper, left over of jsch use, it is not
required any more.
Change-Id: Iba4357fe1b30fc3257b5b5505c9649407c1938ff
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/utils/pom.xml
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/Credentials.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java
3 files changed, 49 insertions(+), 105 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6881
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba4357fe1b30fc3257b5b5505c9649407c1938ff
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
12 years, 4 months
Change in ovirt-engine[master]: bootstrap: new implementation for apache-sshd usage
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: bootstrap: new implementation for apache-sshd usage
......................................................................
bootstrap: new implementation for apache-sshd usage
Major changes:
1. Do not use temporary files for compression/decompression.
2. Do not use wget to pull large files, use ssh for all transfers.
3. One pass on files for digest, compress/decompress, send/receive.
4. Do not pull every 1 second for bytes/status.
5. Test for command status code.
6. File transfer using ssh and md5sum at same session, md5sum written to
stderr.
7. Limit buffer size when reading remote output, so we won't exhaust all
memory.
8. Do not echo back whole file content when sending file.
9. Consistent error, exception handling and debugging information.
10. More unit tests.
Split between pure ssh implementation[1] and application logic[2].
Unit tests now have their own dedicated generic sshd[3], for proper
work in embedded mode ssh apache-ssh-0.7.0 is required.
Separate unit tests dedicated to OVirtSSH implementation, by default
embedded apache-sshd is used, this can be overridden by setting
java system properties, see[4].
As unit tests takes long time, use -Penable-ssh-tests to activate.
[1] org.ovirt.engine.core.utils.ssh.OVirtSSH
[2] org.ovirt.engine.core.utils.hostinstall.MinaInstallWrapper
[3] org.ovirt.engine.core.utils.ssh.SSHD
[4] org.ovirt.engine.core.utils.ssh.TestCommon
Change-Id: I50ba60f2db364114907485da3074feb714615e0c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStream.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressInputStream.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressOutputStream.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/DummyPasswordAuthenticator.java
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/DummyPublickeyAuthenticator.java
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/KeystoreKeyPairProvider.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTimeoutTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/BasicTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/CommandTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStreamTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHD.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TestCommon.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TimeoutTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TransferTest.java
M pom.xml
19 files changed, 2,314 insertions(+), 1,313 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6722
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50ba60f2db364114907485da3074feb714615e0c
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: cleanup: VdsInstaller* methods name compliance
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: cleanup: VdsInstaller* methods name compliance
......................................................................
cleanup: VdsInstaller* methods name compliance
Modify the following classes methods to meet Java standards:
- VdsInstallerSSH
- IVdsInstallerCallback
Change-Id: I8ea5ff946cb70c4836b6364a695ed8ce7911a8b0
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtInstaller.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtUpgrader.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstallHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/IVdsInstallerCallback.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTimeoutTest.java
9 files changed, 65 insertions(+), 65 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6723
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ea5ff946cb70c4836b6364a695ed8ce7911a8b0
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: cleanup: remove install wrappers as there is no selection
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: cleanup: remove install wrappers as there is no selection
......................................................................
cleanup: remove install wrappers as there is no selection
In the past there was multiple implementations for CA and SSH usage. Long
time that the OpenSSL and apache sshd are the only options.
The extra abstraction makes code maintenance complex without any apparent
need.
This change removes this abstraction level in favour of direct usage. It
also rename the 'Mina' to something more meaningful.
REMOVED
ICAWrapper
IVdsInstallWrapper
VdsInstallerFactory
RENAMED
IVdsInstallCallBack->IVdsInstallerCallback
MinaInstallWrapper->VdsInstallerSSH
Change-Id: I9522964674ead688500002f7d581171a5e3a3712
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstallHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/ICAWrapper.java
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/IVdsInstallWrapper.java
R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/IVdsInstallerCallback.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerFactory.java
R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java
R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java
R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTimeoutTest.java
10 files changed, 27 insertions(+), 67 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Doron Fediuck: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7026
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9522964674ead688500002f7d581171a5e3a3712
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: core: quota search for disks (#845297)
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: quota search for disks (#845297)
......................................................................
core: quota search for disks (#845297)
https://bugzilla.redhat.com/845297
Adds quota search for disks with completion support for null values.
Change-Id: I9cb582068c3ed7bf3e9085ce46d34306145ab5a8
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
Doron Fediuck: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7044
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cb582068c3ed7bf3e9085ce46d34306145ab5a8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: core: quota search for templates (#845297)
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: quota search for templates (#845297)
......................................................................
core: quota search for templates (#845297)
https://bugzilla.redhat.com/845297
Enables searching vm templates by quota name, with support for null
Change-Id: I6f56b9cf781007d349f1908e8a177d23a96258b9
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java
2 files changed, 13 insertions(+), 4 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
Doron Fediuck: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6953
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f56b9cf781007d349f1908e8a177d23a96258b9
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: core: quota search for vms (#845297)
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: quota search for vms (#845297)
......................................................................
core: quota search for vms (#845297)
https://bugzilla.redhat.com/845297
Adds quota search for vms with completion support for null values.
Change-Id: Ia202b6e92b52a7729f911f8d62cb744bed637a27
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
Doron Fediuck: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7043
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia202b6e92b52a7729f911f8d62cb744bed637a27
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: core: cleanup VmConditionFieldAutoCompleter
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: cleanup VmConditionFieldAutoCompleter
......................................................................
core: cleanup VmConditionFieldAutoCompleter
- more variable.equals("CONSTANT") to "CONSTANT".equals(variable)
- remove redundant variables
Change-Id: I38fd88727e5d4a58f6de229e38db70daded596f4
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
1 file changed, 18 insertions(+), 23 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
Doron Fediuck: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38fd88727e5d4a58f6de229e38db70daded596f4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months