Change in ovirt-engine[master]: tools: change location of engine-manage-domains.log
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: change location of engine-manage-domains.log
......................................................................
tools: change location of engine-manage-domains.log
move engine-manage-domains.log to /var/log/ovirt-engine/ directory, so that the log collector will collect those logs.
Change-Id: If4681557593662744f23f0ee32b67ca6d9ec6fda
Signed-off-by: Yaniv Bronheim <ybronhei(a)redhat.com>
---
M backend/manager/modules/utils/src/main/resources/engine-manage-domains/log4j.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6855
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4681557593662744f23f0ee32b67ca6d9ec6fda
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: core: Engine sets hosts to NonOperational based on cached in...
by mkublin@redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Engine sets hosts to NonOperational based on cached information (#844291)
......................................................................
core: Engine sets hosts to NonOperational based on cached information (#844291)
https://bugzilla.redhat.com/844291
The following bug was caused because of the following flow:
During process domain recovery engine can move host to Non Operation state ,at
such case was cleaned only cache of storage domain, the cache of storage domains which were reported
by that host as problematic was not cleaned
Change-Id: I4fcfc9cf68131e80a481d8d1962f3afc1c30ae7c
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Michael Kublin: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fcfc9cf68131e80a481d8d1962f3afc1c30ae7c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: engine: Use DiskDAO instead DiskImageDAO (#844169)
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine: Use DiskDAO instead DiskImageDAO (#844169)
......................................................................
engine: Use DiskDAO instead DiskImageDAO (#844169)
https://bugzilla.redhat.com/844169
The following patch fix a bug where user cannot preview a snapshot when
VM contains lun disk, same for remove a snapshot.
This is because the fetch from the DAO is based on disk image instead of
base disk since there can be lun disks in the VM.
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Change-Id: Ie87bf06a9156ffc36177d8ac7218541d8148811a
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6768
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie87bf06a9156ffc36177d8ac7218541d8148811a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
12 years, 5 months
Change in ovirt-engine[master]: webadmin: not vm networks appear in vnic edit dialog
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: webadmin: not vm networks appear in vnic edit dialog
......................................................................
webadmin: not vm networks appear in vnic edit dialog
https://bugzilla.redhat.com/842249
It is possible to configure Non VM Network on VM when editing the VNIC
through edit dialog.
Change-Id: Id15ca02adc86f7040c4dbeeda05c78a11f409a33
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Alona Kaplan: Verified
--
To view, visit http://gerrit.ovirt.org/6820
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id15ca02adc86f7040c4dbeeda05c78a11f409a33
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: core: parameters in error mesaages
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: parameters in error mesaages
......................................................................
core: parameters in error mesaages
https://bugzilla.redhat.com/840795
https://bugzilla.redhat.com/842295
Error message contained ${paramName} instead of the real value because
the canDoActionErro didn't contain the real values.
Change-Id: I6554b1498f09f8ff835b5f1d242557180cd4840d
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkToVdsGroupCommand.java
2 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Alona Kaplan: Verified
--
To view, visit http://gerrit.ovirt.org/6817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6554b1498f09f8ff835b5f1d242557180cd4840d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: engine: Added Enable / Disable CIFS option feature
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Added Enable / Disable CIFS option feature
......................................................................
engine: Added Enable / Disable CIFS option feature
- Added the new cifs configuration constant 'trusted.cifs.disable'.
- Enable / Disable the cifs using the constant key
Change-Id: I761a43e99a67d59b42e58d4bcc8b3db536fa7a41
Signed-off-by: Dhandapani <dgopal(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java
3 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Dhandapani Gopal: Verified
--
To view, visit http://gerrit.ovirt.org/6397
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I761a43e99a67d59b42e58d4bcc8b3db536fa7a41
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: restapi: implement mandatory/optional header def in RSDL
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: implement mandatory/optional header def in RSDL
......................................................................
restapi: implement mandatory/optional header def in RSDL
Change-Id: I34ba91f2faf11e51ea8e8954ff5c6fb74e6cf4e8
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/ParamData.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/Request.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
5 files changed, 284 insertions(+), 131 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34ba91f2faf11e51ea8e8954ff5c6fb74e6cf4e8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: restapi: http header should start with capital letter
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: http header should start with capital letter
......................................................................
restapi: http header should start with capital letter
Change-Id: I01eba956c0cc9f377cab31a715d2d3f1c5d04e2f
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java
5 files changed, 22 insertions(+), 19 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01eba956c0cc9f377cab31a715d2d3f1c5d04e2f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[engine_3.1]: core: vms with shared disk will pause ...(#834893)
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: vms with shared disk will pause ...(#834893)
......................................................................
core: vms with shared disk will pause ...(#834893)
https://bugzilla.redhat.com/show_bug.cgi?id=834893
vdsm: vms with shared disk will pause due to I/O errors on double use of
PCI Address
The main fix to this bug is on the vdsm (separate patch will be sent ),
this patch simplifies the vdsm patch code since we assume that disk,
floppy and CD will set the shared flag.
Change-Id: Ic3f5b74544aec23c8953726b40d6cf4bbcff5019
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
(cherry picked from commit e548c72ee1d9275d363c025ae8d61f4990a8445b)
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6779
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3f5b74544aec23c8953726b40d6cf4bbcff5019
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.1
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: core: Fixup Juno-Maven integration
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: Fixup Juno-Maven integration
......................................................................
core: Fixup Juno-Maven integration
Fixup for the frontend's Juno support which was lost in a rebase.
Change-Id: I23f53de4bfb9ba5818ec1fd53a79b2dba8ef539d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
2 files changed, 1 insertion(+), 11 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/6834
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23f53de4bfb9ba5818ec1fd53a79b2dba8ef539d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
12 years, 5 months