August 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: import block storage domains - fix refresh
by derez＠redhat.com 01 Aug '12

01 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: import block storage domains - fix refresh ...................................................................... webadmin: import block storage domains - fix refresh https://bugzilla.redhat.com/842147 https://bugzilla.redhat.com/843057 Import block Storage Domain: fixing refresh for 'GetExistingStorageDomainList' and 'DiscoverSendTargets' queries. Change-Id: I720d2bb6f2d3a7f7dd228c5337f908b6deab0bb0 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportSanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 4 files changed, 32 insertions(+), 45 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I720d2bb6f2d3a7f7dd228c5337f908b6deab0bb0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Prevent migrating paused VM
by rgolan＠redhat.com 01 Aug '12

01 Aug '12

Roy Golan has submitted this change and it was merged. Change subject: core: Prevent migrating paused VM ...................................................................... core: Prevent migrating paused VM Migrating a paused VM is currently not supported. Added: canDoAction on migration of a paused VM Tested: Running a VM in paused mode and failing to migrate it Have a host with a VM in paused mode, try to Maintenance it, see that its "Preparing For Maintenance" and pending this VM to be stopped/continued. Change-Id: Ib13179ca22f3e00fc73ad91fd6ade1cab83b82d4 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 16 insertions(+), 7 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib13179ca22f3e00fc73ad91fd6ade1cab83b82d4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: VDSM reports iface for network devices
by masayag＠redhat.com 01 Aug '12

01 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: VDSM reports iface for network devices ...................................................................... core: VDSM reports iface for network devices The patch adds support for 3.2 cluster level agents which reports the 'iface' attribute for network devices. Change-Id: Ic8fe367a044122ef62cafe55b13eb34ef7829bab Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 3 files changed, 4 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8fe367a044122ef62cafe55b13eb34ef7829bab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Reorder elements in aop.xml
by yzaslavs＠redhat.com 01 Aug '12

01 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Reorder elements in aop.xml ...................................................................... core: Reorder elements in aop.xml Reordered the elements in aop.xml so that the <weaver> element appears first. This is done to support Eclipse Juno with is stricter than older versions. Change-Id: Ib83bf1446191f7bb7ba7fc02101520cb20d9992d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/resources/META-INF/aop.xml 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib83bf1446191f7bb7ba7fc02101520cb20d9992d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: M2E ignore gwt plugins
by yzaslavs＠redhat.com 01 Aug '12

01 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: M2E ignore gwt plugins ...................................................................... core: M2E ignore gwt plugins Added M2E configuration to ignore gwt plugin execution in order to support M2E bundled with Eclipse Juno. Change-Id: Ic48a50a990884bd9ffd81a75ac509dcbe0fbb055 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/pom.xml 1 file changed, 29 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic48a50a990884bd9ffd81a75ac509dcbe0fbb055 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Explicit maven-compiler-plugin version
by yzaslavs＠redhat.com 01 Aug '12

01 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Explicit maven-compiler-plugin version ...................................................................... core: Explicit maven-compiler-plugin version Explicitly specified maven-compiler-plugin's version wherever it's used, in order to support M2E bundled with Eclipse Juno. Note that the version is defined only once (in the main pom.xml), and used wherever the plugin is called. Change-Id: Ic4ddc22e1172f7740a0dc058813a390f63cbb481 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M pom.xml 3 files changed, 3 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4ddc22e1172f7740a0dc058813a390f63cbb481 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Explicitly set maven-gwt-plugin version
by yzaslavs＠redhat.com 01 Aug '12

01 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Explicitly set maven-gwt-plugin version ...................................................................... core: Explicitly set maven-gwt-plugin version The version is explicitly set in order to better support Eclipse Juno, which does not handle plugin definitions without a version well. Change-Id: Ie71986cb959f05491a6d705293561794cabc7605 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/api/genericapi/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/uicompat/pom.xml 4 files changed, 4 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie71986cb959f05491a6d705293561794cabc7605 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Fix VmNic resource to return action body (#840234)
by mkolesni＠redhat.com 01 Aug '12

01 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Fix VmNic resource to return action body (#840234) ...................................................................... restapi: Fix VmNic resource to return action body (#840234) https://bugzilla.redhat.com/840234 Fixed the calls during activate/deactivate to be made to correct method so that the reponse body is populated as is done in other actions in the API. Change-Id: I300ee91b9bf7268155a5393deeeb9c8c02d90d78 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I300ee91b9bf7268155a5393deeeb9c8c02d90d78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Change inheritance for device resource (#840234)
by mkolesni＠redhat.com 01 Aug '12

01 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Change inheritance for device resource (#840234) ...................................................................... restapi: Change inheritance for device resource (#840234) https://bugzilla.redhat.com/840234 Concrete device resources have actions, so need to change the ancestor BackendReadOnlyDeviceResource to extend AbstractBackendActionableResource and allow these actions to return a response body as all other actions in the API do. Change-Id: I507d3a68c0895e13a42029b69dfaac483856a936 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDeviceResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I507d3a68c0895e13a42029b69dfaac483856a936 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Dashboard tab should be shown for each cluster in ...
by derez＠redhat.com 01 Aug '12

01 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Dashboard tab should be shown for each cluster in the tree ...................................................................... webadmin: Dashboard tab should be shown for each cluster in the tree https://bugzilla.redhat.com/842682 Dashboard tab is shown for "Clusters" instead of a specific "Cluster". Change-Id: I686f46356805e7ead335d4163948fe31c96ad349 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I686f46356805e7ead335d4163948fe31c96ad349 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0