Change in ovirt-engine[master]: core: Remove disable-gluster-tests bll profile
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Remove disable-gluster-tests bll profile
......................................................................
core: Remove disable-gluster-tests bll profile
The profile was introduces to allow speedy building since gluster's
tests where the main place PowerMock was used.
This is no longer true, so this profile is somewhat pointless.
Change-Id: I70c987d3e565148b183d254a94223637560cdf18
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/pom.xml
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70c987d3e565148b183d254a94223637560cdf18
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Fix boot protocol report
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Fix boot protocol report
......................................................................
core: Fix boot protocol report
https://bugzilla.redhat.com/835598
https://bugzilla.redhat.com/835474
https://bugzilla.redhat.com/844176
https://bugzilla.redhat.com/842986
The patch handles mis interpreted boot protocol value by the engine.
* It modifies the logic to resolve which boot protocol is set for the
interface.
* Supports the 'static' value for BOOTPROTO
* Adds evaluation of the boot protocol for bond and vlan for the benefit
of bridgeless network.
Change-Id: I920a174b275fc8eff16357e75fda62ae9e0a4017
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 29 insertions(+), 18 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6800
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I920a174b275fc8eff16357e75fda62ae9e0a4017
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Disable bridges report By VDSM
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Disable bridges report By VDSM
......................................................................
core: Disable bridges report By VDSM
The patch modifies the configured value of SupportBridgesReportByVDSM to
false for 3.1 cluster in order not to refer to bridges element
reported by VDSM.
Change-Id: Ie1abf2c9431e1671da15acb59de735a9549f0ccf
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1abf2c9431e1671da15acb59de735a9549f0ccf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: packaging: engine-service - Fix non-standard port redirectio...
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: engine-service - Fix non-standard port redirection (BZ#844386)
......................................................................
packaging: engine-service - Fix non-standard port redirection (BZ#844386)
Fix HTTP to HTTPS redirection when the engine uses non-standard ports by
setting the "port-redirect" attribure the the service configuration
file.
Change-Id: I868f638b7681b88af33c6bf10b740ab5ce3bdcab
Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com>
---
M packaging/fedora/engine-service.xml.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6795
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I868f638b7681b88af33c6bf10b740ab5ce3bdcab
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: restapi: Fix matching of empty list
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: restapi: Fix matching of empty list
......................................................................
restapi: Fix matching of empty list
If empty list is expected in test, then the matcher would fail because
it contains no elements and the default return value is initialized to
'false'.
Changed default initialization of the return value to 'true' so that it
will be changed to false in the objects are found inequal. No other
change is necessary in this regard, since the method already handles it.
Change-Id: If9144c448881d9373c22c69bd7d222ab88b59f2a
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/test/util/TestHelper.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6652
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9144c448881d9373c22c69bd7d222ab88b59f2a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: engine: Add sync networks to Setup Networks (#838300)
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Add sync networks to Setup Networks (#838300)
......................................................................
engine: Add sync networks to Setup Networks (#838300)
https://bugzilla.redhat.com/838300
Added list of networks that need to be synced to SetupNetworks
parameters. The list allows to specify which networks should be
synched.
Setup Networks will now sync the network if it needs to be synched (i.e.
specified on the list), but if network is unsynched then it's not
allowed to be edited until it's synched.
Change-Id: I433e684f09b104c8eda82b21129bba3e019c58d6
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
3 files changed, 256 insertions(+), 11 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6651
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I433e684f09b104c8eda82b21129bba3e019c58d6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Add error message for network not in sync (#838300)
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add error message for network not in sync (#838300)
......................................................................
core: Add error message for network not in sync (#838300)
https://bugzilla.redhat.com/838300
Network that is not in sync cannot be edited, so added an error message
that will be returned when this situation is encountered.
Change-Id: Ie9cd53730328723aa7f712adb72a4c5ed1f74440
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6650
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9cd53730328723aa7f712adb72a4c5ed1f74440
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: engine: Add create from network to tests
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Add create from network to tests
......................................................................
engine: Add create from network to tests
This method is needed to create initially a NIC that is synchronized to
the network which is on it.
Change-Id: I511d6cce0d906f1482d9c975e7037341d9cb8d69
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
1 file changed, 35 insertions(+), 13 deletions(-)
Approvals:
Mike Kolesnik: Verified
Livnat Peer: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6649
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I511d6cce0d906f1482d9c975e7037341d9cb8d69
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: engine: Fill network details of host NICs query (#838300)
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Fill network details of host NICs query (#838300)
......................................................................
engine: Fill network details of host NICs query (#838300)
https://bugzilla.redhat.com/838300
Added filling of the details in the query.
Change-Id: Ie6f3948a39a424364a2a796fbbb57d881ae341f3
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsInterfacesByVdsIdQuery.java
1 file changed, 21 insertions(+), 9 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6f3948a39a424364a2a796fbbb57d881ae341f3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: engine: Change query to iterate using foreach
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Change query to iterate using foreach
......................................................................
engine: Change query to iterate using foreach
Changed GetVdsInterfacesByVdsIdQuery to iterate over interfaces using
foreach, so that network details can be filled per interface.
Change-Id: I79ec5babb9cb0a2166cc18b5617f1ce944fdd722
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsInterfacesByVdsIdQuery.java
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79ec5babb9cb0a2166cc18b5617f1ce944fdd722
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 4 months