September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: Add posixfs DC type to engine-setup. (BZ#853972)
by juan.hernandez＠redhat.com 24 Sep '12

24 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Add posixfs DC type to engine-setup. (BZ#853972) ...................................................................... packaging: Add posixfs DC type to engine-setup. (BZ#853972) https://bugzilla.redhat.com/show_bug.cgi?id=853972 This patch add posixfs DC type to engine-setup. Change-Id: I382b1fb925807c841ad430381f16a41aa6f55a6b Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M backend/manager/dbscripts/inst_sp.sql M packaging/fedora/setup/engine-setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I382b1fb925807c841ad430381f16a41aa6f55a6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: release 3.2.0.5-1
by mpastern＠redhat.com 24 Sep '12

24 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 3.2.0.5-1 ...................................................................... cli: release 3.2.0.5-1 Change-Id: I0296aaa06ac904f59465f7929b12ff1718852684 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 6 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0296aaa06ac904f59465f7929b12ff1718852684 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: --storagedomain appears as an option in all vm actions ...
by mpastern＠redhat.com 24 Sep '12

24 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: --storagedomain appears as an option in all vm actions #856164 ...................................................................... cli: --storagedomain appears as an option in all vm actions #856164 The reason for this is that actions for vm exist in two dimensions, 1. None 2. storagedomain e.g vm has actions when it in context of storagedomain (like import) and without any context (like start, stop, etc.), auto-completion refactored to be action context-aware and exclude not relevant options for the given context. https://bugzilla.redhat.com/show_bug.cgi?id=856164 Change-Id: Ie8daaf69385450ab8e17d041e2309ad3a0e29a33 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/actioncmdshell.py M src/ovirtcli/shell/cmdshell.py M src/ovirtcli/utils/autocompletionhelper.py 3 files changed, 130 insertions(+), 32 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8daaf69385450ab8e17d041e2309ad3a0e29a33 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: improve edit vm dialog - vcpu editing (#854942)
by tjelinek＠redhat.com 24 Sep '12

24 Sep '12

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: improve edit vm dialog - vcpu editing (#854942) ...................................................................... webadmin: improve edit vm dialog - vcpu editing (#854942) https://bugzilla.redhat.com/854942 Two changes: - Disable the remembering of the already selected cores/socket and always set them to the lowest possible value, when the total cpu cores changes - Move the advanced parameters section closer to the total cpu cores Change-Id: Ie642e76e74891ddf1f8c55e61dcfc9efa0aa363a Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 15 insertions(+), 28 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie642e76e74891ddf1f8c55e61dcfc9efa0aa363a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Run once dialog redesign (#852057)
by tjelinek＠redhat.com 24 Sep '12

24 Sep '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal, webadmin: Run once dialog redesign (#852057) ...................................................................... userportal, webadmin: Run once dialog redesign (#852057) https://bugzilla.redhat.com/852057 Changes: - DisclosurePanel titels are in bold - boot sequence up/down buttons moved to be outside of the list and have "Up" and "Down" labels instead of arrows - width of dialog made bigger to avoid horizontal scroll Change-Id: I55f58598dc8d627c31da31588cfe8530997e05b1 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmRunOncePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmRunOncePopupView.java 5 files changed, 42 insertions(+), 17 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55f58598dc8d627c31da31588cfe8530997e05b1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix NPE in QuotaManager (#855647)
by dfediuck＠redhat.com 23 Sep '12

23 Sep '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix NPE in QuotaManager (#855647) ...................................................................... core: Fix NPE in QuotaManager (#855647) https://bugzilla.redhat.com/855647 Added Null check to the decreaseStorageQuota() method. Change-Id: I6354767e93b5066d4eb167ff8744c1daed18e351 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 27 insertions(+), 3 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6354767e93b5066d4eb167ff8744c1daed18e351 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding CREATE_VM action group to VmPoolAdmin (#857873)
by oourfali＠redhat.com 23 Sep '12

23 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: adding CREATE_VM action group to VmPoolAdmin (#857873) ...................................................................... core: adding CREATE_VM action group to VmPoolAdmin (#857873) https://bugzilla.redhat.com/show_bug.cgi?id=857873 Adding the CREATE_VM action group to VmPoolAdmin, to allow pool admins to edit/create VM pools. Change-Id: I4cfe1aa2bba52cb2aa1bfaf955f661808bbf72c2 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1420_add_create_vm_to_vm_pool_admin.sql 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cfe1aa2bba52cb2aa1bfaf955f661808bbf72c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Apply should be disabled when editing Network para...
by alkaplan＠redhat.com 23 Sep '12

23 Sep '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Apply should be disabled when editing Network params. ...................................................................... webadmin: Apply should be disabled when editing Network params. https://bugzilla.redhat.com/859074 Apply in Edit Network dialog should be diasbled if editing params is enabled. So, if the network is attached to any cluster the apply is enabled until all the clusters are detached. After all the cluster are detached and editing the network properties is permitted the apply should become disabled. Change-Id: I4139c1adbbc23d137e76419a82b377c6b9c2bf0b Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4139c1adbbc23d137e76419a82b377c6b9c2bf0b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Change tool-tip for refresh (#836222)
by alkaplan＠redhat.com 23 Sep '12

23 Sep '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Change tool-tip for refresh (#836222) ...................................................................... webadmin: Change tool-tip for refresh (#836222) https://bugzilla.redhat.com/836222 The tool-tip for the refresh button contains to much information, most of which is irrelevant to the user. The new tool-tip contains only the interval for refresh. Change-Id: I85fda448a93c5a2e326121febb1396f32ebf0629 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GridTimer.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 2 files changed, 26 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved ofri masad: Verified -- To view, visit http://gerrit.ovirt.org/8130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85fda448a93c5a2e326121febb1396f32ebf0629 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: api: ovirt-engine-restapi : two permissions has the same per...
by oourfali＠redhat.com 23 Sep '12

23 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: api: ovirt-engine-restapi : two permissions has the same permit ID (#859233) ...................................................................... api: ovirt-engine-restapi : two permissions has the same permit ID (#859233) https://bugzilla.redhat.com/show_bug.cgi?id=859233 This patch removes the id and the role from the PermitType enum, adding suitable mappers, and changing all dependant code accordingly. Change-Id: I578e227b6e4600715e0ca7a8dfb4dbad79df15b4 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/PermitValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/PermitMapperTest.java 4 files changed, 183 insertions(+), 79 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I578e227b6e4600715e0ca7a8dfb4dbad79df15b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0