Change in ovirt-engine[master]: core: delete last domain fails with engine-manage-domain (#8...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: delete last domain fails with engine-manage-domain (#851069)
......................................................................
core: delete last domain fails with engine-manage-domain (#851069)
Setting AdUserPassword to empty string failed because
AdUserPassword.type is CompositePassword.
CompositePassword must contain the char ':' otherwise set
operation on this value will fail.
The fix lets us also assign empty string to CompositePassword
when we want to erase this value in db.
Change-Id: I9d4904a916f2055288e99114f2f267face16797b
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7604
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d4904a916f2055288e99114f2f267face16797b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: enable Edit button for non-active block SDs (#8507...
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: enable Edit button for non-active block SDs (#850733)
......................................................................
webadmin: enable Edit button for non-active block SDs (#850733)
https://bugzilla.redhat.com/850733
Storage main-tab:
Enabling 'Edit' button when a non-active block storage domain
is selected - the 'Edit Domain' dialog should be opened in
view-only mode (merely for displaying domain's information).
Change-Id: I2bfe64fe10ebe1ddbdd5d8df475b176db5cd9794
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiDiscoverTargetsView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiDiscoverTargetsView.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiTargetToLunView.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
6 files changed, 77 insertions(+), 27 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7592
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bfe64fe10ebe1ddbdd5d8df475b176db5cd9794
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: webadmin: missing hourglass on remove VM from export
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: missing hourglass on remove VM from export
......................................................................
webadmin: missing hourglass on remove VM from export
Added an hourglass to 'remove VM from export domain' dialog.
Change-Id: I172874a0d8cde8ed91e855a8d817dc14bb655793
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7588
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I172874a0d8cde8ed91e855a8d817dc14bb655793
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: API: support name attribute for PortMirrorings Network (#842...
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: API: support name attribute for PortMirrorings Network (#842163)
......................................................................
API: support name attribute for PortMirrorings Network (#842163)
https://bugzilla.redhat.com/show_bug.cgi?id=842163
Change-Id: I4405f1a551dbc32b81e3e521844eee1376e61f6c
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java
2 files changed, 81 insertions(+), 43 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7602
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4405f1a551dbc32b81e3e521844eee1376e61f6c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: restapi: fix /Disk backward compatibility issue
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: fix /Disk backward compatibility issue
......................................................................
restapi: fix /Disk backward compatibility issue
removing /type element from disk will cause
backward compatibility issue between 3.0 & 3.1
Change-Id: I938ecd2d09195c8bbba4964a708f3a73e1534bfe
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7521
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I938ecd2d09195c8bbba4964a708f3a73e1534bfe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months